-
-
Notifications
You must be signed in to change notification settings - Fork 503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(ast_tools): improve correctness and performance of idents #8895
Merged
graphite-app
merged 1 commit into
main
from
02-04-refactor_ast_tools_improve_correctness_and_performance_of_idents
Feb 4, 2025
Merged
refactor(ast_tools): improve correctness and performance of idents #8895
graphite-app
merged 1 commit into
main
from
02-04-refactor_ast_tools_improve_correctness_and_performance_of_idents
Feb 4, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 4, 2025
CodSpeed Performance ReportMerging #8895 will not alter performanceComparing Summary
|
This was referenced Feb 4, 2025
63ca5de
to
cef5ef1
Compare
6b8e955
to
7c8743e
Compare
Merge activity
|
…8895) Refactor. Codegen produces lots of identifiers in the generated code. Ensure they're always prepended with `r#` if they're reserved words. Speed up checking if a name is a reserved word by using a perfect hash set, rather than iterating through an array.
cef5ef1
to
84370a9
Compare
7c8743e
to
6185619
Compare
Base automatically changed from
02-04-refactor_ast_tools_rename_is_visited_to_has_visitor_
to
main
February 4, 2025 23:08
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
0-merge
Merge with Graphite Merge Queue
A-ast-tools
Area - AST tools
C-cleanup
Category - technical debt or refactoring. Solution not expected to change behavior
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor. Codegen produces lots of identifiers in the generated code. Ensure they're always prepended with
r#
if they're reserved words. Speed up checking if a name is a reserved word by using a perfect hash set, rather than iterating through an array.