Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ast_tools): get extra params for visitor methods from #[visit(args)] attr #8887

Conversation

overlookmotel
Copy link
Contributor

@overlookmotel overlookmotel commented Feb 4, 2025

Instead of hard-coding a special case in the Visit codegen for the extra flags param to visit_function, specify that param in an attribute on the type #[visit(args(flags = ScopeFlags))] struct Function { ... }.

Copy link
Contributor Author

overlookmotel commented Feb 4, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@overlookmotel overlookmotel marked this pull request as ready for review February 4, 2025 09:43
Copy link

codspeed-hq bot commented Feb 4, 2025

CodSpeed Performance Report

Merging #8887 will not alter performance

Comparing 02-03-feat_ast_tools_get_extra_params_for_visitor_methods_from_visit_args_attr (c940826) with main (f4662a9)

Summary

✅ 33 untouched benchmarks

Copy link

graphite-app bot commented Feb 4, 2025

Merge activity

@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Feb 4, 2025
…rgs)]` attr (#8887)

Instead of hard-coding a special case in the `Visit` codegen for the extra `flags` param to `visit_function`, specify that param in an attribute on the type `#[visit(args(flags = ScopeFlags))] struct Function { ... }`.
@graphite-app graphite-app bot force-pushed the 02-03-refactor_ast_shorten_generated_code_for_getspan_ branch from f055d92 to 5f5188c Compare February 4, 2025 22:31
@graphite-app graphite-app bot force-pushed the 02-03-feat_ast_tools_get_extra_params_for_visitor_methods_from_visit_args_attr branch from 4764a39 to c940826 Compare February 4, 2025 22:32
Base automatically changed from 02-03-refactor_ast_shorten_generated_code_for_getspan_ to main February 4, 2025 22:38
@graphite-app graphite-app bot merged commit c940826 into main Feb 4, 2025
26 checks passed
@graphite-app graphite-app bot deleted the 02-03-feat_ast_tools_get_extra_params_for_visitor_methods_from_visit_args_attr branch February 4, 2025 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ast Area - AST A-ast-tools Area - AST tools C-enhancement Category - New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant