Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge beatrice(GPOS changes) with master #270

Merged
merged 290 commits into from
Feb 7, 2020
Merged

Merge beatrice(GPOS changes) with master #270

merged 290 commits into from
Feb 7, 2020

Conversation

pbattu123
Copy link

Merge beatrice(GPOS changes) with master

pmconrad and others added 30 commits August 28, 2019 22:36
Fix building error for develop branch + test fix
Fixes database::update_global_dynamic_data to speed up counting missed blocks.
(This also fixes a minor issue with counting - the previous algorithm would skip missed blocks for the witness who signed the first block after the gap.)
[GRPH-70] remove needless find()
Increase block creation timeout to 2500ms
…ional blocks in block_database

Fixed tests wrt db.open
Dont remove blocks from block db when popping blocks, handle edge case in replay wrt fork_db, adapted unit tests
@sonarcloud
Copy link

sonarcloud bot commented Jan 22, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@bobinson
Copy link

We have an error in the CI tests:

1618955ms th_a db_management.cpp:206 open ] Wiping object_database due to missing or wrong version 1618955ms th_a object_database.cpp:93 wipe ] Wiping object database... 1618955ms th_a object_database.cpp:95 wipe ] Done wiping object databse. 1618955ms th_a object_database.cpp:106 open ] Opening object database from /tmp/graphene-tmp/580c-c2ad-62d0-b5a6 ... 1618956ms th_a object_database.cpp:111 open ] Done opening object database. 1618956ms th_a db_management.cpp:240 open ] 10 assert_exception: Assert Exception genesis_state.initial_timestamp.sec_since_epoch() % GRAPHENE_DEFAULT_BLOCK_INTERVAL == 0: Genesis timestamp must be divisible by GRAPHENE_DEFAULT_BLOCK_INTERVAL. {} th_a db_init.cpp:323 init_genesis {} th_a db_init.cpp:999 init_genesis 1618956ms th_a db_management.cpp:240 open ] data_dir: /tmp/graphene-tmp/580c-c2ad-62d0-b5a6 1618956ms th_a database_fixture.cpp:156 database_fixture ] e.to_detail_string(): 10 assert_exception: Assert Exception genesis_state.initial_timestamp.sec_since_epoch() % GRAPHENE_DEFAULT_BLOCK_INTERVAL == 0: Genesis timestamp must be divisible by GRAPHENE_DEFAULT_BLOCK_INTERVAL. {} th_a db_init.cpp:323 init_genesis {} th_a db_init.cpp:999 init_genesis rethrow {"data_dir":"/tmp/graphene-tmp/580c-c2ad-62d0-b5a6"} th_a db_management.cpp:240 open unknown location(0): fatal error: in "wallet_tests/derive_owner_keys_from_brain_key": unknown type /home/gitlab-runner/builds/QDsbRVVn/0/PBSA/peerplays/tests/tests/wallet_tests.cpp(43): last checkpoint: "derive_owner_keys_from_brain_key" fixture ctor *** 195 failures are detected in the test module "Master Test Suite" ERROR: Job failed: exit status 1

reference: https://gitlab.com/PBSA/peerplays/-/jobs/411494045

@pbattu123 pbattu123 added hardfork Needs hardfork New Feature new features ready2merge PRs reviewed and ready for merge, but not merged due to HF or other dependencies labels Feb 7, 2020
@bobinson
Copy link

bobinson commented Feb 7, 2020

ignoring the CI errors as local build works.

@bobinson bobinson merged commit 0b28088 into master Feb 7, 2020
@bobinson bobinson added merged and removed ready2merge PRs reviewed and ready for merge, but not merged due to HF or other dependencies labels Feb 7, 2020
rilesdun pushed a commit that referenced this pull request Feb 8, 2022
rilesdun pushed a commit that referenced this pull request Feb 8, 2022
rilesdun pushed a commit that referenced this pull request Feb 8, 2022
rilesdun pushed a commit that referenced this pull request Feb 8, 2022
…_by_account_id(), get_workers_by_account_id()
rilesdun pushed a commit that referenced this pull request Feb 8, 2022
rilesdun pushed a commit that referenced this pull request Feb 13, 2022
rilesdun pushed a commit that referenced this pull request Feb 13, 2022
#270 functions to unified form

See merge request PBSA/peerplays!61
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hardfork Needs hardfork merged New Feature new features
Projects
None yet
Development

Successfully merging this pull request may close these issues.