[slots] @plone/slots first developments #6409

sneridagh · 2024-10-15T20:23:49Z

Third level strategic package experiments

Experiments on the @plone/slots package. First trials on the shape as a not transpiled, not Volto add-on package to make it work-able as a node_modules package, and compatible with Next.js, vite-based frameworks and ultimately, Volto compatible too, just in case they are necessary there. In order to make it work, this kind of packages must not be under src directory. Let's not fight the ecosystem anymore in this matter. If the package is not being transpiled, the direct resolution must work OOTB, so the bundlers resolution is direct, and the TypeScript resolution too.

I signed and returned the Plone Contributor Agreement, and received and accepted an invitation to join a team in the Plone GitHub organization.
I verified there aren't other open pull requests for the same change.
I followed the guidelines in Contributing to Volto.
I succesfully ran code linting checks on my changes locally.
I succesfully ran unit tests on my changes locally.
I succesfully ran acceptance tests on my changes locally.
If needed, I added new tests for my changes.
If needed, I added documentation for my changes, either in the Storybook or narrative documentation.
I included a change log entry in my commits.

If your pull request closes an open issue, include the exact text below, immediately followed by the issue number. When your pull request gets merged, then that issue will close automatically.

Closes #

* main: (31 commits) Release 18.0.0-alpha.35 Release @plone/types 1.0.0-alpha.16 (fix): export getFieldURL from Url.js in helpers (#6100) Improve container detection, `config.settings.containerBlockTypes` is no longer needed (#6099) Support nested directories in public folder add-on sync folders both … (#6098) Release 18.0.0-alpha.34 Add generated new declarations for a34, just in case (#6097) Release @plone/slate 18.0.0-alpha.13 Release @plone/registry 1.6.0 Release @plone/types 1.0.0-alpha.15 Add support for reading the add-ons `tsconfig.json` paths (#6096) Fixes #6046 pass proper defaults to align and size fields of Image block (#6093) bug fix. relations control panel. Restrict eglible relation targets a… (#6092) Fix Uncaught RangeError: date value is not finite in DateTimeFormat.format (#6088) Add optional `token` parameter to ploneClient initialization (#6077) Blocks Layout Navigator (#5642) Fix internalUrl Widget to Reflect Prop Changes via onChangeBlock (#6036) [types] Improve styleClassNameExtenders types, Icon component JSDoc t… (#6095) Fix link in pop-up RelationsMatrix.jsx (#6085) Fix deselecting lists. (#6080) ...

Co-authored-by: Piero Nicolli <pnicolli@users.noreply.github.com>

* main: (185 commits) Release @plone/components 2.0.0-alpha.15 [components] Fix Select component logic to support `items` use case (#6405) Fix clean make command (#6403) Release 18.0.0-alpha.46 Release @plone/components 2.0.0-alpha.14 Add missing export for new components (#6391) Revert "Fix block chooser search is not focusable when clicked on add button" (#6390) Replace unhelpful words with helpful ones (#6386) Added missing improvement to the build-deps Makefile command (#6383) Added rule for ESlint to detect missing key property in iterators. (#6387) Fix syntax of `html_meta` under `myst` field. (#6385) Release 18.0.0-alpha.45 Release @plone/components 2.0.0-alpha.13 Release @plone/types 1.0.0-alpha.20 Add chapter: theming a base theme (#6328) Upgrade vite to latest (#6373) Porting a few minor fixes upstream (#6382) Added missing arg for `buildStyleClassNamesExtenders` (#6381) Remove pin on Vale, and upgrade to v3.x configuration (#6376) Change formatting from blob of text to definition list. (#6378) ...

* main: Update `typescript` and `vitest` everywhere (#6407) Remove all traces of Jest 24 in core (#6406)

Co-authored-by: Steve Piercy <web@stevepiercy.com>

* main: Adjust the path to perform a proper `git diff` between the cached and… (#6410) Test whether commenting out the `ignore` command has any affect on the Netlify build. support depth in getNavigationQuery (#6400) Update caniuse Oct24 (#6408) Upgraded nextjs deps and configuration (#6388)

Co-authored-by: Steve Piercy <web@stevepiercy.com>

* main: Release 18.0.0-alpha.47 Release generate-volto 9.0.0-alpha.20 Release @plone/scripts 3.7.0 Release @plone/registry 2.0.0-alpha.0 Improve @plone/registry release-it config `@plone/registry` as ESM module, move to TS, complete documentation (#6399)

* main: Added upgrade guide fix for HMR (#6446) Fix CSS lint in Volto Slate (#6444)

* main: (26 commits) Release generate-volto 9.0.0 Changelog Release 18.0.0 Preparations for 18.0.0 final release (#6281) Release @plone/slate 18.0.0 Changelog Release @plone/components 2.0.0 Changelog Release @plone/registry 2.0.0 Changelog Release @plone/types 1.0.0 Changelog Release 18.0.0-alpha.49 Update browserlist (#6455) Update Romanian translation (#6454) Update pt_BR translation (#6453) Release 18.0.0-alpha.48 Fix declaration emits for wrong JSDocs Release @plone/slate 18.0.0-alpha.20 Release @plone/types 1.0.0-alpha.22 ...

stevepiercy

Another WIP review.

stevepiercy · 2024-11-01T21:10:15Z

packages/slots/components/MainFooter.tsx

+    <Container layout className="footer">
+      {/* TODO: i18n properly */}
+      <div className="footer-message">
+        The Plone® Open Source CMS/WCM is © 2000-2024 by the Plone Foundation


WTF is a WCM, other than alphabet soup? mmm... soup...

Can we make the end year dynamic, so we don't have to update this every January 1?

stevepiercy · 2024-11-01T21:12:59Z

packages/slots/components/MainFooter.tsx

+      {/* TODO: i18n properly */}
+      <div className="footer-message">
+        The Plone® Open Source CMS/WCM is © 2000-2024 by the Plone Foundation
+        and friends. <br />


We should be explicit or remove this statement. I thought the Zope Foundation ceased to exist for the purpose of Plone, so we have no friends. so lonely...

stevepiercy · 2024-11-01T21:18:46Z

packages/slots/components/MainFooter.tsx

+      <div className="footer-message">
+        The Plone® Open Source CMS/WCM is © 2000-2024 by the Plone Foundation
+        and friends. <br />
+        Distributed under the GNU GPL license.


Now that Volto is distributed under the MIT license, should this be modified to include that? This might be a lawyer or Board question. At the very least, we should specify the license version number.

Suggested change

Distributed under the GNU GPL license.

Distributed under the GNU GPLv2 license.

Should we maybe try to have everything under the same license in the plone github org? Agree this is a lawyer/Board question

I really don't know. This is the only information I have, but it seems that the Board wants only GPLv2.

https://plone.org/foundation/copyright-licensing-logo/license-faq

Side note, I don't know the process or legal concerns about switching Volto core's license. Contributions have been made under multiple licenses, including BSD2, BSD3, and MIT.

stevepiercy · 2024-11-01T21:19:34Z

packages/slots/components/MainFooter.tsx

+        <Logo content={content} location={location} />
+      </div>
+      <a className="item powered-by" href="https://plone.org">
+        Powered by Plone & Python


If we list one language, then we'll need to include them all. No, thank you.

Suggested change

Powered by Plone & Python

Powered by Plone

stevepiercy · 2024-11-01T21:23:51Z

packages/slots/components/App.stories.tsx

+        },
+        site: {
+          'plone.site_title': 'Plone site',
+          // 'plone.site_logo': 'https://sneridagh.dev/',


I think this needs to be updated.

stevepiercy · 2024-11-01T21:24:07Z

packages/slots/components/Header.stories.tsx

+        },
+        site: {
+          'plone.site_title': 'Plone site',
+          // 'plone.site_logo': 'https://sneridagh.dev/',


stevepiercy · 2024-11-01T21:24:20Z

packages/slots/components/Logo.stories.tsx

+        },
+        site: {
+          'plone.site_title': 'Plone site',
+          // 'plone.site_logo': 'https://sneridagh.dev/',


* main: Fix require load of CJS config from ESM module (#6458) Fix redirects (#6457) Clean up add-on-registry.md docs (#6456)

* main: (27 commits) React Router 7 experimental PoC (#6472) First batch of the overhaul of the add-ons section (#6397) URL Management control panel: show errors from CSV upload (#6473) Release 18.0.3 Release @plone/registry 2.1.2 Preparing for 18.0.3 Fix weird issue in images build with typings (#6471) Release 18.0.2 Release @plone/providers 1.0.0-alpha.5 Release @plone/scripts 3.8.1 Release @plone/components 2.1.1 Fix packaging and plone/components src export (#6470) Release @plone/registry 2.1.1 Repackage registry Release 18.0.1 Release @plone/providers 1.0.0-alpha.4 Release @plone/components 2.1.0 Release @plone/client 1.0.0-alpha.20 Release @plone/scripts 3.8.0 Release @plone/registry 2.1.0 ...

…l demo to RR7 PoC

…it work in SSR too (#6480)

sneridagh and others added 18 commits June 5, 2024 08:28

Improve and group providers

eb1ae1a

Polish

b2838b3

Changelog

a6c2c68

Complete the AppRouter with all the needed props

aab9efa

Apply suggestions from code review

f773a6a

Co-authored-by: Piero Nicolli <pnicolli@users.noreply.github.com>

WIP

bcc5c08

WIP2

b800ec8

Fix remix data loading, update NextJS and remix versions

2960884

Ugrade vite TSR, fix useParams and useLocation types

5558b83

Merge branch 'main' into betterproviders

77b7ba9

* main: Update `typescript` and `vitest` everywhere (#6407) Remove all traces of Jest 24 in core (#6406)

Missing remix change

9686d57

Fix TSR in SSR

2921cec

READMEs to experimental packages

2aa4f36

Fix ESlint

f362f06

Ignore TS errors on build for now

f53004e

WIP

c2bf16a

sneridagh requested a review from pnicolli October 15, 2024 20:23

lock

21de7e2

sneridagh mentioned this pull request Oct 16, 2024

[slots] @plone/slots first developments - Login form #6067

Draft

sneridagh and others added 9 commits October 16, 2024 09:13

Better admonitions format for experimental notices.

dab7b8e

Return whole context instead of only useLocation

905de9e

Apply suggestions from code review

1c8c099

Co-authored-by: Steve Piercy <web@stevepiercy.com>

Better branding here

eb10805

Latest touches

b97f9a9

Changelog

e07972f

Fix linting

a9802d2

Apply suggestions from code review

fb339b4

Co-authored-by: Steve Piercy <web@stevepiercy.com>

sneridagh added 11 commits October 26, 2024 18:14

Logo component :) with Storybook

6cc4cb3

WIP, Navigation

8ca5305

lock

5b2db11

WIP Navigation and Main slot

3accc47

Merge branch 'main' into slots-base

699b79f

* main: Added upgrade guide fix for HMR (#6446) Fix CSS lint in Volto Slate (#6444)

Progress in contentarea and footer

61ca316

Footer

d19bb68

Move to full add-ons for slots and blocks

d7a3000

Simple image component

cb9034a

stevepiercy requested changes Nov 1, 2024

View reviewed changes

sneridagh and others added 18 commits November 2, 2024 16:21

Merge branch 'main' into slots-base

25719a8

* main: Fix require load of CJS config from ESM module (#6458) Fix redirects (#6457) Clean up add-on-registry.md docs (#6456)

Proper proxy for Remix app, proper @plone/registry config. Basic teaser.

f89b43b

Proper data acquire in Remix PoC. Better name in vite-plugin. Add ful…

2d02a4a

…l demo to RR7 PoC

New theming package, fix routes in Remix, layers in theming, add reset.

3cde909

Add layers to the @plone/components styles

9976619

Move RenderBlocks and related to @plone/blocks

f512b88

Introduce @plone/theming

403d318

Docs 6472 tidy (#6475)

1e11ff1

Dutch Translations update. (#6476)

f062cee

fix locales

6f3bb71

Add missing style Helmet serialization in the HTML component to make …

6532984

…it work in SSR too (#6480)

Release @plone/slate 18.0.1

f532b56

Release 18.1.0

ee02c44

Base styles, various improvements

d356de3

Improve deployment settings, add apiPath/internalApiPath detection

53cec1b

Revamp the RR7 app, fix all the problems related to deployments.

c26f77c

Improve proxy, missing code from last commit

ad15951

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[slots] @plone/slots first developments #6409

[slots] @plone/slots first developments #6409

sneridagh commented Oct 15, 2024 •

edited

Loading

stevepiercy left a comment

stevepiercy Nov 1, 2024

stevepiercy Nov 1, 2024

stevepiercy Nov 1, 2024

pnicolli Nov 20, 2024

stevepiercy Nov 20, 2024

stevepiercy Nov 1, 2024

stevepiercy Nov 1, 2024

stevepiercy Nov 1, 2024

stevepiercy Nov 1, 2024

	Distributed under the GNU GPL license.
	Distributed under the GNU GPLv2 license.

[slots] @plone/slots first developments #6409

Are you sure you want to change the base?

[slots] @plone/slots first developments #6409

Conversation

sneridagh commented Oct 15, 2024 • edited Loading

Third level strategic package experiments

stevepiercy left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sneridagh commented Oct 15, 2024 •

edited

Loading