Latest #4
Merged
Latest #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
) * replaced deprecated getWindowTopLocation with refererInfo.referer * Removed unused import and unnecessary reassign * Rename variable bidderRequests to bidderRequest Renamed the bidderRequests variable to the singular bidderRequest to better portray the value as a single request instead of multiple.
* new TapHype bidder adapter * Added 930x600 to Rubicon Adapter (#3323) * PubMatic adapter to support TTD (#3311) * first commit * added unit test cases for TTD id * Sonobi - support video and display same adunit (#3325) * changed adapter to support video and display for ad unit * added case for sbi_ct outstream * outstream is display media type * Fix user-sync iframes insertion bug (#3300) According to documentation, iframes should be inserted at bottom of head, rather than at top. * Prevent 33Across adapter from throwing an error when unable to getElementById(), fix JSDocs in utils.js (#3333) * check gdpr in buildRequest * User sync based on whether gdpr applies or not * check if consent data exists during user sync * split user sync into further branches: 1) when gdpr does not apply 2) when consent data is unavailable * contribute viewability to ttxRequest * update tests * remove window mock from tests * use local variables * introduce ServerRequestBuilder * add withOptions() method to ServerRequestBuilder * add semicolons * sync up package-lock.json with upstream/master * stub window.top in tests * introduce getTopWindowSize() for test purpose * reformat code * add withSite() method to TtxRequestBuilder add withSite() method to TtxRequestBuilder * add isIframe() and _isViewabilityMeasurable() * handle NON_MEASURABLE viewability in nested iframes * consider page visibility, stub utils functions getWindowTop() and getWindowSelf() * contribute viewability as 0 for inactive tab * add prebidjs version to ttx request * send caller as an array * fix JSDoc in utils.js * send viewability as non measurable when unable to locate target HTMLElement, add warning message * TripleliftBidAdapter-update creative_id (#3324) * removed dependancy on getTopWindowUrl for referer * protect against undefined obj and remove test on old dependency * added unit test for referer and gdpr in query string * removed gdpr test * removed gdpr from bidderRequest obj * decontructed bidder request obj in chai test * just need to run karma tests again * added gdpr consent to all bidderRequest obj in chai tests * changed creativeId to be a Triplelift specific id rather than represent SRA impression * error-proofed creative id * Update taphypeBidAdapter.js removed `supportedMediaTypes` and logging * Update taphypeBidAdapter.js remove mediaTypes import * new TapHype bidder adapter * Update taphypeBidAdapter.js removed `supportedMediaTypes` and logging * Update taphypeBidAdapter.js remove mediaTypes import
* update gulp packages to address vulnerability * some minor cleanup in the gulpfile tasks * replace the fork used for gulp-footer
* initial version of ozone adapter for review * updates made per prebid.org feedback * Added a new line as failed prebid.org automated test * Unit Tests for Ozone Adaptor * updated URIs to include https protocol which failed tests
Squashed commits: [1b55ca0] update AdGenetation adapter
…sizes array (#3317) * Submitting EMX Digital Prebid Adapter Submitting EMX Digital Prebid Adapter code * fixing lint errors. updating our md * updating to const/let variables. adding test spec. * fixed linting on test spec js * adding emx usersync methods * updating valid bid request checks and protocol check. * remove includes replaced with indexOf * adding more bid valid checks. updating how we grab sizes array * linting fix * code typo fixed * updated our spec
* Add a new ucfunnel Adapter and test page * Add a new ucfunnel Adapter and test page * 1. Use prebid lib in the repo to keep updated 2. Replace var with let 3. Put JSON.parse(JSON.stringify()) into try catch block * utils.getTopWindowLocation is a function * Change to modules from adapters * Migrate to module design * [Dev Fix] Remove width and height which can be got from ad unit id * Update ucfunnelBidAdapter to fit into new spec * Correct the endpoint. Fix the error of query string * Add test case for ucfunnelBidAdapter * Fix lint error * Update version number * Combine all checks on bid request * Add GDPR support for ucfunnel adapter * Add in-stream video and native support for ucfunnel adapter * Remove demo page. Add more test cases. * Change request method from POST to GET * Remove unnecessary comment * Support vastXml and vastUrl for video request * update TTL to 30 mins * Avoid using arrow function which is not discuraged in mocha
* Set the device dimensions if the config didnt do it. * add unit tests * Added a regresstion test to catch the bug. The code should still populate w and h even if the config doesnt have that object.
removing out console.log statements in ozoneBidAdapter test file
* Bidfluence Adapter update Support single call to server for all bids * Bidfluence Adapter update Support single call to server for all bids - relative to adapter update
* conditionally adds another param to browserParams * fixes lint error
* update unit test example to mocha recommendations * fix formatting
* Added Supply2 Bid Adapter with spec file * Supply2BidAdapter: fix typo
* changes to not show dctr message when none of the adunits have dctr set * added usage description for dctr and currency params
* Add user sync pixel logic in Adtelligent adapter * Add gdpr support * Add gdpr support * Update tests
* updating appnexus debug auction to be cookie-only * adding getCookie to utils * remove LGTM alert on getCookie * fix failed tests
…s to determine the video player size (#3372)
* Create collectcentBidAdapter.js New bider adapter for collectcent * Create collectcentBidAdapter.md Description and integration example * Create collectcentBidAdapter_spec.js Collectcent bidder adapter tests added * Update collectcentBidAdapter_spec.js edit * Update collectcentBidAdapter.js Used bidderRequest.refererInfo.referer instead of window.location * Update collectcentBidAdapter.js * Update collectcentBidAdapter.js Rename URL to URL_MULTI
* fix indent * add handling iframe user sync
* Rivr thin adapter (#5) * RVR-2049 - change impression event * RVR-2049 - fix user id value returned on creation of the cookie * RVR-2049 - remove blockedCategories and browser properties from Auction object * RVR-2060 - rewrite rendering detection for impression and click events * RVR-2060 - rewrite tests for rendering detection for impression and click events * RVR-2049 - send ad unit code in click event * RVR-2049 - adapt tests for click event * RVR-2072 - split impression detection depending on the ad server - DFP/none * RVR-2056 - set creativeId in Auction -> received bids * RVR-2056 - set bid.clearPrice to cmp * RVR-2087 - extract trackAuctionInit implementation to rivraddon * RVR-2087 - extract implementation to rivraddon WIP * RVR-2087 - extract implementation to rivraddon * RVR-2087 - extract implementation to rivraddon * RVR-2087 - Update package-lock * RVR-2087 - Add addons check * Rivr Thin Adapter - part 2 (#6) * RVR-2087 - Remove sendAuction call from ExpiringQueue * RVR-2147 - Fix test failing on IE 11.0.0 * RVR-2087 - Remove ExpiringQueue
* Fix multi-bid adId in Criteo bid adapter A single bid request can generate multiple bids if it has multiple sizes. However, by default 'adId' will be filled with the bid request's 'bidId' field, so if we create two bids from the same bid request, they will share the same 'adId'. Because of this, Prebid will not know which bid to use once DFP makes either of those bids win, always taking the first one (see 'auctionManager.findBidByAdId' used in 'pbjs.renderAd'). * Increment Criteo adapter version * Add test for Criteo multi-bid fix
…ze instead of bid.sizes (#3377) * Added telaria bid adapter * more documentation * Added more test cases. And improved some code in the adapter * Removed the check for optional params, they are handled in the server. Also updated certain param names used in the test spec. * added some spaces to fix CircleCI tests * added some spaces to fix CircleCI tests * fixed code indentation in /spec/AnalyticsAdapter_spec.js which causing the CircleCI tests to fail. * Reverted the changes * merged with prebid master. * creative Id is required when we build a response but our server doesn't always have the crid, so using a sentinel value when we don't have the crid. * - removed an un used method - Removed the package-lock file. * merging to master * updated telaria bid adapter to use player size provided by the bid.mediaTypes.video.playerSize instead of bid.sizes. #3331 * - removed the requirement for having player size - updated the test spec to reflect the above change - removed changes to the package-lock.json file. * added a param to the ad call url to let us know that the request is coming via hb. * to lower casing the bidder code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Be sure to test the integration with your adserver using the Hello World sample page.
For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:
Other information