Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest #4

Merged
merged 41 commits into from
Dec 21, 2018
Merged

Latest #4

merged 41 commits into from
Dec 21, 2018

Commits on Nov 29, 2018

  1. Added 980x150 size (#3334)

    hdeodhar authored and bretg committed Nov 29, 2018
    Configuration menu
    Copy the full SHA
    96fef93 View commit details
    Browse the repository at this point in the history

Commits on Nov 30, 2018

  1. replaced deprecated getWindowTopLocation with refererInfo.referer (#3332

    )
    
    * replaced deprecated getWindowTopLocation with refererInfo.referer
    
    * Removed unused import and unnecessary reassign
    
    * Rename variable bidderRequests to bidderRequest
    
    Renamed the bidderRequests variable to the singular bidderRequest to better portray the value as a single request instead of multiple.
    bansawbanchee authored and jaiminpanchal27 committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    e9bd097 View commit details
    Browse the repository at this point in the history

Commits on Dec 3, 2018

  1. new TapHype bidder adapter (#3319)

    * new TapHype bidder adapter
    
    * Added 930x600 to Rubicon Adapter (#3323)
    
    * PubMatic adapter to support TTD (#3311)
    
    * first commit
    
    * added unit test cases for TTD id
    
    * Sonobi - support video and display same adunit (#3325)
    
    * changed adapter to support video and display for ad unit
    
    * added case for sbi_ct outstream
    
    * outstream is display media type
    
    * Fix user-sync iframes insertion bug (#3300)
    
    According to documentation, iframes should be inserted at bottom
    of head, rather than at top.
    
    * Prevent 33Across adapter from throwing an error when unable to getElementById(), fix JSDocs in utils.js (#3333)
    
    * check gdpr in buildRequest
    
    * User sync based on whether gdpr applies or not
    
    * check if consent data exists during user sync
    
    * split user sync into further branches: 1) when gdpr does not apply 2) when consent data is unavailable
    
    * contribute viewability to ttxRequest
    
    * update tests
    
    * remove window mock from tests
    
    * use local variables
    
    * introduce ServerRequestBuilder
    
    * add withOptions() method to ServerRequestBuilder
    
    * add semicolons
    
    * sync up package-lock.json with upstream/master
    
    * stub window.top in tests
    
    * introduce getTopWindowSize() for test purpose
    
    * reformat code
    
    * add withSite() method to TtxRequestBuilder
    
    add withSite() method to TtxRequestBuilder
    
    * add isIframe() and _isViewabilityMeasurable()
    
    * handle NON_MEASURABLE viewability in nested iframes
    
    * consider page visibility, stub utils functions getWindowTop() and getWindowSelf()
    
    * contribute viewability as 0 for inactive tab
    
    * add prebidjs version to ttx request
    
    * send caller as an array
    
    * fix JSDoc in utils.js
    
    * send viewability as non measurable when unable to locate target HTMLElement, add warning message
    
    * TripleliftBidAdapter-update creative_id (#3324)
    
    * removed dependancy on getTopWindowUrl for referer
    
    * protect against undefined obj and remove test on old dependency
    
    * added unit test for referer and gdpr in query string
    
    * removed gdpr test
    
    * removed gdpr from bidderRequest obj
    
    * decontructed bidder request obj in chai test
    
    * just need to run karma tests again
    
    * added gdpr consent to all bidderRequest obj in chai tests
    
    * changed creativeId to be a Triplelift specific id rather than represent SRA impression
    
    * error-proofed creative id
    
    * Update taphypeBidAdapter.js
    
    removed `supportedMediaTypes` and logging
    
    * Update taphypeBidAdapter.js
    
    remove mediaTypes import
    
    * new TapHype bidder adapter
    
    * Update taphypeBidAdapter.js
    
    removed `supportedMediaTypes` and logging
    
    * Update taphypeBidAdapter.js
    
    remove mediaTypes import
    aeliox authored and jaiminpanchal27 committed Dec 3, 2018
    Configuration menu
    Copy the full SHA
    7aef26e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6f1d23b View commit details
    Browse the repository at this point in the history

Commits on Dec 4, 2018

  1. Configuration menu
    Copy the full SHA
    b215559 View commit details
    Browse the repository at this point in the history
  2. update gulp packages to address vulnerability (#3343)

    * update gulp packages to address vulnerability
    
    * some minor cleanup in the gulpfile tasks
    
    * replace the fork used for gulp-footer
    jsnellbaker authored and jaiminpanchal27 committed Dec 4, 2018
    Configuration menu
    Copy the full SHA
    5e3f144 View commit details
    Browse the repository at this point in the history
  3. initial version of ozone adapter for review (#3307)

    * initial version of ozone adapter for review
    
    * updates made per prebid.org feedback
    
    * Added a new line as failed prebid.org automated test
    
    * Unit Tests for Ozone Adaptor
    
    * updated URIs to include https protocol which failed tests
    afsheenb authored and jaiminpanchal27 committed Dec 4, 2018
    Configuration menu
    Copy the full SHA
    96df52f View commit details
    Browse the repository at this point in the history
  4. update AdGenetation adapter (+1 squashed commit) (#3327)

    Squashed commits:
    [1b55ca0] update AdGenetation adapter
    banakemi authored and jaiminpanchal27 committed Dec 4, 2018
    Configuration menu
    Copy the full SHA
    f7473c7 View commit details
    Browse the repository at this point in the history
  5. adding additional bid request validity checks. updating how we grab …

    …sizes array (#3317)
    
    * Submitting EMX Digital Prebid Adapter
    
    Submitting EMX Digital Prebid Adapter code
    
    * fixing lint errors. updating our md
    
    * updating to const/let variables. adding test spec.
    
    * fixed linting on test spec js
    
    * adding emx usersync methods
    
    * updating valid bid request checks and protocol check.
    
    * remove includes replaced with indexOf
    
    * adding more bid valid checks. updating how we grab sizes array
    
    * linting fix
    
    * code typo fixed
    
    * updated our spec
    EMXDigital authored and jaiminpanchal27 committed Dec 4, 2018
    Configuration menu
    Copy the full SHA
    d933a96 View commit details
    Browse the repository at this point in the history
  6. Update TTL to 30 mins (#3345)

    * Add a new ucfunnel Adapter and test page
    
    * Add a new ucfunnel Adapter and test page
    
    * 1. Use prebid lib in the repo to keep updated
    2. Replace var with let
    3. Put JSON.parse(JSON.stringify()) into try catch block
    
    * utils.getTopWindowLocation is a function
    
    * Change to modules from adapters
    
    * Migrate to module design
    
    * [Dev Fix] Remove width and height which can be got from ad unit id
    
    * Update ucfunnelBidAdapter to fit into new spec
    
    * Correct the endpoint. Fix the error of query string
    
    * Add test case for ucfunnelBidAdapter
    
    * Fix lint error
    
    * Update version number
    
    * Combine all checks on bid request
    
    * Add GDPR support for ucfunnel adapter
    
    * Add in-stream video and native support for ucfunnel adapter
    
    * Remove demo page. Add more test cases.
    
    * Change request method from POST to GET
    
    * Remove unnecessary comment
    
    * Support vastXml and vastUrl for video request
    
    * update TTL to 30 mins
    
    * Avoid using arrow function which is not discuraged in mocha
    ucfunnel authored and jaiminpanchal27 committed Dec 4, 2018
    Configuration menu
    Copy the full SHA
    9e752d8 View commit details
    Browse the repository at this point in the history
  7. Set the OpenRTB device dimensions (#3336)

    * Set the device dimensions if the config didnt do it.
    
    * add unit tests
    
    * Added a regresstion test to catch the bug. The code should still populate w and h even if the config doesnt have that object.
    dbemiller authored and jsnellbaker committed Dec 4, 2018
    Configuration menu
    Copy the full SHA
    9271d36 View commit details
    Browse the repository at this point in the history
  8. removing out console.log statements in ozoneBidAdapter test file (#3349)

    removing out console.log statements in ozoneBidAdapter test file
    jsnellbaker authored Dec 4, 2018
    Configuration menu
    Copy the full SHA
    00c955a View commit details
    Browse the repository at this point in the history
  9. Prebid 1.35.0 Release

    jsnellbaker committed Dec 4, 2018
    Configuration menu
    Copy the full SHA
    e8d9b1a View commit details
    Browse the repository at this point in the history
  10. increment pre version

    jsnellbaker committed Dec 4, 2018
    Configuration menu
    Copy the full SHA
    650aa3a View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2018

  1. Bidfluence Adapter update - Single call (#3347)

    * Bidfluence Adapter update
    
    Support single call to server for all bids
    
    * Bidfluence Adapter update
    
    Support single call to server for all bids - relative to adapter update
    francescocristallo authored and jsnellbaker committed Dec 7, 2018
    Configuration menu
    Copy the full SHA
    f80f2d5 View commit details
    Browse the repository at this point in the history
  2. conditionally adds another param to browserParams (#3355)

    * conditionally adds another param to browserParams
    
    * fixes lint error
    susyt authored and jaiminpanchal27 committed Dec 7, 2018
    Configuration menu
    Copy the full SHA
    3b7f462 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ca69912 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    efc28ad View commit details
    Browse the repository at this point in the history
  5. update unit test example to mocha recommendations (#3361)

    * update unit test example to mocha recommendations
    
    * fix formatting
    jsnellbaker authored and jaiminpanchal27 committed Dec 7, 2018
    Configuration menu
    Copy the full SHA
    8fa2a84 View commit details
    Browse the repository at this point in the history
  6. Supply2 Bid Adapter (#3335)

    * Added Supply2 Bid Adapter with spec file
    
    * Supply2BidAdapter: fix typo
    Vishalrkanse authored and mike-chowla committed Dec 7, 2018
    Configuration menu
    Copy the full SHA
    522a0ce View commit details
    Browse the repository at this point in the history
  7. Dctr fixes (#3337)

    * changes to not show dctr message when none of the adunits have dctr set
    
    * added usage description for dctr and currency params
    pm-manasi-moghe authored and mike-chowla committed Dec 7, 2018
    Configuration menu
    Copy the full SHA
    13182f7 View commit details
    Browse the repository at this point in the history

Commits on Dec 10, 2018

  1. Configuration menu
    Copy the full SHA
    5a2282e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    239f180 View commit details
    Browse the repository at this point in the history
  3. Add user sync pixel logic in Adtelligent adapter (#3359)

    * Add user sync pixel logic in Adtelligent adapter
    
    * Add gdpr support
    
    * Add gdpr support
    
    * Update tests
    GeneGenie authored and jsnellbaker committed Dec 10, 2018
    Configuration menu
    Copy the full SHA
    f424cd2 View commit details
    Browse the repository at this point in the history
  4. AppNexus debug auction via cookie (#3314)

    * updating appnexus debug auction to be cookie-only
    
    * adding getCookie to utils
    
    * remove LGTM alert on getCookie
    
    * fix failed tests
    aneuway2 authored and mkendall07 committed Dec 10, 2018
    Configuration menu
    Copy the full SHA
    88156e7 View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2018

  1. Configuration menu
    Copy the full SHA
    4c1f690 View commit details
    Browse the repository at this point in the history
  2. update conversant bid adapter to use video playerSize instead of size…

    …s to determine the video player size (#3372)
    sohlhausen authored and bretg committed Dec 13, 2018
    Configuration menu
    Copy the full SHA
    ba49c0d View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    5253d29 View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2018

  1. Configuration menu
    Copy the full SHA
    bbc6316 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    32a611d View commit details
    Browse the repository at this point in the history

Commits on Dec 17, 2018

  1. Configuration menu
    Copy the full SHA
    65afce6 View commit details
    Browse the repository at this point in the history

Commits on Dec 18, 2018

  1. New bidder adapter for collectcent (#3365)

    * Create collectcentBidAdapter.js
    
    New bider adapter for collectcent
    
    * Create collectcentBidAdapter.md
    
    Description and integration example
    
    * Create collectcentBidAdapter_spec.js
    
    Collectcent bidder adapter tests added
    
    * Update collectcentBidAdapter_spec.js
    
    edit
    
    * Update collectcentBidAdapter.js
    
    Used bidderRequest.refererInfo.referer instead of window.location
    
    * Update collectcentBidAdapter.js
    
    * Update collectcentBidAdapter.js
    
    Rename URL to URL_MULTI
    devcollectcent authored and mike-chowla committed Dec 18, 2018
    Configuration menu
    Copy the full SHA
    14bf872 View commit details
    Browse the repository at this point in the history
  2. Added 640x360 size (#3388)

    hdeodhar authored and bretg committed Dec 18, 2018
    Configuration menu
    Copy the full SHA
    514fc5f View commit details
    Browse the repository at this point in the history
  3. Added 250x800 size (#3390)

    hdeodhar authored and harpere committed Dec 18, 2018
    Configuration menu
    Copy the full SHA
    05df581 View commit details
    Browse the repository at this point in the history
  4. update AJA adapter: support user sync by iframe (#3382)

    * fix indent
    
    * add handling iframe user sync
    naoto0822 authored and jsnellbaker committed Dec 18, 2018
    Configuration menu
    Copy the full SHA
    9277365 View commit details
    Browse the repository at this point in the history
  5. Prebid 1.36.0 Release

    Mike Chowla committed Dec 18, 2018
    Configuration menu
    Copy the full SHA
    7224e78 View commit details
    Browse the repository at this point in the history
  6. Increment pre version

    Mike Chowla committed Dec 18, 2018
    Configuration menu
    Copy the full SHA
    691dcf6 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    f2e5f17 View commit details
    Browse the repository at this point in the history

Commits on Dec 19, 2018

  1. Rivr thin adapter (#3351)

    * Rivr thin adapter (#5)
    
    * RVR-2049 - change impression event
    
    * RVR-2049 - fix user id value returned on creation of the cookie
    
    * RVR-2049 - remove blockedCategories and browser properties from Auction object
    
    * RVR-2060 - rewrite rendering detection for impression and click events
    
    * RVR-2060 - rewrite tests for rendering detection for impression and click events
    
    * RVR-2049 - send ad unit code in click event
    
    * RVR-2049 - adapt tests for click event
    
    * RVR-2072 - split impression detection depending on the ad server - DFP/none
    
    * RVR-2056 - set creativeId in Auction -> received bids
    
    * RVR-2056 - set bid.clearPrice to cmp
    
    * RVR-2087 - extract trackAuctionInit implementation to rivraddon
    
    * RVR-2087 - extract implementation to rivraddon WIP
    
    * RVR-2087 - extract implementation to rivraddon
    
    * RVR-2087 - extract implementation to rivraddon
    
    * RVR-2087 - Update package-lock
    
    * RVR-2087 - Add addons check
    
    * Rivr Thin Adapter - part 2 (#6)
    
    * RVR-2087 - Remove sendAuction call from ExpiringQueue
    
    * RVR-2147 - Fix test failing on IE 11.0.0
    
    * RVR-2087 - Remove ExpiringQueue
    AlessandroDG authored and jsnellbaker committed Dec 19, 2018
    Configuration menu
    Copy the full SHA
    49ea705 View commit details
    Browse the repository at this point in the history
  2. Fix multi-bid adId in Criteo bid adapter (#3340)

    * Fix multi-bid adId in Criteo bid adapter
    
    A single bid request can generate multiple bids if it has multiple
    sizes. However, by default 'adId' will be filled with the bid request's
    'bidId' field, so if we create two bids from the same bid request, they
    will share the same 'adId'.
    
    Because of this, Prebid will not know which bid to use once DFP makes
    either of those bids win, always taking the first one (see
    'auctionManager.findBidByAdId' used in 'pbjs.renderAd').
    
    * Increment Criteo adapter version
    
    * Add test for Criteo multi-bid fix
    Spark-NF authored and jsnellbaker committed Dec 19, 2018
    Configuration menu
    Copy the full SHA
    e5f4255 View commit details
    Browse the repository at this point in the history

Commits on Dec 20, 2018

  1. Modified the Telaria Bid Adapter to use bid.mediaTypes.video.playerSi…

    …ze instead of bid.sizes (#3377)
    
    * Added telaria bid adapter
    
    * more documentation
    
    * Added more test cases. And improved some code in the adapter
    
    * Removed the check for optional params, they are handled in the server. Also updated certain param names used in  the test spec.
    
    * added some spaces to fix CircleCI tests
    
    * added some spaces to fix CircleCI tests
    
    * fixed code indentation in /spec/AnalyticsAdapter_spec.js which causing the CircleCI tests to fail.
    
    * Reverted the changes
    
    * merged with prebid master.
    
    * creative Id is required when we build a response but our server doesn't always have the crid, so using a sentinel value when we don't have the crid.
    
    * - removed an un used method
    - Removed the package-lock file.
    
    * merging to master
    
    * updated telaria bid adapter to use player size provided by the bid.mediaTypes.video.playerSize instead of bid.sizes.
    
    #3331
    
    * - removed the requirement for having player size
    - updated the test spec to reflect the above change
    - removed changes to the package-lock.json file.
    
    * added a param to the ad call url to let us know that the request is coming via hb.
    
    * to lower casing the bidder code.
    telariaEng authored and bretg committed Dec 20, 2018
    Configuration menu
    Copy the full SHA
    e476021 View commit details
    Browse the repository at this point in the history