Update Conversant adapter to Prebid 1.0 #1711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkendall07
requested changes
Oct 25, 2017
modules/conversantBidAdapter.js
Outdated
|
|
||
| export const spec = { | ||
| code: BIDDER_CODE, | ||
| aliases: ['conversant'], // short code |
There was a problem hiding this comment.
Aliases should be different than BIDDER_CODE. Short code should be 3-4 characters i believe.
modules/conversantBidAdapter.js
Outdated
| } catch (e) { | ||
| script.text = code; | ||
| document.getElementsByTagName('head')[0].appendChild(script); | ||
| if (!bid.params.site_id || !utils.isStr(bid.params.site_id)) { |
modules/conversantBidAdapter.js
Outdated
| }); | ||
| }); | ||
| } | ||
| const conversantImps = utils._map(validBidRequests, function(bid) { |
There was a problem hiding this comment.
nit: you can use Array.map directly now.
modules/conversantBidAdapter.js
Outdated
|
|
||
| const bid = { | ||
| requestId: conversantBid.impid, | ||
| bidderCode: BIDDER_CODE, |
There was a problem hiding this comment.
We made a change after the docs were released - can you please remove the bidderCode property here? Thanks
|
@pycnvr |
|
@mkendall07 That sounds strange. I'll check it out. Thanks. |
|
@mkendall07 Changes uploaded. |
mkendall07
reviewed
Oct 26, 2017
modules/conversantBidAdapter.js
Outdated
| * @param {*} serverResponse A successful response from the server. | ||
| * @return {Bid[]} An array of bids which were nested inside the server. | ||
| */ | ||
| interpretResponse: function(serverResponse, bidRequest) { | ||
| const bidResponses = []; | ||
| const requestMap = {}; | ||
| const currency = serverResponse.cur || 'USD'; | ||
| serverResponse = serverResponse.body; |
Millerrok
pushed a commit
to Vertamedia/Prebid.js
that referenced
this pull request
Oct 31, 2017
* 'master' of https://github.com/prebid/Prebid.js: (22 commits) Update GetIntent adapter to 1.0 version (prebid#1721) Add `usePaymentRule` param to AN bidders (prebid#1778) New hooks API (replaces monkey-patching for currency) (prebid#1683) Change prebidServer to call client user syncs if they exist (prebid#1734) Fix Centro adapter to allow requests of the same units (prebid#1746) add vastUrl + media type for video bids Prebid Server (prebid#1739) Update adxcg adapter for prebid 1.0 (prebid#1741) Update yieldmoBid adapter request url (prebid#1771) Upgrade Quantcast adapter for Prebid 1.0 (prebid#1753) Fidelity Media Adapter update. Prebid v1.0 (prebid#1719) Kargo Adapter for Prebid 1.0 (prebid#1729) updated for prebid 1.0 api (prebid#1722) Add AdOcean adapter (prebid#1735) Update Conversant adapter to Prebid 1.0 (prebid#1711) Fix test-coverage bug (prebid#1765) Migrating TrustX adapter to 1.0 (prebid#1709) Update Improve Digital adapter for Prebid 1.0 (prebid#1728) Fixed the argument type on getUserSyncs. (prebid#1767) nanointeractive bid adapter (prebid#1627) Validating bid response params (prebid#1738) ...
mattpr
pushed a commit
to mattpr/Prebid.js
that referenced
this pull request
Oct 31, 2017
* Conversant adapter initial support for prebid 1.0 * Add video support for conversant adapter * Add tests and md * Update conversant contact address * Return data object in buildRequests without converting it to a string * Conversant adapter initial support for prebid 1.0 * Add video support for conversant adapter * Add tests and md * Update conversant contact address * Return data object in buildRequests without converting it to a string * Better validation for site id * Switch to use utils._each and utils._map * Add tests for displaymanagerver * Review changes for conversant
dluxemburg
pushed a commit
to Genius/Prebid.js
that referenced
this pull request
Jul 17, 2018
* Conversant adapter initial support for prebid 1.0 * Add video support for conversant adapter * Add tests and md * Update conversant contact address * Return data object in buildRequests without converting it to a string * Conversant adapter initial support for prebid 1.0 * Add video support for conversant adapter * Add tests and md * Update conversant contact address * Return data object in buildRequests without converting it to a string * Better validation for site id * Switch to use utils._each and utils._map * Add tests for displaymanagerver * Review changes for conversant
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Update Conversant adapter to Prebid 1.0
Other information