Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AdOcean Adpater for Prebid 1.0 #1735

Merged
merged 8 commits into from
Oct 26, 2017
Merged

AdOcean Adpater for Prebid 1.0 #1735

merged 8 commits into from
Oct 26, 2017

Conversation

jdrobiecki
Copy link
Contributor

Type of change

  • [x ] New bidder adapter

Description of change

new bidder adapter .

  • test parameters for validating bids
{
  bidder: 'adocean',
  params: {
    slaveId: 'adoceanmyaozpniqismex',
    masterId: 'tmYF.DMl7ZBq.Nqt2Bq4FutQTJfTpxCOmtNPZoQUDcL.G7',
    emiter: 'myao.adocean.pl'
  }
}
  • contact email of the adapter’s maintainer: prebid@gemius.com
  • [x ] official adapter submission

@jdrobiecki jdrobiecki closed this Oct 20, 2017
@jdrobiecki jdrobiecki reopened this Oct 20, 2017
matthewlane
matthewlane requested changes Oct 23, 2017
View reviewed changes
Copy link
Collaborator

@matthewlane matthewlane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the new adapter. A few changes requested below

modules/adoceanBidAdapter.js Outdated
return bids;
},

getUserSyncs: function(syncOptions) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If your adapter doesn't need user syncing, this function can be removed

test/spec/modules/adoceanBidAdapter_spec.js Outdated
@@ -0,0 +1,147 @@
import { expect, use } from 'chai';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like use is imported but not used in the test, can be removed

modules/adoceanBidAdapter.js
currency: placementResponse.currency,
height: parseInt(placementResponse.height, 10),
requestId: bidRequest.bidIdMap[placementResponse.id],
width: parseInt(placementResponse.width, 10),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

creativeId, netRevenue, and ttl should also be in this object as well. See the table in http://prebid.org/dev-docs/bidder-adapter-1.html#interpreting-the-response for information about these fields

matthewlane
matthewlane reviewed Oct 24, 2017
View reviewed changes
modules/adoceanBidAdapter.js Outdated

const bid = {
ad: adCode,
bidderCode: BIDDER_CODE,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bidderCode can be dropped as well, it'll be set automatically by bidderFactory. Docs are being updated now, sorry for the confusion prebid/prebid.github.io#411

matthewlane
matthewlane reviewed Oct 24, 2017
View reviewed changes
modules/adoceanBidAdapter.js
return requests;
},

interpretResponse: function(serverResponse, bidRequest) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more change with #1748 now merged to master:

The first argument to interpretResponse has been changed, and now looks like this:

{
  body: responseBody,
  headers: {
    get: function(header) { /* returns a header from the HTTP response */ }
  }
}

So to retain the same functionality as before, doing something like

serverResponse = serverResponse.body;

just below this line (or however you'd prefer) , and in tests as needed, should help

Could you rebase off of master and update that?

@jdrobiecki
Copy link
Contributor Author

Fixed and rebased to master.

@matthewlane matthewlane merged commit edc2274 into prebid:master Oct 26, 2017
Millerrok pushed a commit to Vertamedia/Prebid.js that referenced this pull request Oct 31, 2017
Merge branch 'master' of https://github.com/prebid/Prebid.js
e45235f 
* 'master' of https://github.com/prebid/Prebid.js: (22 commits)
  Update GetIntent adapter to 1.0 version (prebid#1721)
  Add `usePaymentRule` param to AN bidders (prebid#1778)
  New hooks API (replaces monkey-patching for currency) (prebid#1683)
  Change prebidServer to call client user syncs if they exist (prebid#1734)
  Fix Centro adapter to allow requests of the same units (prebid#1746)
  add vastUrl + media type for video bids Prebid Server (prebid#1739)
  Update adxcg adapter for prebid 1.0 (prebid#1741)
  Update yieldmoBid adapter request url (prebid#1771)
  Upgrade Quantcast adapter for Prebid 1.0 (prebid#1753)
  Fidelity Media Adapter update. Prebid v1.0 (prebid#1719)
  Kargo Adapter for Prebid 1.0 (prebid#1729)
  updated for prebid 1.0 api (prebid#1722)
  Add AdOcean adapter (prebid#1735)
  Update Conversant adapter to Prebid 1.0 (prebid#1711)
  Fix test-coverage bug (prebid#1765)
  Migrating TrustX adapter to 1.0 (prebid#1709)
  Update Improve Digital adapter for Prebid 1.0 (prebid#1728)
  Fixed the argument type on getUserSyncs. (prebid#1767)
  nanointeractive bid adapter (prebid#1627)
  Validating bid response params (prebid#1738)
  ...
mattpr pushed a commit to mattpr/Prebid.js that referenced this pull request Oct 31, 2017
@jdrobiecki @mattpr
Add AdOcean adapter (prebid#1735)
67c1862 
* Initial revision of adocean bid adapter (ADOCEAN-13634, ADOCEAN-13635)

* Minor fixes

* new demo placement

* formating after lint

* move request parameters to params

* adocean adpater tests

* minor fixes

* added ttl, netRevenue nad creativeId. merged with upstream
outoftime pushed a commit to Genius/Prebid.js that referenced this pull request Nov 13, 2017
Merge tag '0.32.0' of https://github.com/prebid/Prebid.js into prebuilt
d52f0c7 
* tag '0.32.0' of https://github.com/prebid/Prebid.js: (44 commits)
  Prebid 0.32.0 Release
  Commenting out tests that are failing in IE10 (prebid#1710)
  Update dfp.buildVideoUrl to accept adserver url (prebid#1663)
  Update rubicon adapter with new properties and 1.0 changes (prebid#1776)
  Added adUnitCode for compatibility (prebid#1781)
  Remove 'supported' from analytics adapter info (prebid#1780)
  Add TTL parameter to bid (prebid#1784)
  Update GetIntent adapter to 1.0 version (prebid#1721)
  Add `usePaymentRule` param to AN bidders (prebid#1778)
  New hooks API (replaces monkey-patching for currency) (prebid#1683)
  Change prebidServer to call client user syncs if they exist (prebid#1734)
  Fix Centro adapter to allow requests of the same units (prebid#1746)
  add vastUrl + media type for video bids Prebid Server (prebid#1739)
  Update adxcg adapter for prebid 1.0 (prebid#1741)
  Update yieldmoBid adapter request url (prebid#1771)
  Upgrade Quantcast adapter for Prebid 1.0 (prebid#1753)
  Fidelity Media Adapter update. Prebid v1.0 (prebid#1719)
  Kargo Adapter for Prebid 1.0 (prebid#1729)
  updated for prebid 1.0 api (prebid#1722)
  Add AdOcean adapter (prebid#1735)
  ...
dluxemburg pushed a commit to Genius/Prebid.js that referenced this pull request Jul 17, 2018
@jdrobiecki @dluxemburg
Add AdOcean adapter (prebid#1735)
b9cf68e 
* Initial revision of adocean bid adapter (ADOCEAN-13634, ADOCEAN-13635)

* Minor fixes

* new demo placement

* formating after lint

* move request parameters to params

* adocean adpater tests

* minor fixes

* added ttl, netRevenue nad creativeId. merged with upstream
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewlane matthewlane matthewlane approved these changes

Assignees

@matthewlane matthewlane

Labels
LGTM Prebid 1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jdrobiecki @matthewlane @jaiminpanchal27 @mjacobsonny