Update GetIntent adapter to 1.0 version #1721

kprokopchik · 2017-10-18T13:30:53Z

Type of change

Other

Description of change

GetIntent adapter for Prebid.js 1.0 version

test parameters for validating bids

{
  bidder: 'getintent',
  params: {
    pid: '7',
    tid: 'test01',
    // ...
  }
}

contact email of the adapter’s maintainer
server-dev@getintent.com
official adapter submission

Other information

matthewlane

@dhargo Thanks for the updated adapter, a few changes requested. Also when testing bid responses with the test parameters, I'm receiving a 404 error from your endpoint

http://px.adhigh.net/rtb/direct_banner?pid=12345&tid=9876&known=1&is_video=false&resp_type=JSON&size=300x250& 404 (Not Found)

Please advise so we can validate bid responses, thanks

matthewlane · 2017-10-26T23:26:42Z

modules/getintentBidAdapter.js

+   * @param {BidRequest} bidRequest
+   * @return {Bid[]} An array of bids which were nested inside the server.
+   */
+  interpretResponse: function(serverResponse, bidRequest) {


#1748 changed the first argument of interpretResponse to:

{ body: responseBody, headers: { get: function(header) { /* returns a header from the HTTP response */ } } }

so doing something like

serverResponse = serverResponse.body

(or however you'd prefer) in this function should give you the expected behavior

matthewlane · 2017-10-26T23:27:22Z

modules/getintentBidAdapter.js

+      let size = parseSize(serverResponse.size);
+      let bid = {
+        requestId: bidRequest.bidId,
+        bidderCode: spec.code,


bidderCode can be dropped from the bid response object, it'll be set automatically by bidderFactory. Docs just updated, sorry for the confusion

matthewlane · 2017-10-26T23:29:35Z

modules/getintentBidAdapter.js

+  };
+  if (bidRequest.sizes) {
+    // TODO: add support for multiple sizes
+    giBidRequest.size = bidRequest.sizes[0].join('x');


Adunit sizes may be defined as [300, 250], in which case sizes[0] would be 300 and cause a TypeError. Be sure to check that bidRequest.sizes[0] is an array before calling join

matthewlane · 2017-10-26T23:38:24Z

modules/getintentBidAdapter.js

+      if (bidRequest.creative_id) bid.creativeId = bidRequest.creative_id;
+      if (bidRequest.mediaType === 'video') {
+        bid.vastUrl = serverResponse.vast_url;
+        bid.descriptionUrl = serverResponse.vast_url;


bid.descriptionUrl is no longer required, bid.vastUrl alone will work now

matthewlane · 2017-10-26T23:44:01Z

modules/getintentBidAdapter.js

+    const bids = [];
+    if (serverResponse && serverResponse.no_bid !== 1) {
+      let size = parseSize(serverResponse.size);
+      let bid = {


A few of the required bid response fields are missing: ttl, netRevenue, and currency. See the table in this section http://prebid.org/dev-docs/bidder-adapter-1.html#interpreting-the-response for descriptions and examples of each of these fields

…evenue; fixed creative size selector (prebid#1721)

kprokopchik · 2017-10-27T11:16:22Z

@matthewlane Thanks for the comments. I've commited fixes. Here is new parameters to use for testing bid response

http://px.adhigh.net/rtb/direct_banner?pid=7&tid=test01&known=1&is_video=false&resp_type=JSON&size=300x250&

matthewlane

Great, no longer getting the 404 error with those parameters, but still a few issues with requestId and creativeId

matthewlane · 2017-10-27T18:29:22Z

modules/getintentBidAdapter.js

+        height: size[1],
+        mediaType: bidRequest.mediaType || 'banner'
+      };
+      if (bidRequest.creative_id) bid.creativeId = bidRequest.creative_id;


Is your endpoint able to always return a creativeId? That's a required parameter, and if it doesn't get set this won't pass validation. It might also be on responseBody rather than bidRequest

matthewlane · 2017-10-27T20:40:39Z

modules/getintentBidAdapter.js

+    if (responseBody && responseBody.no_bid !== 1) {
+      let size = parseSize(responseBody.size);
+      let bid = {
+        requestId: bidRequest.bidId,


bidId didn't appear to be on the bidRequest object during tests I ran. I was able to get bid responses from your endpoint, but because the requestId wasn't getting set, it made it appear that the bid from this adapter was empty

matthewlane · 2017-10-27T21:56:39Z

modules/getintentBidAdapter.js

+      return {
+        method: 'GET',
+        url: buildUrl(giBidRequest),
+        data: giBidRequest,


This should set bidId: bidRequest.bidId so that the interpretResponse function has access to it

…bid#1721)

kprokopchik · 2017-10-30T10:45:01Z

@matthewlane Thank you for the comments. Fixed missing fields (requestId, creativeId).

Have to notice: method signature interpretResponse: function(serverResponse, request) and example in documentation http://prebid.org/dev-docs/bidder-adapter-1.html looks like we always have BidRequest (request parameter) when interpreting server bid response; so it is unclear why do we have to pass requestId to server and back.

matthewlane · 2017-10-30T18:56:15Z

Sorry for the confusion about that. The second parameter to interpretResponse is the bid request object which is available for use if needed. This object is whatever was returned the buildRequests function. Bid request and response objects need to have matching ids and one way of doing that is returning the id from buildRequests, but they can also be sent and received from the server as you've done here. In any case I was able to verify bids with your adapter so this is good for merge

* 'master' of https://github.com/prebid/Prebid.js: (22 commits) Update GetIntent adapter to 1.0 version (prebid#1721) Add `usePaymentRule` param to AN bidders (prebid#1778) New hooks API (replaces monkey-patching for currency) (prebid#1683) Change prebidServer to call client user syncs if they exist (prebid#1734) Fix Centro adapter to allow requests of the same units (prebid#1746) add vastUrl + media type for video bids Prebid Server (prebid#1739) Update adxcg adapter for prebid 1.0 (prebid#1741) Update yieldmoBid adapter request url (prebid#1771) Upgrade Quantcast adapter for Prebid 1.0 (prebid#1753) Fidelity Media Adapter update. Prebid v1.0 (prebid#1719) Kargo Adapter for Prebid 1.0 (prebid#1729) updated for prebid 1.0 api (prebid#1722) Add AdOcean adapter (prebid#1735) Update Conversant adapter to Prebid 1.0 (prebid#1711) Fix test-coverage bug (prebid#1765) Migrating TrustX adapter to 1.0 (prebid#1709) Update Improve Digital adapter for Prebid 1.0 (prebid#1728) Fixed the argument type on getUserSyncs. (prebid#1767) nanointeractive bid adapter (prebid#1627) Validating bid response params (prebid#1738) ...

* tag '0.32.0' of https://github.com/prebid/Prebid.js: (44 commits) Prebid 0.32.0 Release Commenting out tests that are failing in IE10 (prebid#1710) Update dfp.buildVideoUrl to accept adserver url (prebid#1663) Update rubicon adapter with new properties and 1.0 changes (prebid#1776) Added adUnitCode for compatibility (prebid#1781) Remove 'supported' from analytics adapter info (prebid#1780) Add TTL parameter to bid (prebid#1784) Update GetIntent adapter to 1.0 version (prebid#1721) Add `usePaymentRule` param to AN bidders (prebid#1778) New hooks API (replaces monkey-patching for currency) (prebid#1683) Change prebidServer to call client user syncs if they exist (prebid#1734) Fix Centro adapter to allow requests of the same units (prebid#1746) add vastUrl + media type for video bids Prebid Server (prebid#1739) Update adxcg adapter for prebid 1.0 (prebid#1741) Update yieldmoBid adapter request url (prebid#1771) Upgrade Quantcast adapter for Prebid 1.0 (prebid#1753) Fidelity Media Adapter update. Prebid v1.0 (prebid#1719) Kargo Adapter for Prebid 1.0 (prebid#1729) updated for prebid 1.0 api (prebid#1722) Add AdOcean adapter (prebid#1735) ...

….32.0 to aolgithub-master * commit '7a956351d69ed3a54ec31aaef17a36441be16fbd': (58 commits) Fixed wrong contentType and customHeader options. Fixed aol adapter bad merge (accepted official changes) Fixed issue with invalid webpack module. Added partners ids. Added changelog entry. Refactored interpretResponse tests for Prebid 1.0. Prebid 0.32.0 Release Commenting out tests that are failing in IE10 (prebid#1710) Update dfp.buildVideoUrl to accept adserver url (prebid#1663) Update rubicon adapter with new properties and 1.0 changes (prebid#1776) Added adUnitCode for compatibility (prebid#1781) Remove 'supported' from analytics adapter info (prebid#1780) Add TTL parameter to bid (prebid#1784) Refactored get userSyncs tests for Prebid 1.0. Fixed faining tests for One Mobile endpoint. Refactored One Mobile tests for Prebid 1.0 Refactored Marketplace tests for Prebid 1.0 Implemented AOL user syncs config via setConfig API. Move one mobile post properties to options object. Update GetIntent adapter to 1.0 version (prebid#1721) ...

AD-2311: Make GetIntent adapter compatible with Prebid.js 1.0 version

3a332fa

mjacobsonny added the Prebid 1.0 label Oct 18, 2017

jaiminpanchal27 assigned ndhimehta Oct 18, 2017

jaiminpanchal27 added the needs review label Oct 18, 2017

kprokopchik added 2 commits October 18, 2017 17:09

AD-2311: remove blank line

6d22ab4

Trigger

d5c27ee

matthewlane assigned matthewlane and unassigned ndhimehta Oct 26, 2017

matthewlane requested changes Oct 26, 2017

View reviewed changes

matthewlane added needs update not receiving bids and removed needs review labels Oct 26, 2017

GetIntent adapter - added bid response fields: currency, ttl and netR…

53c946f

…evenue; fixed creative size selector (prebid#1721)

matthewlane reviewed Oct 27, 2017

View reviewed changes

GetIntent adapter - added bid response fields: bidId, creativeId (pre…

359c16a

…bid#1721)

matthewlane added LGTM and removed needs update not receiving bids labels Oct 30, 2017

matthewlane approved these changes Oct 30, 2017

View reviewed changes

matthewlane merged commit ac6775b into prebid:master Oct 30, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update GetIntent adapter to 1.0 version #1721

Update GetIntent adapter to 1.0 version #1721

kprokopchik commented Oct 18, 2017 •

edited

Loading

matthewlane left a comment

matthewlane Oct 26, 2017

matthewlane Oct 26, 2017

matthewlane Oct 26, 2017

matthewlane Oct 26, 2017

matthewlane Oct 26, 2017

kprokopchik commented Oct 27, 2017

matthewlane left a comment

matthewlane Oct 27, 2017

matthewlane Oct 27, 2017

matthewlane Oct 27, 2017 •

edited

Loading

kprokopchik commented Oct 30, 2017

matthewlane commented Oct 30, 2017

Update GetIntent adapter to 1.0 version #1721

Update GetIntent adapter to 1.0 version #1721

Conversation

kprokopchik commented Oct 18, 2017 • edited Loading

Type of change

Description of change

Other information

matthewlane left a comment

Choose a reason for hiding this comment

matthewlane Oct 26, 2017

Choose a reason for hiding this comment

matthewlane Oct 26, 2017

Choose a reason for hiding this comment

matthewlane Oct 26, 2017

Choose a reason for hiding this comment

matthewlane Oct 26, 2017

Choose a reason for hiding this comment

matthewlane Oct 26, 2017

Choose a reason for hiding this comment

kprokopchik commented Oct 27, 2017

matthewlane left a comment

Choose a reason for hiding this comment

matthewlane Oct 27, 2017

Choose a reason for hiding this comment

matthewlane Oct 27, 2017

Choose a reason for hiding this comment

matthewlane Oct 27, 2017 • edited Loading

Choose a reason for hiding this comment

kprokopchik commented Oct 30, 2017

matthewlane commented Oct 30, 2017

kprokopchik commented Oct 18, 2017 •

edited

Loading

matthewlane Oct 27, 2017 •

edited

Loading