-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blue Billywig Adapter: add advertiserDomains support #6927
Merged
ChrisHuie
merged 17 commits into
prebid:master
from
bluebillywig:fix-adomain-passing-bb-adapter
Jun 3, 2021
Merged
Blue Billywig Adapter: add advertiserDomains support #6927
ChrisHuie
merged 17 commits into
prebid:master
from
bluebillywig:fix-adomain-passing-bb-adapter
Jun 3, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ndererCode rename
* 'master' of github.com:prebid/Prebid.js: (942 commits) PBJS Core: canBidderRegisterSync ignoring iframe sync disabled by default (prebid#6535) Pubxai Analytics Adapter: bug fixes and code revamp (prebid#6474) PBJS Core: call custom render func after loadscript if provided (prebid#6422) Admixer ID System: add userId submodule (prebid#6238) adot bid adapter: add publisher path from bidder config to endpoint url (prebid#6476) Seedtag adapter: Fixing bug preventing to receive the right params onTimeout. (prebid#6525) Adloox Analytics Adapter: add new analytics adapter (prebid#6308) Synacormedia Bid Adapter: add meta.advertiserDomains (prebid#6527) Rubicon: making doc data types consistent (prebid#6526) SynacorMedia: remove adId from the bid response (prebid#6520) AdKernel Bid/Analytics Adapters: user privacy related changes (prebid#6488) Merkle User ID Module: updates to user id submodule (prebid#6503) Update nextroll ID variable name to match published ID module (prebid#6519) Mediasquare Bid Adapter: fix getUserSyncs issue with empty bids + add metrics to onBidWon Event (prebid#6480) Lemma Bid Adapter: accepting the floor to use the getFloor function (prebid#6497) Zemanta adapter: add advertiserDomains (prebid#6517) rubicon: removing maxduration as a required bidder parameter (prebid#6513) increment pre version Prebid 4.33.0 Release Telaria: not setting adid (prebid#6507) ...
* 'master' of github.com:bluebillywig/Prebid.js: Code quality update, always hit user syncs, improved video params Remove the last for .. of in bluebillywigBidAdapter.js, hopefully... Blue Billywig Adapter - update to try and pass CircleCI Blue Billywig Adapter - update according to review feedback add Blue Billywig adapter
* 'master' of github.com:prebid/Prebid.js: (303 commits) BridgewellBidAdapter: modify to include user ids in the bid request object (prebid#6845) GridNMBidAdapter: Use absent in video params data from mediaTypes (prebid#6817) PubMatic: For Video: bid.mediaTypes.video.mimes OR bid.params.video.mimes should be present and must be a non-empty array (prebid#6926) Increment pre version Prebid 4.42.0 Release Seedtag Bid Adapter: read video params from mediaTypes, and allow override from bidder params, support passing adomain (prebid#6888) Medianet bid adapter: MD update for video parameters. (prebid#6922) dgkeyword RTD Provider: add new real time data module (prebid#6912) Smaato bid adapter: Rework multi imp support (prebid#6814) Adot Bid Adapter: add the advertising domains support (prebid#6876) Update Adtelligent, Adtarget, ViewDeos adapters to support adomain (prebid#6917) LockerDome Bid Adapter: support for meta.advertiserDomains (prebid#6921) Sublime Bid Adapter : Add support for meta.advertiserDomains (prebid#6920) Brightcom Bid Adapter: use getFloor function (prebid#6918) AdYouLike Bidder: Handle advertiser domains (prebid#6916) relaido Bid Adapter: Add meta OBJ to BidResponse (prebid#6914) Jixie Bid Adapter: add support for advertiserDomains (prebid#6898) Onomagic Bid Adapter: use getFloor function (prebid#6907) Sharethrough Bid Adapter: Use getFloor module for Prebid 5.0 compliance (prebid#6874) Accept outstream renderers defined in mediatype for PBS (prebid#6896) ...
ChrisHuie
changed the title
Blue Billywig adapter advertiserDomains support (issue #6466)
Blue Billywig Adapter: add advertiserDomains support
Jun 3, 2021
ChrisHuie
approved these changes
Jun 3, 2021
Thanks for the quick review @ChrisHuie ! |
prebidtappx
pushed a commit
to prebidtappx/Prebid.js
that referenced
this pull request
Nov 15, 2021
* add Blue Billywig adapter * Blue Billywig Adapter - update according to review feedback * Blue Billywig Adapter - update to try and pass CircleCI * Remove the last for .. of in bluebillywigBidAdapter.js, hopefully... * Update bluebillywigBidAdapter test parameters to match renderer to rendererCode rename * Blue Billywig - Also pass through site config with OpenRTB request * add Blue Billywig adapter * Blue Billywig Adapter - update according to review feedback * Blue Billywig Adapter - update to try and pass CircleCI * Remove the last for .. of in bluebillywigBidAdapter.js, hopefully... * Code quality update, always hit user syncs, improved video params * Add support for meta.advertiserDomains to BB Adapter, addresses issue prebid#6466 * kick off circleci tests Co-authored-by: Klaas-Jan Boon <klaas-janboon@ip-172-16-224-85.eu-west-1.compute.internal> Co-authored-by: Chris Huie <phoenixtechnerd@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Adds support for adomain/meta object passing to response
Other information
Addresses #6466