Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

These are a bunch of fixes and changes we made here at Blizzard. #2

Closed
wants to merge 12 commits into from
Closed

These are a bunch of fixes and changes we made here at Blizzard. #2

wants to merge 12 commits into from

Conversation

tvandijck
Copy link
Contributor

Same as on BitBucket, with the os.delete, and the parse for known options removed..
the parse for known options I'll put in a separate request to discuss further..

@TurkeyMan
Copy link
Contributor

This is awesome. Thanks heaps guys!
I wonder if we should split these into many PR's for individual consideration?
I can't see a lot in here that's controversial though.

@tvandijck
Copy link
Contributor Author

that editorconfig plugin is the shizzle ;) thank you very much for sharing that little gold gem...

@TurkeyMan
Copy link
Contributor

Yeah, really. Couldn't live without it! Especially at work ;)

@tvandijck
Copy link
Contributor Author

Fixed the tab, and I found a bug in the oven.bubbleFields yesterday which affects usage of tokens in "vpaths", which we enabled.

@tvandijck
Copy link
Contributor Author

Closing this... I split most of these out into individual pull requests.

@tvandijck tvandijck closed this Mar 31, 2015
@tvandijck tvandijck deleted the temp branch May 7, 2015 20:47
starkos pushed a commit that referenced this pull request Sep 16, 2015
@tvandijck
Merge pull request #2 from Bekenn/fix-path-join-tests
40c8127 
Added tests for path.join
martin-traverse pushed a commit to martin-traverse/premake-core that referenced this pull request Apr 19, 2016
@starkos
Merge pull request premake#2 from starkos/finish-renaming-archs
9863d24 
Finish renaming archs
tvandijck pushed a commit to tvandijck/premake-core that referenced this pull request May 11, 2016
@starkos
Merge pull request premake#2 from starkos/finish-renaming-archs
3643b70 
Finish renaming archs
tvandijck pushed a commit to tvandijck/premake-core that referenced this pull request May 11, 2016
@TurkeyMan
Merge pull request premake#2 from starkos/preload-test-func
5ed1d62 
Switch to new test function approach for dynamic loading
tvandijck pushed a commit to tvandijck/premake-core that referenced this pull request May 11, 2016
@starkos
Merge pull request premake#2 from starkos/switch-exceptions-rtti
8edb66f 
Switch NoExceptions and NoRTTI flags to exceptionhandling() and rtti()
samsinsane pushed a commit to LORgames/premake-core that referenced this pull request Apr 5, 2018
@pdoane-blizzard
Add VS2017 support (premake#2)
109f247
starkos referenced this pull request in starkos/premake-core Oct 21, 2019
@starkos
Replace debuggerflavor with debugger (take #2)
da80541
starkos added a commit that referenced this pull request Oct 23, 2019
@starkos
Merge pull request #1357 from starkos/deprecate-debuggerflavor
b96bc35 
Replace debuggerflavor with debugger (take #2)
starkos pushed a commit that referenced this pull request Jan 9, 2020
@ClxS
Initial netcore support (#2)
33e5be8
vadz added a commit to vadz/premake-core that referenced this pull request Aug 27, 2023
@vadz
Fix crash when enabling debugger under Linux
e739d88 
Rename buffer_init() to avoid clashing with a function with the same
name in luasocket code: under Linux, due to the of "flat" ELF
namespaces, when luasocket shared library is loaded into premake process
the existing premake function is used instead of the function defined in
luasocket code, resulting in luasocket buffer not being properly
initialized which, in turn, leads to mysterious crashes as soon as it's
used, e.g. dereferencing null timeout field:

	(gdb) bt
	#0  0x00007ffff7cce642 in timeout_markstart (tm=0x0) at ../../binmodules/luasocket/src/timeout.c:116
	premake#1  0x00007ffff7cc7618 in buffer_meth_receive (L=0x5555557882a8, buf=0x5555559044a0) at ../../binmodules/luasocket/src/buffer.c:113
	premake#2  0x00007ffff7ccd545 in meth_receive (L=0x5555557882a8) at ../../binmodules/luasocket/src/tcp.c:135
	premake#3  0x000055555558c1cc in luaD_precall (L=0x5555557882a8, func=0x5555558e36b0, nresults=1) at ../../contrib/lua/src/ldo.c:434
	premake#4  0x00005555555a971f in luaV_execute (L=0x5555557882a8) at ../../contrib/lua/src/lvm.c:1134
	premake#5  0x000055555558c555 in luaD_call (L=0x5555557882a8, func=0x5555558e3640, nResults=0) at ../../contrib/lua/src/ldo.c:499
	premake#6  0x000055555558c5b3 in luaD_callnoyield (L=0x5555557882a8, func=0x5555558e3640, nResults=0) at ../../contrib/lua/src/ldo.c:509
	premake#7  0x0000555555588af5 in lua_callk (L=0x5555557882a8, nargs=2, nresults=0, ctx=0, k=0x0) at ../../contrib/lua/src/lapi.c:925
	premake#8  0x00005555555af4f2 in hookf (L=0x5555557882a8, ar=0x7fffffffd270) at ../../contrib/lua/src/ldblib.c:316
	premake#9  0x000055555558bafb in luaD_hook (L=0x5555557882a8, event=2, line=273) at ../../contrib/lua/src/ldo.c:269
	premake#10 0x000055555558b284 in luaG_traceexec (L=0x5555557882a8) at ../../contrib/lua/src/ldebug.c:687
	premake#11 0x00005555555a6b71 in luaV_execute (L=0x5555557882a8) at ../../contrib/lua/src/lvm.c:801
	premake#12 0x000055555558c555 in luaD_call (L=0x5555557882a8, func=0x555555889360, nResults=1) at ../../contrib/lua/src/ldo.c:499
	premake#13 0x000055555558c5b3 in luaD_callnoyield (L=0x5555557882a8, func=0x555555889360, nResults=1) at ../../contrib/lua/src/ldo.c:509
	premake#14 0x0000555555588b60 in f_call (L=0x5555557882a8, ud=0x7fffffffdbb0) at ../../contrib/lua/src/lapi.c:943
	premake#15 0x000055555558b5a5 in luaD_rawrunprotected (L=0x5555557882a8, f=0x555555588b2b <f_call>, ud=0x7fffffffdbb0)
	    at ../../contrib/lua/src/ldo.c:142
	premake#16 0x000055555558cd85 in luaD_pcall (L=0x5555557882a8, func=0x555555588b2b <f_call>, u=0x7fffffffdbb0, old_top=64, ef=48)
	    at ../../contrib/lua/src/ldo.c:729
	premake#17 0x0000555555588c28 in lua_pcallk (L=0x5555557882a8, nargs=0, nresults=1, errfunc=3, ctx=0, k=0x0)
	    at ../../contrib/lua/src/lapi.c:969
	premake#18 0x0000555555584734 in premake_pcall (L=0x5555557882a8, nargs=0, nresults=1) at ../../src/host/premake.c:287
	premake#19 0x0000555555584867 in premake_execute (L=0x5555557882a8, argc=5, argv=0x7fffffffdd98,
	    script=0x555555685052 "src/_premake_main.lua") at ../../src/host/premake.c:316
	premake#20 0x000055555558535e in main (argc=5, argv=0x7fffffffdd98) at ../../src/host/premake_main.c:19

For consistency, rename all the other buffer_xxx functions too, even
though they don't conflict with anything right now.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tvandijck @TurkeyMan