Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add python linter (flake8) to workflow and fix all files #25193

Closed
wants to merge 8 commits into from
Closed

Add python linter (flake8) to workflow and fix all files #25193

wants to merge 8 commits into from

Conversation

DamMicSzm
Copy link
Contributor

Problem

Python files need prevent things like syntax errors, typos, bad style, etc... it saves time for reviewing your code. Many python files needed bug fixes.

Changes

Fixed all files where Linter found errors and added Linter to the workflow

Testing

CI will test and maybe some another manual testing

@bzbarsky-apple
Copy link
Contributor

@DamMicSzm This is more likely to get reviewed if you break it up into sane-sized PRs that someone could review in 20-30 minutes each.

@DamMicSzm
Copy link
Contributor Author

Okay, let's break it down into smaller ones

This was referenced Feb 21, 2023
Closed
Merged
Merged
Merged
Merged
Merged
This was referenced Feb 23, 2023
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
andy31415 pushed a commit that referenced this pull request Feb 28, 2023
@DamMicSzm @restyled-commits
[NXP] Add to flake8 in workflow and fix python files (part #25193) (#…
73ada56 
…25305)

* [NXP] Add to flake8 in workflow and fix python files

* Restyled by isort

---------

Co-authored-by: Restyled.io <commits@restyled.io>
andy31415 pushed a commit that referenced this pull request Feb 28, 2023
@DamMicSzm @restyled-commits
[python tests] Add to flake8 in workflow and fix python files (part #…
e0e186c 
…25193) (#25312)

* [python tests] Add to flake8 in workflow and fix python files

* Restyled by autopep8

* Add testing files from controller

---------

Co-authored-by: Restyled.io <commits@restyled.io>
shchen-Lab added a commit to bouffalolab/connectedhomeip-1 that referenced this pull request Mar 1, 2023
@shchen-Lab
Merge branch 'bl702l_matter' of github.com:bouffalolab/connectedhomei…
a738160 
…p-1 into bl702l_matter

* 'bl702l_matter' of github.com:bouffalolab/connectedhomeip-1: (446 commits)
  [Python] Add Python commissioning flow (project-chip#25119)
  Add to flake8 in workflow and fix python files (project-chip#25280)
  Align Time Format Localization cluster XML to spec changes. (project-chip#25289)
  Use the PathsFinder module in scripts/tests/run_test_suite.py instead of having duplicated code (project-chip#25368)
  Add a continuous browse for Matter operational advertisements on Darwin. (project-chip#25317)
  Chef doorlock sample update (project-chip#24118)
  Fix implementation of OnChipScanComplete and OnScanComplete - second PR (project-chip#24873)
  Add to flake8 in workflow and fix python files (project-chip#25279)
  Make PASE setup a bit more robust if multiple clients race. (project-chip#25352)
  Add dependent lib kotlin-stdlib for kotlin version of java-matter-controller (project-chip#25358)
  [python tests] Add to flake8 in workflow and fix python files (part project-chip#25193) (project-chip#25312)
  Add to flake8 in workflow and fix python files (project-chip#25283)
  Add a way to read a concrete attribute path from AttributePathIB::Parser. (project-chip#25293)
  Make sure various tests in TestReadInteraction are not no-ops. (project-chip#25298)
  [Android] Add isUrgent option in Android (project-chip#25301)
  [NXP] Add to flake8 in workflow and fix python files (part project-chip#25193) (project-chip#25305)
  [placeholder] Allow applications can specify which additional sources to build (project-chip#25346)
  Set thread sleep and yield backends for rpc (project-chip#25350)
  [config-data] Remove some enums that just don't generate anything (project-chip#25370)
  [Tizen] CI workflow for running QEMU-based tests (project-chip#24871)
  ...
shchen-Lab added a commit to bouffalolab/connectedhomeip-1 that referenced this pull request Mar 1, 2023
@shchen-Lab
Merge remote-tracking branch 'official/master' into test
7433911 
* official/master: (449 commits)
  tv-casting-app: Updating the context we pass to FindOrEstablishSession
  Changing caching logic to match video players using hostname before other attributes
  Enable -Wconversion tree-wide on darwin. (project-chip#25376)
  [Python] Add Python commissioning flow (project-chip#25119)
  Add to flake8 in workflow and fix python files (project-chip#25280)
  Align Time Format Localization cluster XML to spec changes. (project-chip#25289)
  Use the PathsFinder module in scripts/tests/run_test_suite.py instead of having duplicated code (project-chip#25368)
  Add a continuous browse for Matter operational advertisements on Darwin. (project-chip#25317)
  Chef doorlock sample update (project-chip#24118)
  Fix implementation of OnChipScanComplete and OnScanComplete - second PR (project-chip#24873)
  Add to flake8 in workflow and fix python files (project-chip#25279)
  Make PASE setup a bit more robust if multiple clients race. (project-chip#25352)
  Add dependent lib kotlin-stdlib for kotlin version of java-matter-controller (project-chip#25358)
  [python tests] Add to flake8 in workflow and fix python files (part project-chip#25193) (project-chip#25312)
  Add to flake8 in workflow and fix python files (project-chip#25283)
  Add a way to read a concrete attribute path from AttributePathIB::Parser. (project-chip#25293)
  Make sure various tests in TestReadInteraction are not no-ops. (project-chip#25298)
  [Android] Add isUrgent option in Android (project-chip#25301)
  [NXP] Add to flake8 in workflow and fix python files (part project-chip#25193) (project-chip#25305)
  [placeholder] Allow applications can specify which additional sources to build (project-chip#25346)
  ...
@s07641069 s07641069 mentioned this pull request Mar 15, 2023
Merged
lecndav pushed a commit to lecndav/connectedhomeip that referenced this pull request Mar 22, 2023
@DamMicSzm @restyled-commits
[NXP] Add to flake8 in workflow and fix python files (part project-ch…
a8366bf 
…ip#25193) (project-chip#25305)

* [NXP] Add to flake8 in workflow and fix python files

* Restyled by isort

---------

Co-authored-by: Restyled.io <commits@restyled.io>
lecndav pushed a commit to lecndav/connectedhomeip that referenced this pull request Mar 22, 2023
@DamMicSzm @restyled-commits
[python tests] Add to flake8 in workflow and fix python files (part p…
0026af7 
…roject-chip#25193) (project-chip#25312)

* [python tests] Add to flake8 in workflow and fix python files

* Restyled by autopep8

* Add testing files from controller

---------

Co-authored-by: Restyled.io <commits@restyled.io>
@stale
Copy link

stale bot commented Apr 25, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

andy31415 pushed a commit that referenced this pull request May 2, 2023
@DamMicSzm @restyled-commits @arkq
[ linux cirque ] Add flake8 to workflow and fix python files (part #2…
8f66f42 
…5193) (#25245)

* [linux-cirque] Add flake8 to workflow and fix python files in linux cirque test

* rebase

* Restyled by autopep8

---------

Co-authored-by: Restyled.io <commits@restyled.io>
Co-authored-by: Arkadiusz Bokowy <a.bokowy@samsung.com>
mergify bot pushed a commit that referenced this pull request Jun 23, 2023
@DamMicSzm @restyled-commits
[Matter_yamltests] Add to flake8 in workflow and fix python files (part
1e7dc63 
#25193)  (#25250)

* [matter_yamltests] Add to flake8 in workflow and fix python files

* Restyled by isort

* Adding a comment for noqa use

* Fix after reabse

* Fix flake errors after rebase

---------

Co-authored-by: Restyled.io <commits@restyled.io>
mergify bot pushed a commit that referenced this pull request Jun 24, 2023
@DamMicSzm
[Mbed] Add to flake8 in workflow and fix python files (part #25193) (#…
14aed60 
…25249)

* [Mbed] Add to flake8 in workflow and fix python files

* Fix after review
@stale
Copy link

stale bot commented Jun 25, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale Stale issue or PR label Jun 25, 2023
@bzbarsky-apple bzbarsky-apple removed the stale Stale issue or PR label Jun 26, 2023
This was referenced Jul 11, 2023
Merged
Merged
Merged
mergify bot pushed a commit that referenced this pull request Jul 12, 2023
@DamMicSzm @restyled-commits
[python tools] Add to flake8 in workflow and fix python files (part #…
ab4509c 
…25193) (#27881)

* Flake8 fix error in python tools

* Restyled by isort

---------

Co-authored-by: Restyled.io <commits@restyled.io>
@DamMicSzm DamMicSzm closed this Jul 18, 2023
@DamMicSzm DamMicSzm deleted the add-flake8-and-fix-all-files branch July 18, 2023 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
app controller documentation Improvements or additions to documentation examples github gn lib platform scripts setup payload test driver tests tools workflows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DamMicSzm @bzbarsky-apple