Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set thread bakends for pigweed rpc builds #25350

Merged
merged 1 commit into from
Feb 28, 2023
Merged

Set thread bakends for pigweed rpc builds #25350

merged 1 commit into from
Feb 28, 2023

Conversation

andy31415
Copy link
Contributor

These are needed because of the sleep/yield functionality and are enforced in new pigweed builds.

They are not strictly required in current pigweed version, but will make updating to newer version easier (so just pulling latest pigweed works better).

This should fix things like:

https://github.com/project-chip/connectedhomeip/actions/runs/4280636928/jobs/7452659286

...
INFO    ../../examples/lighting-app/linux/third_party/connectedhomeip/third_party/pigweed/repo/pw_rpc/endpoint.cc:41:15: error: static assertion failed: PW_RPC_YIELD_MODE is PW_RPC_YIELD_MODE_SLEEP (pw::this_thread::sleep_for()), but no backend is set for pw_thread:sleep. Set a pw_thread:sleep backend or use a different PW_RPC_YIELD_MODE setting.
1206
INFO       41 | static_assert(false,
1207
INFO          |               ^~~~~
1208
INFO    ../../examples/lighting-app/linux/third_party/connectedhomeip/third_party/pigweed/repo/pw_rpc/endpoint.cc: In function ‘void pw::rpc::internal::YieldRpcLock()’:
1209
INFO    ../../examples/lighting-app/linux/third_party/connectedhomeip/third_party/pigweed/repo/pw_rpc/endpoint.cc:85:20: error: ‘chrono’ does not name a type
1210
INFO       85 |   static constexpr chrono::SystemClock::duration kSleepDuration =

@pullapprove pullapprove bot removed the examples label Feb 27, 2023
@github-actions
Copy link

PR #25350: Size comparison from af511d7 to 8355b5e

Full report (1 build for cc32xx)
platform target config section af511d7 8355b5e change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 642601 642601 0 0.0
(read/write) 203688 203688 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197088 197088 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930126 930126 0 0.0
.debug_aranges 87280 87280 0 0.0
.debug_frame 299812 299812 0 0.0
.debug_info 20256131 20256131 0 0.0
.debug_line 2656120 2656120 0 0.0
.debug_loc 2797440 2797440 0 0.0
.debug_ranges 281768 281768 0 0.0
.debug_str 3023104 3023104 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105761 105761 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 377825 377825 0 0.0
.symtab 256224 256224 0 0.0
.text 534716 534716 0 0.0

@pullapprove pullapprove bot requested a review from sharadb-amazon February 28, 2023 13:44
@andy31415 andy31415 merged commit 261cd1c into project-chip:master Feb 28, 2023
shchen-Lab added a commit to bouffalolab/connectedhomeip-1 that referenced this pull request Mar 1, 2023
@shchen-Lab
Merge branch 'bl702l_matter' of github.com:bouffalolab/connectedhomei…
a738160 
…p-1 into bl702l_matter

* 'bl702l_matter' of github.com:bouffalolab/connectedhomeip-1: (446 commits)
  [Python] Add Python commissioning flow (project-chip#25119)
  Add to flake8 in workflow and fix python files (project-chip#25280)
  Align Time Format Localization cluster XML to spec changes. (project-chip#25289)
  Use the PathsFinder module in scripts/tests/run_test_suite.py instead of having duplicated code (project-chip#25368)
  Add a continuous browse for Matter operational advertisements on Darwin. (project-chip#25317)
  Chef doorlock sample update (project-chip#24118)
  Fix implementation of OnChipScanComplete and OnScanComplete - second PR (project-chip#24873)
  Add to flake8 in workflow and fix python files (project-chip#25279)
  Make PASE setup a bit more robust if multiple clients race. (project-chip#25352)
  Add dependent lib kotlin-stdlib for kotlin version of java-matter-controller (project-chip#25358)
  [python tests] Add to flake8 in workflow and fix python files (part project-chip#25193) (project-chip#25312)
  Add to flake8 in workflow and fix python files (project-chip#25283)
  Add a way to read a concrete attribute path from AttributePathIB::Parser. (project-chip#25293)
  Make sure various tests in TestReadInteraction are not no-ops. (project-chip#25298)
  [Android] Add isUrgent option in Android (project-chip#25301)
  [NXP] Add to flake8 in workflow and fix python files (part project-chip#25193) (project-chip#25305)
  [placeholder] Allow applications can specify which additional sources to build (project-chip#25346)
  Set thread sleep and yield backends for rpc (project-chip#25350)
  [config-data] Remove some enums that just don't generate anything (project-chip#25370)
  [Tizen] CI workflow for running QEMU-based tests (project-chip#24871)
  ...
lecndav pushed a commit to lecndav/connectedhomeip that referenced this pull request Mar 22, 2023
@andy31415
Set thread sleep and yield backends for rpc (project-chip#25350)
a029dee
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amitnj amitnj Awaiting requested review from amitnj

@anush-apple anush-apple Awaiting requested review from anush-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@CodeChronos928 CodeChronos928 Awaiting requested review from CodeChronos928

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kcoppock kcoppock Awaiting requested review from kcoppock

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@pjzander-signify pjzander-signify Awaiting requested review from pjzander-signify

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

@arkq arkq Awaiting requested review from arkq

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

Assignees
No one assigned
Labels
review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andy31415 @arkq @bzbarsky-apple