Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[placeholder] Allow applications to specify which additional sources… #25346

Merged
merged 1 commit into from
Feb 28, 2023
Merged

[placeholder] Allow applications to specify which additional sources… #25346

merged 1 commit into from
Feb 28, 2023

Conversation

vivien-apple
Copy link
Contributor

… to build

Problem

examples/placeholder/apps/ applications can not specify custom files to be built.

This PR try to do what #25315 is doing with a little narrower scope.

@vivien-apple vivien-apple self-assigned this Feb 27, 2023
@vivien-apple vivien-apple marked this pull request as ready for review February 27, 2023 17:49
krypton36
krypton36 approved these changes Feb 27, 2023
View reviewed changes
Copy link
Contributor

@krypton36 krypton36 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@github-actions
Copy link

PR #25346: Size comparison from 083623e to 868d097

Decreases (1 build for qpg)
platform target config section 083623e 868d097 change % change
qpg lock-app qpg6105+debug (read/write) 1118500 1118492 -8 -0.0
.text 565600 565592 -8 -0.0
Full report (5 builds for cc32xx, linux, qpg)
platform target config section 083623e 868d097 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 642609 642609 0 0.0
(read/write) 203672 203672 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197072 197072 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930077 930077 0 0.0
.debug_aranges 87280 87280 0 0.0
.debug_frame 299816 299816 0 0.0
.debug_info 20256038 20256038 0 0.0
.debug_line 2655900 2655900 0 0.0
.debug_loc 2797195 2797195 0 0.0
.debug_ranges 281768 281768 0 0.0
.debug_str 3023188 3023188 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105761 105761 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 377825 377825 0 0.0
.symtab 256224 256224 0 0.0
.text 534724 534724 0 0.0
linux chip-tool-ipv6only arm64 (read only) 12123828 12123828 0 0.0
(read/write) 732808 732808 0 0.0
.bss 34280 34280 0 0.0
.data 3008 3008 0 0.0
.data.rel.ro 674936 674936 0 0.0
.dynamic 560 560 0 0.0
.got 15376 15376 0 0.0
.init 24 24 0 0.0
.init_array 216 216 0 0.0
.rodata 586964 586964 0 0.0
.text 9798100 9798100 0 0.0
thermostat-no-ble arm64 (read only) 2516956 2516956 0 0.0
(read/write) 145112 145112 0 0.0
.bss 56328 56328 0 0.0
.data 1784 1784 0 0.0
.data.rel.ro 77616 77616 0 0.0
.dynamic 560 560 0 0.0
.got 5336 5336 0 0.0
.init 24 24 0 0.0
.init_array 432 432 0 0.0
.rodata 150584 150584 0 0.0
.text 2104224 2104224 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1151292 1151292 0 0.0
.bss 99804 99804 0 0.0
.data 852 852 0 0.0
.text 598388 598388 0 0.0
lock-app qpg6105+debug (read/write) 1118500 1118492 -8 -0.0
.bss 96292 96292 0 0.0
.data 864 864 0 0.0
.text 565600 565592 -8 -0.0

@vivien-apple vivien-apple changed the title [placeholder] Allow applications can specify which additional sources… [placeholder] Allow applications to specify which additional sources… Feb 28, 2023
@pullapprove pullapprove bot requested a review from sharadb-amazon February 28, 2023 12:07
@andy31415 andy31415 merged commit 0114ad0 into project-chip:master Feb 28, 2023
shchen-Lab added a commit to bouffalolab/connectedhomeip-1 that referenced this pull request Mar 1, 2023
@shchen-Lab
Merge branch 'bl702l_matter' of github.com:bouffalolab/connectedhomei…
a738160 
…p-1 into bl702l_matter

* 'bl702l_matter' of github.com:bouffalolab/connectedhomeip-1: (446 commits)
  [Python] Add Python commissioning flow (project-chip#25119)
  Add to flake8 in workflow and fix python files (project-chip#25280)
  Align Time Format Localization cluster XML to spec changes. (project-chip#25289)
  Use the PathsFinder module in scripts/tests/run_test_suite.py instead of having duplicated code (project-chip#25368)
  Add a continuous browse for Matter operational advertisements on Darwin. (project-chip#25317)
  Chef doorlock sample update (project-chip#24118)
  Fix implementation of OnChipScanComplete and OnScanComplete - second PR (project-chip#24873)
  Add to flake8 in workflow and fix python files (project-chip#25279)
  Make PASE setup a bit more robust if multiple clients race. (project-chip#25352)
  Add dependent lib kotlin-stdlib for kotlin version of java-matter-controller (project-chip#25358)
  [python tests] Add to flake8 in workflow and fix python files (part project-chip#25193) (project-chip#25312)
  Add to flake8 in workflow and fix python files (project-chip#25283)
  Add a way to read a concrete attribute path from AttributePathIB::Parser. (project-chip#25293)
  Make sure various tests in TestReadInteraction are not no-ops. (project-chip#25298)
  [Android] Add isUrgent option in Android (project-chip#25301)
  [NXP] Add to flake8 in workflow and fix python files (part project-chip#25193) (project-chip#25305)
  [placeholder] Allow applications can specify which additional sources to build (project-chip#25346)
  Set thread sleep and yield backends for rpc (project-chip#25350)
  [config-data] Remove some enums that just don't generate anything (project-chip#25370)
  [Tizen] CI workflow for running QEMU-based tests (project-chip#24871)
  ...
shchen-Lab added a commit to bouffalolab/connectedhomeip-1 that referenced this pull request Mar 1, 2023
@shchen-Lab
Merge remote-tracking branch 'official/master' into test
7433911 
* official/master: (449 commits)
  tv-casting-app: Updating the context we pass to FindOrEstablishSession
  Changing caching logic to match video players using hostname before other attributes
  Enable -Wconversion tree-wide on darwin. (project-chip#25376)
  [Python] Add Python commissioning flow (project-chip#25119)
  Add to flake8 in workflow and fix python files (project-chip#25280)
  Align Time Format Localization cluster XML to spec changes. (project-chip#25289)
  Use the PathsFinder module in scripts/tests/run_test_suite.py instead of having duplicated code (project-chip#25368)
  Add a continuous browse for Matter operational advertisements on Darwin. (project-chip#25317)
  Chef doorlock sample update (project-chip#24118)
  Fix implementation of OnChipScanComplete and OnScanComplete - second PR (project-chip#24873)
  Add to flake8 in workflow and fix python files (project-chip#25279)
  Make PASE setup a bit more robust if multiple clients race. (project-chip#25352)
  Add dependent lib kotlin-stdlib for kotlin version of java-matter-controller (project-chip#25358)
  [python tests] Add to flake8 in workflow and fix python files (part project-chip#25193) (project-chip#25312)
  Add to flake8 in workflow and fix python files (project-chip#25283)
  Add a way to read a concrete attribute path from AttributePathIB::Parser. (project-chip#25293)
  Make sure various tests in TestReadInteraction are not no-ops. (project-chip#25298)
  [Android] Add isUrgent option in Android (project-chip#25301)
  [NXP] Add to flake8 in workflow and fix python files (part project-chip#25193) (project-chip#25305)
  [placeholder] Allow applications can specify which additional sources to build (project-chip#25346)
  ...
lecndav pushed a commit to lecndav/connectedhomeip that referenced this pull request Mar 22, 2023
@vivien-apple
[placeholder] Allow applications can specify which additional sources…
088803b 
… to build (project-chip#25346)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@krypton36 krypton36 krypton36 approved these changes

@arkq arkq arkq approved these changes

@andy31415 andy31415 andy31415 approved these changes

@amitnj amitnj Awaiting requested review from amitnj

@anush-apple anush-apple Awaiting requested review from anush-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@CodeChronos928 CodeChronos928 Awaiting requested review from CodeChronos928

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kcoppock kcoppock Awaiting requested review from kcoppock

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@pjzander-signify pjzander-signify Awaiting requested review from pjzander-signify

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

Assignees

@vivien-apple vivien-apple

Labels
examples review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vivien-apple @andy31415 @arkq @krypton36 @bzbarsky-apple