Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align Time Format Localization cluster XML to spec changes. #25289

Merged
merged 3 commits into from
Feb 28, 2023
Merged

Align Time Format Localization cluster XML to spec changes. #25289

merged 3 commits into from
Feb 28, 2023

Conversation

bzbarsky-apple
Copy link
Contributor

REVIEW NOTE: Only the first changeset is manually written.

Spec changes happened in https://github.com/CHIP-Specifications/connectedhomeip-spec/pull/6184.

Fixes #24999

@bzbarsky-apple bzbarsky-apple force-pushed the rename-time-format-localization branch from 6b95026 to e2f3b03 Compare February 23, 2023 21:29
@github-actions
Copy link

PR #25289: Size comparison from 84c77b6 to e2f3b03

Increases (1 build for cc32xx)
platform target config section 84c77b6 e2f3b03 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_str 3018765 3019025 260 0.0
.strtab 377825 377845 20 0.0
Full report (2 builds for cc32xx, mbed)
platform target config section 84c77b6 e2f3b03 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 642681 642681 0 0.0
(read/write) 203672 203672 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197072 197072 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930133 930133 0 0.0
.debug_aranges 87272 87272 0 0.0
.debug_frame 299776 299776 0 0.0
.debug_info 20253400 20253400 0 0.0
.debug_line 2655882 2655882 0 0.0
.debug_loc 2797015 2797015 0 0.0
.debug_ranges 281760 281760 0 0.0
.debug_str 3018765 3019025 260 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105769 105769 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 377825 377845 20 0.0
.symtab 256256 256256 0 0.0
.text 534788 534788 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2467168 2467168 0 0.0
.bss 215788 215788 0 0.0
.data 5880 5880 0 0.0
.text 1429812 1429812 0 0.0

@bzbarsky-apple bzbarsky-apple force-pushed the rename-time-format-localization branch from e2f3b03 to e16a7a8 Compare February 24, 2023 15:14
@github-actions
Copy link

PR #25289: Size comparison from 53142c7 to e16a7a8

Increases (1 build for cc32xx)
platform target config section 53142c7 e16a7a8 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_str 3023369 3023629 260 0.0
.strtab 377825 377845 20 0.0
Full report (3 builds for cc32xx, qpg)
platform target config section 53142c7 e16a7a8 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 642681 642681 0 0.0
(read/write) 203672 203672 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197072 197072 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930077 930077 0 0.0
.debug_aranges 87280 87280 0 0.0
.debug_frame 299816 299816 0 0.0
.debug_info 20256907 20256907 0 0.0
.debug_line 2656086 2656086 0 0.0
.debug_loc 2797535 2797535 0 0.0
.debug_ranges 281768 281768 0 0.0
.debug_str 3023369 3023629 260 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105769 105769 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 377825 377845 20 0.0
.symtab 256256 256256 0 0.0
.text 534788 534788 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1151340 1151340 0 0.0
.bss 99804 99804 0 0.0
.data 852 852 0 0.0
.text 598436 598436 0 0.0
lock-app qpg6105+debug (read/write) 1118540 1118540 0 0.0
.bss 96292 96292 0 0.0
.data 864 864 0 0.0
.text 565640 565640 0 0.0

@pullapprove pullapprove bot requested a review from sharadb-amazon February 28, 2023 16:21
@bzbarsky-apple bzbarsky-apple force-pushed the rename-time-format-localization branch from e16a7a8 to d89fe66 Compare February 28, 2023 18:21
@github-actions
Copy link

PR #25289: Size comparison from 7ce9d78 to d89fe66

Increases (1 build for cc32xx)
platform target config section 7ce9d78 d89fe66 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20262891 20262893 2 0.0
.debug_str 3023623 3023883 260 0.0
.strtab 378494 378514 20 0.0
Full report (1 build for cc32xx)
platform target config section 7ce9d78 d89fe66 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 643465 643465 0 0.0
(read/write) 203688 203688 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197088 197088 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930167 930167 0 0.0
.debug_aranges 87336 87336 0 0.0
.debug_frame 300024 300024 0 0.0
.debug_info 20262891 20262893 2 0.0
.debug_line 2657205 2657205 0 0.0
.debug_loc 2799993 2799993 0 0.0
.debug_ranges 282240 282240 0 0.0
.debug_str 3023623 3023883 260 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105929 105929 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 378494 378514 20 0.0
.symtab 256560 256560 0 0.0
.text 535412 535412 0 0.0

@yufengwangca yufengwangca merged commit 6788cdb into project-chip:master Feb 28, 2023
@bzbarsky-apple bzbarsky-apple deleted the rename-time-format-localization branch February 28, 2023 23:21
shchen-Lab added a commit to bouffalolab/connectedhomeip-1 that referenced this pull request Mar 1, 2023
@shchen-Lab
Merge branch 'bl702l_matter' of github.com:bouffalolab/connectedhomei…
a738160 
…p-1 into bl702l_matter

* 'bl702l_matter' of github.com:bouffalolab/connectedhomeip-1: (446 commits)
  [Python] Add Python commissioning flow (project-chip#25119)
  Add to flake8 in workflow and fix python files (project-chip#25280)
  Align Time Format Localization cluster XML to spec changes. (project-chip#25289)
  Use the PathsFinder module in scripts/tests/run_test_suite.py instead of having duplicated code (project-chip#25368)
  Add a continuous browse for Matter operational advertisements on Darwin. (project-chip#25317)
  Chef doorlock sample update (project-chip#24118)
  Fix implementation of OnChipScanComplete and OnScanComplete - second PR (project-chip#24873)
  Add to flake8 in workflow and fix python files (project-chip#25279)
  Make PASE setup a bit more robust if multiple clients race. (project-chip#25352)
  Add dependent lib kotlin-stdlib for kotlin version of java-matter-controller (project-chip#25358)
  [python tests] Add to flake8 in workflow and fix python files (part project-chip#25193) (project-chip#25312)
  Add to flake8 in workflow and fix python files (project-chip#25283)
  Add a way to read a concrete attribute path from AttributePathIB::Parser. (project-chip#25293)
  Make sure various tests in TestReadInteraction are not no-ops. (project-chip#25298)
  [Android] Add isUrgent option in Android (project-chip#25301)
  [NXP] Add to flake8 in workflow and fix python files (part project-chip#25193) (project-chip#25305)
  [placeholder] Allow applications can specify which additional sources to build (project-chip#25346)
  Set thread sleep and yield backends for rpc (project-chip#25350)
  [config-data] Remove some enums that just don't generate anything (project-chip#25370)
  [Tizen] CI workflow for running QEMU-based tests (project-chip#24871)
  ...
shchen-Lab added a commit to bouffalolab/connectedhomeip-1 that referenced this pull request Mar 1, 2023
@shchen-Lab
Merge remote-tracking branch 'official/master' into test
7433911 
* official/master: (449 commits)
  tv-casting-app: Updating the context we pass to FindOrEstablishSession
  Changing caching logic to match video players using hostname before other attributes
  Enable -Wconversion tree-wide on darwin. (project-chip#25376)
  [Python] Add Python commissioning flow (project-chip#25119)
  Add to flake8 in workflow and fix python files (project-chip#25280)
  Align Time Format Localization cluster XML to spec changes. (project-chip#25289)
  Use the PathsFinder module in scripts/tests/run_test_suite.py instead of having duplicated code (project-chip#25368)
  Add a continuous browse for Matter operational advertisements on Darwin. (project-chip#25317)
  Chef doorlock sample update (project-chip#24118)
  Fix implementation of OnChipScanComplete and OnScanComplete - second PR (project-chip#24873)
  Add to flake8 in workflow and fix python files (project-chip#25279)
  Make PASE setup a bit more robust if multiple clients race. (project-chip#25352)
  Add dependent lib kotlin-stdlib for kotlin version of java-matter-controller (project-chip#25358)
  [python tests] Add to flake8 in workflow and fix python files (part project-chip#25193) (project-chip#25312)
  Add to flake8 in workflow and fix python files (project-chip#25283)
  Add a way to read a concrete attribute path from AttributePathIB::Parser. (project-chip#25293)
  Make sure various tests in TestReadInteraction are not no-ops. (project-chip#25298)
  [Android] Add isUrgent option in Android (project-chip#25301)
  [NXP] Add to flake8 in workflow and fix python files (part project-chip#25193) (project-chip#25305)
  [placeholder] Allow applications can specify which additional sources to build (project-chip#25346)
  ...
tima-q pushed a commit to tima-q/connectedhomeip that referenced this pull request Mar 15, 2023
@dvdm-qorvo @tima-q
Add Qorvo specific ZAP files for light and lock applications
abd0345 
Align Time Format Localization cluster XML to spec changes. (project-chip#25289)
tima-q pushed a commit to tima-q/connectedhomeip that referenced this pull request Mar 16, 2023
@dvdm-qorvo @tima-q
Add Qorvo specific ZAP files for light and lock applications
6fad537 
Align Time Format Localization cluster XML to spec changes. (project-chip#25289)
andy31415 pushed a commit that referenced this pull request Mar 20, 2023
@tima-q @lucicop
@adamb-q @milanr-q @dvdm-qorvo @frng-qorvo @brvc-q @restyled-commits
[QPG] QPG SDK feature updates (#25715)
8425d28 
* SED support for QPG

Run code formatting on main.cpp

Add SED/FTD flags as part of CHIPProjectConfig.h

* Improve DNS SD implementation to trigger OTA requestor init when DNS SD connectivity changes

* * Adding qvIO_Init() to initialisation flow
* Add fix for initial ResetCount storage + removal double init

* Dynamic use of BLE task; re-trigger BLE advertising possible
* Enable heap sourcefile in FreeRTOS

* Added mbedtls software-only build

* Rotating Device ID

* Update project configurations - use versions not in official CD

* Update qpg_sdk to required version

* Removing lwip from examples

* Add Qorvo specific ZAP files for light and lock applications

Align Time Format Localization cluster XML to spec changes. (#25289)

* Configure sleep mode in application

* Enable sleepy for lighting and lock app by default

* * Remove hardcoded length definitions from FactoryDataProvider.cpp
* Remove unused hardware version from OTAImageProcessorImpl.cpp
* Update args.gni example applications

* Remove hardcoded CHIP header definitions in CHIPProjectConfig.h for lighting and lock app

* Changing BLE max fast interval to 50ms to cope with random 0-10ms delay

* Add CHIP_ROOT variable for .zap relative folder use

* Add namespace to persistent-storage app

* Revert ZAP template search based on env var

* Restyled by whitespace

Restyled by clang-format

Restyled by gn

---------

Co-authored-by: Nikita Solianik <nikita.solianik@qorvo.com>
Co-authored-by: lucicop <lucian.copat@qorvo.com>
Co-authored-by: Adam Bodurka <adam.bodurka@qorvo.com>
Co-authored-by: Milan Radovanovic <milan.radovanovic@qorvo.com>
Co-authored-by: Dieter Van der Meulen <dieter.van.der.meulen@qorvo.com>
Co-authored-by: Frank Ngai <frank.ngai@qorvo.com>
Co-authored-by: Brecht Van Cauwenberghe <brecht.van.cauwenberghe@qorvo.com>
Co-authored-by: Restyled.io <commits@restyled.io>
lecndav pushed a commit to lecndav/connectedhomeip that referenced this pull request Mar 22, 2023
@bzbarsky-apple
Align Time Format Localization cluster XML to spec changes. (project-…
9b7ae14 
…chip#25289)

* Align Time Format Localization cluster XML to spec changes.

Spec changes happened in CHIP-Specifications/connectedhomeip-spec#6184.

Fixes project-chip#24999

* Auto-update ZAP files.

* Regenerate generated code.
lecndav pushed a commit to lecndav/connectedhomeip that referenced this pull request Mar 22, 2023
@tima-q @lucicop
@adamb-q @milanr-q @dvdm-qorvo @frng-qorvo @brvc-q @restyled-commits
[QPG] QPG SDK feature updates (project-chip#25715)
33ab960 
* SED support for QPG

Run code formatting on main.cpp

Add SED/FTD flags as part of CHIPProjectConfig.h

* Improve DNS SD implementation to trigger OTA requestor init when DNS SD connectivity changes

* * Adding qvIO_Init() to initialisation flow
* Add fix for initial ResetCount storage + removal double init

* Dynamic use of BLE task; re-trigger BLE advertising possible
* Enable heap sourcefile in FreeRTOS

* Added mbedtls software-only build

* Rotating Device ID

* Update project configurations - use versions not in official CD

* Update qpg_sdk to required version

* Removing lwip from examples

* Add Qorvo specific ZAP files for light and lock applications

Align Time Format Localization cluster XML to spec changes. (project-chip#25289)

* Configure sleep mode in application

* Enable sleepy for lighting and lock app by default

* * Remove hardcoded length definitions from FactoryDataProvider.cpp
* Remove unused hardware version from OTAImageProcessorImpl.cpp
* Update args.gni example applications

* Remove hardcoded CHIP header definitions in CHIPProjectConfig.h for lighting and lock app

* Changing BLE max fast interval to 50ms to cope with random 0-10ms delay

* Add CHIP_ROOT variable for .zap relative folder use

* Add namespace to persistent-storage app

* Revert ZAP template search based on env var

* Restyled by whitespace

Restyled by clang-format

Restyled by gn

---------

Co-authored-by: Nikita Solianik <nikita.solianik@qorvo.com>
Co-authored-by: lucicop <lucian.copat@qorvo.com>
Co-authored-by: Adam Bodurka <adam.bodurka@qorvo.com>
Co-authored-by: Milan Radovanovic <milan.radovanovic@qorvo.com>
Co-authored-by: Dieter Van der Meulen <dieter.van.der.meulen@qorvo.com>
Co-authored-by: Frank Ngai <frank.ngai@qorvo.com>
Co-authored-by: Brecht Van Cauwenberghe <brecht.van.cauwenberghe@qorvo.com>
Co-authored-by: Restyled.io <commits@restyled.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cliffamzn cliffamzn cliffamzn approved these changes

@ReneJosefsen ReneJosefsen ReneJosefsen approved these changes

@andy31415 andy31415 andy31415 approved these changes

@amitnj amitnj Awaiting requested review from amitnj

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@CodeChronos928 CodeChronos928 Awaiting requested review from CodeChronos928

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@pjzander-signify pjzander-signify Awaiting requested review from pjzander-signify

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

Assignees
No one assigned
Labels
app controller darwin esp32 examples platform review - approved scripts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[XML] Update Time Format Localization Cluster XML to match updated spec
5 participants
@bzbarsky-apple @andy31415 @ReneJosefsen @cliffamzn @yufengwangca