LT and GT support for ZADD #1509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Part of the new commands in redis#1434
abrookins
suggested changes
Jul 23, 2021
* getex * flake8 fix * comments
* hrandfield * use mapping in hset * skip if version not fit * remove empty line * flake8 comments * new line for each comment
chayim
added a commit
to chayim/redis-py
that referenced
this pull request
Jul 29, 2021
Co-authored-by: malinaa96 <52569986+malinaa96@users.noreply.github.com> Co-authored-by: Avital Fine <79420960+AvitalFineRedis@users.noreply.github.com>
Andrew-Chen-Wang
added a commit
to aio-libs-abandoned/aioredis-py
that referenced
this pull request
Oct 8, 2021
LT and GT support for ZADD (redis/redis-py#1509) * The flags seem to be boolean, but I'm not sure why the test case has integers for test_zadd_gt_lt. Either way, I've set the annotation to be boolean only. Signed-off-by: Andrew-Chen-Wang <acwangpython@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of supporting redis 6.2 changes in: #1434
Pull Request check-list
Please make sure to review and check all of these items:
$ toxpass with this change (including linting)?NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Description of change
Added support to ZADD for LT and GT arguments.