2 3 5 #2

rlan35 · 2020-09-23T20:24:58Z

Issue

Test

Unit Test Coverage

Before:

<!-- copy/paste 'go test -cover' result in the directory you made change -->

After:

<!-- copy/paste 'go test -cover' result in the directory you made change -->

Test/Run Logs

Operational Checklist

Does this PR introduce backward-incompatible changes to the on-disk data structure and/or the over-the-wire protocol?. (If no, skip to question 8.)

YES|NO
Describe the migration plan.. For each flag epoch, describe what changes take place at the flag epoch, the anticipated interactions between upgraded/non-upgraded nodes, and any special operational considerations for the migration.
Describe how the plan was tested.
How much minimum baking period after the last flag epoch should we allow on Pangaea before promotion onto mainnet?
What are the planned flag epoch numbers and their ETAs on Pangaea?
What are the planned flag epoch numbers and their ETAs on mainnet?

Note that this must be enough to cover baking period on Pangaea.
What should node operators know about this planned change?
Does this PR introduce backward-incompatible changes NOT related to on-disk data structure and/or over-the-wire protocol? (If no, continue to question 11.)

YES|NO
Does the existing node.sh continue to work with this change?
What should node operators know about this change?
Does this PR introduce significant changes to the operational requirements of the node software, such as >20% increase in CPU, memory, and/or disk usage?

TODO

…mony-one#3296) * add support for redelegation * Add test * Revert "[go.mod] version upgrade of libp2p modules" This reverts commit ce53468. * Fix bug that validator self delegation doesn't work * Restore 7 epoch locking time at redelegation epoch * Add debug log for chain context

* [rpc] Add inSync & beaconInSync RPCs to check if node blockchains are in sync * [syncing] Expose IsOutOfSync * [hmy] Add IsOutOfSync to NodeAPI

* [cmd] if running explorer node, set archive to true * [cmd] added a unit test for explorer archive * [cmd] added another test case for archive

* [sync] fix testnet syncing panic issue * [sync] add back close connections in initialization

Signed-off-by: Leo Chen <leo@harmony.one>

* [sync] added batched block sync logic * [sync] changed batch download size from 10 to 30

* .travis.yml Run tests on Ubuntu 18.04 LTS * README.md Remove unnecessary badge token * README.md Change badge branch to `main`

Signed-off-by: Leo Chen <leo@harmony.one>

…y-one#3312) * [rosetta] Add server stop Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu> * [rosetta] Make network naming consistent Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu> * [rosetta] Correct common package name & add error enum Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu> * [rosetta] Remove needless forward of network info to services * Implement /network/list Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu> * [rosetta] Refactor errors & add operation statuses and types Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu> * [rosetta] Implement NetworkOptions & update NetworkAPIService * Rename *_service.go files to remove the suffix * Update StartServers to use new operation types Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu> * [rosetta] Impl NetworkStatus - Finish init impl of /network endpoint * Fix import structure for rosetta.go Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu> * [test] Make explorer run as archival for localnet Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu> * [rosetta] Add unit tests * Force errors to remain the same with unit tests * Force operations to remain the same with unit tests * Ensure network checking works for all cases with unit tests Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu> * [rosetta] Add InvalidNetworkError and correct error codes Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu> * [rosetta] Add UnmarshalFromInterface for SubNetworkMetadata Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu> * [rosetta] Add network checking Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu> * [rosetta] Nit fixes & add unit test for Peer Info * Make names consistent Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu> * [rosetta] Add BlockNotFoundError & TransactionNotFoundError Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu> * [rosetta] Implement skeleton for block transactions Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu> * [rosetta] Add ReceiptNotFoundError Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu> * [rosetta] Add receipt to formatTransaction sig for contract fails Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu> * [rosetta] Add currency, ExpendGasOperation, & ContractCreationOperation * Add Error creator Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu> * [rosetta] Init impl of plain transaction formatting Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu> * [rosetta] Update network.go for new error constructor Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu> * [rosetta] Implement stx formatter & refactor BlockTransaction * Updated todo comments & function formatting Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu> * [rosetta] Impl Block & make currency non-ptr for easy copy with custom metadata Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu> * [rosetta] Fix collect rewards amount on transaction fetch Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu> * [rosetta] Fix block look-up edge case & add recovery middleware Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu> * [rosetta] Add bocks unit tests Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu> * [rosetta] Fix checkPeerID unit test in network_test.go Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu> * [rosetta] Fix staking tx amount for tx ops & update inline docs Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu> * [rosetta] Fix lint Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu> * [rosetta] Refactor getStakingOperations Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu> * [rosetta] Fix undelegate value Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu> * [rosetta] Nit - fix formatting for network.go Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu> * [node] Move genesis allocation to core & remove unused ContractDeployerKey Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu> * [rosetta] Fix precision error & add cx receipt hash on blk fetch * Add unit tests for supporting helper functions Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu> * [rosetta] Fix fmt Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu> * [rosetta] Fix cx receipt hashes for blocks * Print stack trace on panic recovery Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu> * [node] Nit - fix comment for StopRosetta Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu> * [node] Expose GetMaxPeerHeight Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu> * [rosetta] Add SyncStatus enum Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu> * [rosetta] Nit - remove redundant 'service' name in services namespace Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu>

[rpm] publish rpm package to yum repo Signed-off-by: Leo Chen <leo@harmony.one>

Signed-off-by: Leo Chen <leo@harmony.one>

[rpm] add change log [rpm] fix postun in spec file [rpm] make config files [rpm] add more changelog to test upgrade [rpm] add jq as dependency [rpm] right usage of %config Signed-off-by: Leo Chen <leo@harmony.one>

[deb] improve deb scripts [deb] restart harmony after upgrade Signed-off-by: Leo Chen <leo@harmony.one>

Signed-off-by: Leo Chen <leo@harmony.one>

* [rosetta] Account endpoint * Fix lint

* Add one-off fork for testnet adjusted reward * Fix * Fix

…3331) Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu>

…#3332) [rosetta] Update Genesis to reflect localnet genesis changes Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu>

…ock delay (harmony-one#3333)

…just do raw block iteration and bloom matching (harmony-one#3335)

…ny-one#3336)

…des (harmony-one#3337) * Revert "Revert "Add multi-sig merged messaging logic (harmony-one#3300)"" This reverts commit cbd1133. * Allow harmony nodes to sign multisig from multiple accounts

…armony-one#3338) * [rosetta] Update staking operations to account for re-delegation Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu> * [hmy] Add GetUndelegationChange Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu> * [hmy] Add GetAllUndelegatedDelegators Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu> * [hmy] Fix GetAllUndelegatedDelegators & add GetDelegationLockingPeriodInEpoch Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu> * [rosetta] Fix block reward TX ID formatting Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu> * [hmy] Remove unused GetUndelegationChange * Fix GetUndelegationPayouts * Add GetDelegationsByValidatorAtBlock * Keep beaconchain usage at a minimum Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu> * [hmy] Remove debug print & update comments for GetUndelegationPayouts Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu> * [core] Add last garbage collected number to blockchain.go Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu> * [rosetta] Add oldest block ID in net stat for non-archival nodes Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu> * [rosetta] Fix network oldest block case when garb col blk unknown Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu> * [core] Rename lastGarbCollectedBlkNum to maxGarbCollectedBlkNum Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu> * [internal/chain] Refactor token lock period getter & expose * Use refactored token lock period getter Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu> * [hmy] Add UndelegationPayouts type Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu> * [rosetta] Improve NewError detail failure message * Add UndelegationPayoutOperation * Rename PreStakingEraBlockRewardOperation to UndelegationPayoutOperation Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu> * [rosetta] Integrate Correct undelegation payout operations * Refactor special case transaction handeling & add helper functions for determanining when payouts should be calculated * Make getBlockSignerInfo a method of BlockAPI * Rename constants for clarity * Add unit tests for formatting Undelegation payout special transaction Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu> * [hmy] Add caching to GetUndelegationPayouts Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu> * [hmy] Nit - fix comment Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu> * [rosetta] Add block not found error Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu> * [rosetta] Refactor special case txID to be for general Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu> * [rosetta] Fix lint Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu> * [rosetta] Nit - fix comment Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu> * [hmy] Nit - Make GetUndelegationPayouts more readable Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu>

…e#3343) * [rpc] Add RPC to return pool of locked undelegated tokens * [rpc] Fix calculation for available redelegation balance & rename function

…ne#3340) * [consensus] enable the consensus module can spin up doSync * [consensus] remove the blockNumLowChan buffer in onCommitted. Move tryCatchup logic before informing blockNumLow * [sync] Remove an unnecessary time ticker in sync to reduce one sync loop time from 3.5s to 1s (based on testnet) * [consensus] also spin up state sync at onPrepared * [consensus] removed onCommitted block number check since redundent

…gation tokens (harmony-one#3344) * [config] Fix confusing variable name * [pool] Allow pool to accept Delegate transactions that utilize the locked redelegation amount * [pool] Bypass balance check for Delegate transactions, let validation be done with validateStakingTx * [list] Perform validation on staking transactions when filtering for overpriced/invalid transactions * [list] Rename FilterCost to FilterValid, to reflect changes & update comment * [pool] Remove now unnecessary staking logic in demotion logic * [list] Fix imports

Signed-off-by: Leo Chen <leo@harmony.one>

[viewchange] encapsulate view ID in the State struct do NOT ues consensus.current directory to set/get viewID use the following functions consensus.SetCurViewID, consensus.SetViewChangingID consensus.GetCurViewID, consensus.GetViewChangingID Signed-off-by: Leo Chen <leo@harmony.one>

Signed-off-by: Leo Chen <leo@harmony.one>

updated protoc version Signed-off-by: Leo Chen <leo@harmony.one>

Signed-off-by: Leo Chen <leo@harmony.one>

Unify viewID in consensus

…armony-one#3340)" (harmony-one#3350) This reverts commit f9c26e6.

* revert multi-sig messaging code

rlan35 · 2020-09-23T20:55:26Z

consensus/view_change.go

@@ -443,7 +475,7 @@ func (consensus *Consensus) onViewChange(msg *msg_pb.Message) {
 			}
 		}

-		consensus.current.SetViewID(recvMsg.ViewID)
+		consensus.SetCurViewID(recvMsg.ViewID)


@LeoHChen this should be SetViewChangingID()

rlan35 · 2020-09-23T20:56:28Z

consensus/view_change.go

@@ -603,8 +628,7 @@ func (consensus *Consensus) onNewView(msg *msg_pb.Message) {
 	}

 	// newView message verified success, override my state
-	consensus.viewID = recvMsg.ViewID
-	consensus.current.SetViewID(recvMsg.ViewID)
+	consensus.SetCurViewID(recvMsg.ViewID)


Should be SetViewIDs() @LeoHChen

rlan35 · 2020-09-24T03:05:03Z

consensus/consensus_v2.go

 				consensus.SetBlockNum(consensus.ChainReader.CurrentHeader().Number().Uint64() + 1)
-				consensus.SetViewID(consensus.ChainReader.CurrentHeader().ViewID().Uint64() + 1)
+				consensus.SetViewIDs(consensus.ChainReader.CurrentHeader().ViewID().Uint64() + 1)


This is another logic change. the original logic didn't reset the view changing id.

rlan35 and others added 30 commits August 15, 2020 11:52

[rpc] Add sync check RPCs (harmony-one#3301)

c392932

* [rpc] Add inSync & beaconInSync RPCs to check if node blockchains are in sync * [syncing] Expose IsOutOfSync * [hmy] Add IsOutOfSync to NodeAPI

[cmd] if running explorer node, set archive to true (harmony-one#3306)

e68f2cf

* [cmd] if running explorer node, set archive to true * [cmd] added a unit test for explorer archive * [cmd] added another test case for archive

[cmd] set kms default enabled to false

75dff62

[sync] fix testnet syncing panic issue (harmony-one#3308)

bf86767

* [sync] fix testnet syncing panic issue * [sync] add back close connections in initialization

[build] build harmony RPM package

0be1359

Signed-off-by: Leo Chen <leo@harmony.one>

[rpm] add harmony-setup.sh script

170321e

Signed-off-by: Leo Chen <leo@harmony.one>

[rpm] apply sysctl after installation

44ed29f

Signed-off-by: Leo Chen <leo@harmony.one>

[rpm] use one single config file for harmony node

d85c37d

Signed-off-by: Leo Chen <leo@harmony.one>

[rpm] simplify the harmony-setup.sh

a3ffd5b

Signed-off-by: Leo Chen <leo@harmony.one>

[rpm] remove unused cfg files

eb3115b

Signed-off-by: Leo Chen <leo@harmony.one>

[rpm] specify absolute path of harmony in unit file

7218ca1

Signed-off-by: Leo Chen <leo@harmony.one>

[rpm] move common files to package directory

7bf3aca

Signed-off-by: Leo Chen <leo@harmony.one>

[package] add rclone config and script

241fcde

Signed-off-by: Leo Chen <leo@harmony.one>

[deb] add debian package build support

71b168e

Signed-off-by: Leo Chen <leo@harmony.one>

[build] take VERSION from environment variable

3ff2106

Signed-off-by: Leo Chen <leo@harmony.one>

Add logs for redelegated tokens (harmony-one#3310)

273d0c5

[sync] added batched block sync logic (harmony-one#3311)

74da4a9

* [sync] added batched block sync logic * [sync] changed batch download size from 10 to 30

.travis.yml Run tests on Ubuntu 18.04 LTS (harmony-one#3309)

c3e6113

* .travis.yml Run tests on Ubuntu 18.04 LTS * README.md Remove unnecessary badge token * README.md Change badge branch to `main`

[build] Mac OS build using upgraded openssl library

40771ea

Signed-off-by: Leo Chen <leo@harmony.one>

[rpm] support rpm signing

57343d8

[rpm] publish rpm package to yum repo Signed-off-by: Leo Chen <leo@harmony.one>

[deb] publish deb package

b32c489

Signed-off-by: Leo Chen <leo@harmony.one>

[rpm/deb] query version/release from git tag

0e1e6f3

Signed-off-by: Leo Chen <leo@harmony.one>

[harmony-setup] set IsArchival mode for validator/explorer

0c71a85

Signed-off-by: Leo Chen <leo@harmony.one>

[rclone] improve harmony-rclone.sh

9f378c3

Signed-off-by: Leo Chen <leo@harmony.one>

[rpm] improve rpm scripts

ca635bf

[rpm] add change log [rpm] fix postun in spec file [rpm] make config files [rpm] add more changelog to test upgrade [rpm] add jq as dependency [rpm] right usage of %config Signed-off-by: Leo Chen <leo@harmony.one>

[deb] can not remove local repo

419967d

[deb] improve deb scripts [deb] restart harmony after upgrade Signed-off-by: Leo Chen <leo@harmony.one>

[deb] add recommended dependencies

03f6d23

Signed-off-by: Leo Chen <leo@harmony.one>

[Makefile] fixed the release ver

2b64ac2

Signed-off-by: Leo Chen <leo@harmony.one>

JackyWYX and others added 27 commits September 2, 2020 13:32

[sync] add timeout for grpc dial

ccc5812

[rosetta] Implement account endpoint (harmony-one#3325)

6b1acd4

* [rosetta] Account endpoint * Fix lint

Add one-off fork for testnet adjusted reward (harmony-one#3302)

23fc448

* Add one-off fork for testnet adjusted reward * Fix * Fix

[core] Refresh acc timeout beat each time a tx is added (harmony-one#…

3aaccf8

…3331) Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu>

[core] Add localnet only testing account in genesis conf (harmony-one…

3de5809

…#3332) [rosetta] Update Genesis to reflect localnet genesis changes Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu>

Increase crosslink catching rate, expect to have equillibrium at 5 bl…

f284e9e

…ock delay (harmony-one#3333)

[logs] disable log log filtering based on the bloom bits indexed and …

81691b6

…just do raw block iteration and bloom matching (harmony-one#3335)

[rpc] fix transaction receipt fetch bug (harmony-one#3327)

a0f2af1

Enable redelegation and 7 epoch locking on testnet epoch 36500 (harmo…

ccc1c44

…ny-one#3336)

Add back multi-sig support and fix the multi-sig check for harmony no…

f42338c

…des (harmony-one#3337) * Revert "Revert "Add multi-sig merged messaging logic (harmony-one#3300)"" This reverts commit cbd1133. * Allow harmony nodes to sign multisig from multiple accounts

[rpc] Add RPC to return pool of locked undelegated tokens (harmony-on…

eaf51b8

…e#3343) * [rpc] Add RPC to return pool of locked undelegated tokens * [rpc] Fix calculation for available redelegation balance & rename function

[debug] add debug rpc calls

c2e962a

Signed-off-by: Leo Chen <leo@harmony.one>

[validation] move newview validation to p2p layer

5491271

Signed-off-by: Leo Chen <leo@harmony.one>

[consensus] rename SetViewID to SetViewIDs

0c04a2b

Signed-off-by: Leo Chen <leo@harmony.one>

fix golint

7dcdbe7

Signed-off-by: Leo Chen <leo@harmony.one>

fix test cases

79d43c2

updated protoc version Signed-off-by: Leo Chen <leo@harmony.one>

[misc] move SenderPubkeys check to sanity check func

5e556b8

Signed-off-by: Leo Chen <leo@harmony.one>

[viewchange] simplify vc message initialization

e079fb1

Signed-off-by: Leo Chen <leo@harmony.one>

Merge pull request harmony-one#3347 from LeoHChen/unify_viewID

421eeed

Unify viewID in consensus

Revert "[consensus] enable the consensus module can spin up doSync (h…

3adab44

…armony-one#3340)" (harmony-one#3350) This reverts commit f9c26e6.

enable mainnet redelegation+7epoch locking at epoch 289

6741f07

revert multi-sig messaging code (harmony-one#3361)

79cf6af

* revert multi-sig messaging code

Postpone redelegation to epoch 290 (harmony-one#3362)

28c93b5

rlan35 commented Sep 23, 2020

View reviewed changes

rlan35 commented Sep 24, 2020

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

2 3 5 #2

2 3 5 #2

rlan35 commented Sep 23, 2020

rlan35 Sep 23, 2020

rlan35 Sep 23, 2020

rlan35 Sep 24, 2020 •

edited

Loading

rlan35 Sep 24, 2020

2 3 5 #2

Are you sure you want to change the base?

2 3 5 #2

Conversation

rlan35 commented Sep 23, 2020

Issue

Test

Unit Test Coverage

Test/Run Logs

Operational Checklist

TODO

rlan35 Sep 23, 2020

Choose a reason for hiding this comment

rlan35 Sep 23, 2020

Choose a reason for hiding this comment

rlan35 Sep 24, 2020 • edited Loading

Choose a reason for hiding this comment

rlan35 Sep 24, 2020

Choose a reason for hiding this comment

rlan35 Sep 24, 2020 •

edited

Loading