Manufacturer extensions cluster sample #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
examples
scripts
github
workflows
controller
app
darwin
labels
rochaferraz
force-pushed
the
chef_custom_clusters_to_github_smashed
branch
2 times, most recently
from
1b34189 to
933c2b1
Compare
rochaferraz
changed the title
rochaferraz
force-pushed
the
chef_custom_clusters_to_github_smashed
branch
from
6a04396 to
cba142b
Compare
rochaferraz
force-pushed
the
chef_custom_clusters_to_github_smashed
branch
2 times, most recently
from
7974dde to
3fe1e36
Compare
rochaferraz
force-pushed
the
chef_custom_clusters_to_github_smashed
branch
from
3fe1e36 to
c8598d2
Compare
rochaferraz
force-pushed
the
chef_custom_clusters_to_github_smashed
branch
from
6120fdd to
58cfefe
Compare
cecille
reviewed
Sep 7, 2023
| <code>0xFFF1FC20</code> | ||
| <define>SAMPLE_MEI_CLUSTER</define> | ||
| <description>The Sample MEI cluster showcases a cluster manufacturer extensions</description> | ||
| <client tick="false" init="false">true</client> |
There was a problem hiding this comment.
I've seen this in other XML files, such as level-control-cluster.xml. My understanding is that this would be controlling whether ember calls the cluster init and periodic ticks, which I don't care and don't want to.
But I'm not positive this is wired up in ember as it exists in Matter. It could be some legacy dead code from zigbee. I'll try removing and seeing if it breaks
| @@ -20910,7 +20910,7 @@ | |||
| "side": "server", | |||
| "type": "single", | |||
| "included": 0, | |||
| "storageOption": "RAM", | |||
| "storageOption": "External", | |||
There was a problem hiding this comment.
Are all these just coming from zap? I don't think they're correct. If these changes are just zap side effects, would you mind poking the zap channel to see what's up with that? As far as i can see, the AQ sensor only handles the AirQuality attribute as external, and the rest aren't handled.
There was a problem hiding this comment.
Yes, this is some zap side effect. I didn't touch AQ
There was a problem hiding this comment.
This attribute is forced to external in zcl.json, but when people did that they did not update this .zap file (e.g. by running zap-convert). Note that the .matter file did not change here, because codegen was already treating this as external.
rochaferraz
commented
Sep 8, 2023
| @@ -33,7 +33,7 @@ | |||
| ], | |||
| "endpointTypes": [ | |||
| { | |||
| "id": 1, | |||
| "id": 4, | |||
There was a problem hiding this comment.
"id" change was also some side effect
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
|
Merged upstream |
rochaferraz
pushed a commit
that referenced
this pull request
Nov 14, 2023
* Fix constexpr complaints on test vectors * Attempt #2 - separate PAAs used in non-test * Things work better when we add all the files * Restyled by whitespace * Restyled by clang-format * add tokenizer * add the gni * add pigweed import * Change filenames * Restyled by clang-format --------- Co-authored-by: Restyled.io <commits@restyled.io>
rochaferraz
pushed a commit
that referenced
this pull request
Nov 14, 2023
…ist". (project-chip#29666) The typical failure there looks like this: ==29620==ERROR: LeakSanitizer: detected memory leaks Direct leak of 88 byte(s) in 1 object(s) allocated from: #0 0x106396e12 in calloc+0xa2 (libclang_rt.asan_osx_dynamic.dylib:x86_64+0x51e12) #1 0x7ff800dc9789 in map_images_nolock+0x24b (libobjc.A.dylib:x86_64h+0x1789) #2 0x7ff800dc94db in map_images+0x42 (libobjc.A.dylib:x86_64h+0x14db) project-chip#3 0x113d721fa in invocation function for block in dyld4::RuntimeState::setObjCNotifiers(void (*)(unsigned int, char const* const*, mach_header const* const*), void (*)(char const*, mach_header const*), void (*)(char const*, mach_header const*))+0x112 (dyld:x86_64+0xf1fa) project-chip#4 0x113d6d6c8 in dyld4::RuntimeState::withLoadersReadLock(void () block_pointer)+0x28 (dyld:x86_64+0xa6c8) project-chip#5 0x113d720e1 in dyld4::RuntimeState::setObjCNotifiers(void (*)(unsigned int, char const* const*, mach_header const* const*), void (*)(char const*, mach_header const*), void (*)(char const*, mach_header const*))+0x51 (dyld:x86_64+0xf0e1) project-chip#6 0x113d85d44 in dyld4::APIs::_dyld_objc_notify_register(void (*)(unsigned int, char const* const*, mach_header const* const*), void (*)(char const*, mach_header const*), void (*)(char const*, mach_header const*))+0x4e (dyld:x86_64+0x22d44) project-chip#7 0x7ff800dc9343 in _objc_init+0x4fe (libobjc.A.dylib:x86_64h+0x1343) project-chip#8 0x7ff800d83992 in _os_object_init+0xc (libdispatch.dylib:x86_64+0x2992) project-chip#9 0x7ff800d911b7 in libdispatch_init+0x136 (libdispatch.dylib:x86_64+0x101b7) project-chip#10 0x7ff80bd34894 in libSystem_initializer+0xed (libSystem.B.dylib:x86_64+0x1894) project-chip#11 0x113d77e4e in invocation function for block in dyld4::Loader::findAndRunAllInitializers(dyld4::RuntimeState&) const+0xb5 (dyld:x86_64+0x14e4e) project-chip#12 0x113d9eaac in invocation function for block in dyld3::MachOAnalyzer::forEachInitializer(Diagnostics&, dyld3::MachOAnalyzer::VMAddrConverter const&, void (unsigned int) block_pointer, void const*) const+0xf1 (dyld:x86_64+0x3baac) project-chip#13 0x113d95e25 in invocation function for block in dyld3::MachOFile::forEachSection(void (dyld3::MachOFile::SectionInfo const&, bool, bool&) block_pointer) const+0x22c (dyld:x86_64+0x32e25) project-chip#14 0x113d64db2 in dyld3::MachOFile::forEachLoadCommand(Diagnostics&, void (load_command const*, bool&) block_pointer) const+0x80 (dyld:x86_64+0x1db2) project-chip#15 0x113d95bb6 in dyld3::MachOFile::forEachSection(void (dyld3::MachOFile::SectionInfo const&, bool, bool&) block_pointer) const+0xb2 (dyld:x86_64+0x32bb6) project-chip#16 0x113d9e603 in dyld3::MachOAnalyzer::forEachInitializer(Diagnostics&, dyld3::MachOAnalyzer::VMAddrConverter const&, void (unsigned int) block_pointer, void const*) const+0x1d1 (dyld:x86_64+0x3b603) project-chip#17 0x113d77d81 in dyld4::Loader::findAndRunAllInitializers(dyld4::RuntimeState&) const+0x8f (dyld:x86_64+0x14d81) project-chip#18 0x113d7e659 in dyld4::PrebuiltLoader::runInitializers(dyld4::RuntimeState&) const+0x1d (dyld:x86_64+0x1b659) project-chip#19 0x113d8b76d in dyld4::APIs::runAllInitializersForMain()+0x25 (dyld:x86_64+0x2876d) project-chip#20 0x113d6938c in dyld4::prepare(dyld4::APIs&, dyld3::MachOAnalyzer const*)+0xd72 (dyld:x86_64+0x638c) project-chip#21 0x113d684e3 in start+0x183 (dyld:x86_64+0x54e3)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.