-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added controller states feedback for multi dof joints #64
Conversation
@gstavrinos can you explain a bit motivation and goals of this PR? |
Of course: I am building a controller for a quadcopter and using the If I wasn't clear enough, please inform me! |
The PR makes sense but the write-up is off a bit. The action feedback actually has those fields,this is a message definition that gets published on the topic interface. It's out of alignment with the action so the fix is completely reasonable. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gstavrinos thanks for giving us insight how you are using this.
Would be happy to see also PR on ros2_controller if you decide to open-source your work :) We currently don't have much support for drones, but it is for sure very fascinating 🛩 (cannot find any drone emoji)
It will definitely be open source when it's stable enough. I would be more than happy to contribute to ros2_controllers, given that it meets the required standards! :) (thank you both the for accepted PR) |
due to change breaking for existing Galactic distro
@gstavrinos what about publishing controller :D? |
Hey Denis, thanks for the interest. The project is currently on hold for about 2 months due to other priorities, but I will eventually get back to it and make it open source as soon as I have a working implementation! :) |
due to change breaking for existing Galactic distro
due to change breaking for existing Galactic distro
due to change breaking for existing Galactic distro
No description provided.