Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added controller states feedback for multi dof joints #64

Merged
merged 1 commit into from
Nov 9, 2021

Conversation

gstavrinos
Copy link
Contributor

No description provided.

@destogl
Copy link
Member

destogl commented Nov 8, 2021

@gstavrinos can you explain a bit motivation and goals of this PR?

@gstavrinos
Copy link
Contributor Author

Of course:

I am building a controller for a quadcopter and using the FollowJointTrajectory action to command it through MoveIt. Inside the FollowJointTrajectory action I am using the multi_dof_trajectory field for the command, but when I have to report the feedback (state) of my controller, the "expected" multi_dof_trajectory is not there.

If I wasn't clear enough, please inform me!

@bmagyar
Copy link
Member

bmagyar commented Nov 8, 2021

The PR makes sense but the write-up is off a bit. The action feedback actually has those fields,this is a message definition that gets published on the topic interface. It's out of alignment with the action so the fix is completely reasonable. Thanks!

@bmagyar bmagyar requested a review from destogl November 9, 2021 10:36
Copy link
Member

@destogl destogl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gstavrinos thanks for giving us insight how you are using this.

Would be happy to see also PR on ros2_controller if you decide to open-source your work :) We currently don't have much support for drones, but it is for sure very fascinating 🛩 (cannot find any drone emoji)

@destogl destogl merged commit a555c37 into ros-controls:galactic-devel Nov 9, 2021
@gstavrinos
Copy link
Contributor Author

It will definitely be open source when it's stable enough. I would be more than happy to contribute to ros2_controllers, given that it meets the required standards! :)

(thank you both the for accepted PR)

bmagyar added a commit that referenced this pull request Aug 1, 2022
due to change breaking for existing Galactic distro
@destogl
Copy link
Member

destogl commented Sep 10, 2022

@gstavrinos what about publishing controller :D?

@gstavrinos
Copy link
Contributor Author

Hey Denis, thanks for the interest. The project is currently on hold for about 2 months due to other priorities, but I will eventually get back to it and make it open source as soon as I have a working implementation! :)

destogl pushed a commit that referenced this pull request Nov 30, 2022
due to change breaking for existing Galactic distro
destogl pushed a commit that referenced this pull request Apr 3, 2023
due to change breaking for existing Galactic distro
destogl pushed a commit that referenced this pull request Apr 4, 2023
due to change breaking for existing Galactic distro
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants