Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JTC] Backport recent changes #801

Merged
merged 22 commits into from
Dec 6, 2023
Merged

[JTC] Backport recent changes #801

merged 22 commits into from
Dec 6, 2023

Commits on Dec 5, 2023

  1. [Doc] Fix links (backport ros-controls#715)

    @christophfroehlich
    christophfroehlich committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    a6b8a1c View commit details
    Browse the repository at this point in the history

  2. [JTC] Explicitly set hold position (backport ros-controls#558)

    @christophfroehlich
    christophfroehlich committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    4abddd5 View commit details
    Browse the repository at this point in the history

  3. [JTC] Tolerance tests + Hold on time violation (backport ros-controls… 

    …#613)

* Add new test to ensure that controller goes into position holding when tolerances are violated
* Hold position if goal_time is exceeded with topic interface
* Fix hold on time-violation
    @christophfroehlich
    christophfroehlich committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    63ea018 View commit details
    Browse the repository at this point in the history

  4. [JTC] Make most parameters read-only (backport ros-controls#771)

    @christophfroehlich
    christophfroehlich committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    6c3b73e View commit details
    Browse the repository at this point in the history

  5. [JTC] Add note on goal_time=0 in docs (backport ros-controls#773)

    @christophfroehlich
    christophfroehlich committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    14438cd View commit details
    Browse the repository at this point in the history

  6. [JTC] Fix hold position mode with goal_time>0 (backport ros-controls#758 

    )
    @christophfroehlich
    christophfroehlich committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    84684e5 View commit details
    Browse the repository at this point in the history

  7. [JTC] Add time-out for trajectory interfaces (backport ros-controls#609)

    @christophfroehlich
    christophfroehlich committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    4b9e25b View commit details
    Browse the repository at this point in the history

  8. [Docs] Improve interface description of JTC (backport ros-controls#770)

    @christophfroehlich
    christophfroehlich committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    32cf43a View commit details
    Browse the repository at this point in the history

  9. [JTC] Add tests for acceleration command interface (backport ros-cont… 

    …rols#752)
    @christophfroehlich
    christophfroehlich committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    c4d5916 View commit details
    Browse the repository at this point in the history

  10. Cleanup comments and unnecessary checks (backport ros-controls#803)

    @christophfroehlich
    christophfroehlich committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    99092c3 View commit details
    Browse the repository at this point in the history

  11. [JTC] Fix typos, implicit cast, const member functions (backport ros-… 

    …controls#748)
    @christophfroehlich
    christophfroehlich committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    f516ab4 View commit details
    Browse the repository at this point in the history

  12. Update requirements of state interfaces (backport ros-controls#798)

    @christophfroehlich
    christophfroehlich committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    1932f6e View commit details
    Browse the repository at this point in the history

  13. Rename wraparound class variables (backport ros-controls#834)

    @christophfroehlich
    christophfroehlich committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    ae13bf6 View commit details
    Browse the repository at this point in the history

  14. [JTC] Fix tests when state offset is used (backport ros-controls#797) 

    * Simplify initialization of states
* Rename read_state_from_hardware method
* Don't set state_desired in on_activate
---------

Co-authored-by: Dr. Denis <denis@stoglrobotics.de>
    @christophfroehlich @destogl
    christophfroehlich and destogl committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    aab61c7 View commit details
    Browse the repository at this point in the history

  15. [JTC] Activate update of dynamic parameters (backport ros-controls#761)

    @christophfroehlich
    christophfroehlich committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    dc837fe View commit details
    Browse the repository at this point in the history

  16. [JTC] Remove unused home pose (backport ros-controls#845)

    @christophfroehlich
    christophfroehlich committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    25ae717 View commit details
    Browse the repository at this point in the history

  17. [JTC] Fix dynamic reconfigure of tolerances (backport ros-controls#849) 

    * Fix dynamic reconfigure of tolerances

* Fix static cast syntax
    @christophfroehlich
    christophfroehlich committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    d7ce093 View commit details
    Browse the repository at this point in the history

  18. [JTC] Improve update methods for tests (backport ros-controls#858)

    @christophfroehlich
    christophfroehlich committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    16bd330 View commit details
    Browse the repository at this point in the history

  19. [JTC] Activate checks for parameter validation backport (ros-controls… 

    …#857)
    @christophfroehlich
    christophfroehlich committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    ca67f12 View commit details
    Browse the repository at this point in the history

  20. [JTC] Remove start_with_holding option (backport ros-controls#839)

    @christophfroehlich
    christophfroehlich committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    b0f2e4c View commit details
    Browse the repository at this point in the history

  21. [JTC] Continue with last trajectory-point on success (backport ros-co… 

    …ntrols#842)
    @christophfroehlich
    christophfroehlich committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    ee5a9c9 View commit details
    Browse the repository at this point in the history

  22. Fix floating point comparison in JTC (backport ros-controls#879) 

    * Fix floating point comparison in JTC

* Fix format

---------

Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>
    @christophfroehlich
    christophfroehlich and christophfroehlich committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    41304df View commit details
    Browse the repository at this point in the history