Fix: cypress failure #319
Merged
Fix: cypress failure #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pensearch-project#5815) * add log explorer re-directon modal Signed-off-by: Eric <menwe@amazon.com> * adjustments to comments Signed-off-by: Eric <menwe@amazon.com> * add one missing i18n Signed-off-by: Eric <menwe@amazon.com> * add redirection text to group title Signed-off-by: Eric <menwe@amazon.com> * include changes in changelog Signed-off-by: Eric <menwe@amazon.com> * remove redundent title addition and unnecessary modal toggle functions Signed-off-by: Eric <menwe@amazon.com> * remove one comment Signed-off-by: Eric <menwe@amazon.com> * add i18n Signed-off-by: Eric <menwe@amazon.com> * add unit tests for modal Signed-off-by: Eric <menwe@amazon.com> * test id change Signed-off-by: Eric <menwe@amazon.com> * add devDependencies for tests Signed-off-by: Eric <menwe@amazon.com> * use open confirm api and move mock file to discover mock folder Signed-off-by: Eric <menwe@amazon.com> * remove unused type Signed-off-by: Eric <menwe@amazon.com> * remove modal for log explorer redirection Signed-off-by: Eric <menwe@amazon.com> * modify changelog Signed-off-by: Eric <menwe@amazon.com> * remove modal test Signed-off-by: Eric <menwe@amazon.com> * remove one modal related test Signed-off-by: Eric <menwe@amazon.com> --------- Signed-off-by: Eric <menwe@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
…shboard (opensearch-project#5934) Remove default sort to use saved search sort. Issue Resolve opensearch-project#5933 Signed-off-by: Anan Zhuang <ananzh@amazon.com>
* [Discover] Fixes safari overflow bug --------- Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> Signed-off-by: Anan Zhuang <ananzh@amazon.com> Co-authored-by: Anan Zhuang <ananzh@amazon.com> Co-authored-by: Miki <amoo_miki@yahoo.com>
…g to top (opensearch-project#6008) * [BUG][Discover] Enable 'Back to Top' Feature in Discover for scrolling to top dscCanvas is the one with scrollable prop. Set window.scrollTo(0, 0) on table will not work. In this PR, we add a ref to EuiPanel directly. Issue Resolve: opensearch-project#6006 --------- Signed-off-by: Anan Zhuang <ananzh@amazon.com> Co-authored-by: Miki <amoo_miki@yahoo.com>
* adds callback ref to lazy loading sentinel --------- Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
…-project#6170) * [Discover] options button in canvas to toggle legacy mode Removes top nav bar link and provides a button option. Issue: n/a Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## workspace-pr-integr #319 +/- ##
=======================================================
- Coverage 35.17% 35.17% -0.01%
=======================================================
Files 1885 1885
Lines 36421 36423 +2
Branches 6672 6673 +1
=======================================================
Hits 12810 12810
- Misses 22761 22763 +2
Partials 850 850
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…(opensearch-project#5815)
add log explorer re-directon modal
adjustments to comments
add one missing i18n
add redirection text to group title
include changes in changelog
remove redundent title addition and unnecessary modal toggle functions
remove one comment
add i18n
add unit tests for modal
test id change
add devDependencies for tests
use open confirm api and move mock file to discover mock folder
remove unused type
remove modal for log explorer redirection
modify changelog
remove modal test
remove one modal related test
Description
Issues Resolved
Screenshot
Testing the changes
Check List
yarn test:jestyarn test:jest_integration