Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update #27

Merged
merged 43 commits into from
Oct 24, 2018
Merged

update #27

merged 43 commits into from
Oct 24, 2018

Conversation

AntoineJac
Copy link

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

  • test parameters for validating bids
{
  bidder: '<bidder name>',
  params: {
    // ...
  }
}

Be sure to test the integration with your adserver using the Hello World sample page.

  • contact email of the adapter’s maintainer
  • official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

Other information

jsfaure and others added 30 commits October 9, 2018 15:31
* Pass Prebid version to Criteo direct bidder

* Update Criteo profile IDs

* Add RSA verification to Criteo FastBid

* Update package-lock with jsencrypt and crypto-js

* Replacing all arrow functions in Mocha function calls

* Update Adapter Version to 14
* Added Polymorph adapter

* Cleaned up code

* Updated var to let

* Updated with mediaType

* Updated tests

* Fixed tests

* Updated polymorph adapter to support cookie syncing and network key integration

* Fixed parens for lint

* Fixed a bug related to network_key approach

* Fixed double negation warning

* Updated tests for network_key

* Added bidId as cache buster and updated tests

* Fixed tests
* change bid map to bid_id map and clean up openrtb in pbs

* add src to bids in bid request when known
* Revert "Small bugfix and cleanup for Prebid Server OpenRTB code (#3113)"

This reverts commit a1f07e9.

* Revert "Added support for user syncing pixel (#3092)"

This reverts commit 8fdf61d.

* Revert "Add RSA validation to Criteo FastBid (#3110)"

This reverts commit e72e2dc.

* Revert "Adding appnexus debug via cookie/params (#3152)"

This reverts commit 4797ea2.
* render outstream safeframe

* move code to Renderer module

* some more logic to move
…#3165)

* rubiconBidAdapter - Checking FPD values are defined before toString()
                  - Added two tests for this behavior

* Removing unused variable

* changed to compare against null

added some null params to the tests to verify
* in-dev changes

* included config

* Unit test cases for DigitrustId passing in PubMatic bid adapter

* eslint fixes

* removed a comment

* replaced "() => {" with "() => {"
circleci is still failing, but I cannot find a workaround for this PR at the moment
* adds openxoutstreamadapter files

* cleans up url, adds bidder config and version, removes unused code

* updates template ad response

* remove final unused custom param code

* add openrtb to list of params again.

* add payload back so we can read bidId

* extra checks for cpm (pub_rev)

* adds unit tests

* adds unit tests

* update md page

* undo openx adapter space changes from autosave

* undo openx adapter space changes from autosave

* test cleanup

* test cleanup

* update md file

* update example page params

* remove sneaky console.log

* return false

* adds yieldmo to the md. remove useless docEl assignment

* remove useless docEl assignments

* move crid and adid to constants

* fix test

* remove another useless variable assignment caught by LGTM

* changes CR_ID. moves tdoc to within if scope

* updates crid on test

* use more constants and use crid for lfid

* remove superfluous trailing argument

* adds viewport meta tag to header. removes unnecessary string interpolation.

* move ad_id to a string

* undo changes for pacakge-lock

* fixes lfid to lfId, pID to pId

* fixes lfid to lfId, pID to pId

* remove rti:1

* adds openx maintainer email
* removing cookieSet

* removing blank line

* not including src/cookie anymore
* Adding GDPR support

* Always drop user syncs when available

* Set dealID based on buying type
* add stub for adloader in various adapter test files

* remove unneeded commented line of code
* stub adloader across the board to prevent requests going out

* add the adloader stub
* add adapter and doc

* add test

* fix adapter

* fix adapter

* fix adapter

* correct code after tests

* fix tests

* fix adapter and test

* fix buildQueryString and tests

* fix cpm devisor

* fix cpm devisor test

* fix doc

* fix tests

* add adapter and doc

* add test

* fix adapter

* fix adapter

* fix adapter

* correct code after tests

* fix tests

* fix adapter and test

* fix buildQueryString and tests

* fix cpm devisor

* fix cpm devisor test

* fix doc

* fix tests

* change referer source and remove userSync
* send request to endpoint

* tests

* improve tests

* Add description. Small fix

* add maintainer email

* restore origin package.json

* add getUserSyncs function

* remove userSyncs

* change endpoint_url params

* change test params

* change netRevenue to false
* Refactor rtbhouseBidAdapter and spec

* Add native support to RTB House adapter
ckbo3hrk and others added 13 commits October 19, 2018 14:14
* initial commit

* updated contact and tag details

* changes ti support the renderers

* changes to pass dimId

* fixed names of internal mapping

* added comment

* added gdpr param to request and other fixes

* modified api url

* fix

* fixed the secure api call

* rolled back video event callback till we support it

* updated doc with video details
… for auction' (#3198)

* Fixes #3197 - call auctionDone() when 'No valid bid requests returned for auction'

* #3197 Added unit test to check if callback is called when bidRequests is empty
* Add: rxrtb prebidAdapter

* Update: params for test

* Update: code format

* Update: code format

* Update: code format

* Fix param check

* Update rxrtbBidAdapter.js

* Remove required source param

* Update and rename rxrtbBidAdapter.js to rexrtbBidAdapter.js

* Update and rename rxrtbBidAdapter.md to rexrtbBidAdapter.md

* Update and rename rxrtbBidAdapter_spec.js to rexrtbBidAdapter_spec.js

* Revert "Update rxrtbBidAdapter.js"

This reverts commit 09bca02.

* Revert "Update and rename rxrtbBidAdapter_spec.js to rexrtbBidAdapter_spec.js"

This reverts commit 2481c58.

* Revert "Update and rename rxrtbBidAdapter.md to rexrtbBidAdapter.md"

This reverts commit af9a491.

* Revert "Update and rename rxrtbBidAdapter.js to rexrtbBidAdapter.js"

This reverts commit 81a17ad.

* Revert "Remove required source param"

This reverts commit 38b273d.

*  Revert "Update rxrtbBidAdapter.js"

* Update and rename rexrtbPrebid

* Update default host

* Revert update

* Update default host
* Rubicon adapter: Removed extraneous warning

* removing spaces to kick off the build again

circleci failed on some other adapter
@AntoineJac AntoineJac merged commit edcda2c into rubicon-project:release/1.27-rea Oct 24, 2018
robertrmartinez pushed a commit that referenced this pull request Jun 29, 2023
* add Rise adapter

* fixes

* change param isOrg to org

* Rise adapter

* change email for rise

* fix circle failed

* bump

* bump

* bump

* remove space

* Upgrade Rise adapter to 5.0

* added isWrapper param

* addes is_wrapper parameter to documentation

* added is_wrapper to test

* removed isWrapper

* Rise Bid Adapter: support Coppa param (#24)

* MinuteMedia Bid Adapter: support Coppa param (#25)

* Revert "MinuteMedia Bid Adapter: support Coppa param (#25)" (#26)

This reverts commit 66c4e7b.

* bump

* update coppa fetch

* setting coppa param update

* update Coppa tests

* update test naming

* Rise Bid Adapter: support plcmt and sua (#27)

---------

Co-authored-by: Noam Tzuberi <noam.tzuberi@ironsrc.com>
Co-authored-by: noamtzu <noamtzu@gmail.com>
Co-authored-by: Noam Tzuberi <noamtzu@users.noreply.github.com>
Co-authored-by: Laslo Chechur <laslo.chechur@ironsrc.com>
Co-authored-by: OronW <41260031+OronW@users.noreply.github.com>
Co-authored-by: lasloche <62240785+lasloche@users.noreply.github.com>
Co-authored-by: inna <innayare@gmail.com>
Co-authored-by: YakirLavi <yakir.lavi@risecodes.com>
musikele pushed a commit that referenced this pull request Aug 28, 2023
* add Rise adapter

* fixes

* change param isOrg to org

* Rise adapter

* change email for rise

* fix circle failed

* bump

* bump

* bump

* remove space

* Upgrade Rise adapter to 5.0

* added isWrapper param

* addes is_wrapper parameter to documentation

* added is_wrapper to test

* removed isWrapper

* Rise Bid Adapter: support Coppa param (#24)

* MinuteMedia Bid Adapter: support Coppa param (#25)

* Revert "MinuteMedia Bid Adapter: support Coppa param (#25)" (#26)

This reverts commit 66c4e7b.

* bump

* update coppa fetch

* setting coppa param update

* update Coppa tests

* update test naming

* Rise Bid Adapter: support plcmt and sua (#27)

---------

Co-authored-by: Noam Tzuberi <noam.tzuberi@ironsrc.com>
Co-authored-by: noamtzu <noamtzu@gmail.com>
Co-authored-by: Noam Tzuberi <noamtzu@users.noreply.github.com>
Co-authored-by: Laslo Chechur <laslo.chechur@ironsrc.com>
Co-authored-by: OronW <41260031+OronW@users.noreply.github.com>
Co-authored-by: lasloche <62240785+lasloche@users.noreply.github.com>
Co-authored-by: inna <innayare@gmail.com>
Co-authored-by: YakirLavi <yakir.lavi@risecodes.com>
musikele pushed a commit that referenced this pull request Aug 28, 2023
* add Rise adapter

* fixes

* change param isOrg to org

* Rise adapter

* change email for rise

* fix circle failed

* bump

* bump

* bump

* remove space

* Upgrade Rise adapter to 5.0

* added isWrapper param

* addes is_wrapper parameter to documentation

* added is_wrapper to test

* removed isWrapper

* Rise Bid Adapter: support Coppa param (#24)

* MinuteMedia Bid Adapter: support Coppa param (#25)

* Revert "MinuteMedia Bid Adapter: support Coppa param (#25)" (#26)

This reverts commit 66c4e7b.

* bump

* update coppa fetch

* setting coppa param update

* update Coppa tests

* update test naming

* Rise Bid Adapter: support plcmt and sua (#27)

* update minuteMediaBidAdapter - support missing params (#29)

---------

Co-authored-by: Noam Tzuberi <noam.tzuberi@ironsrc.com>
Co-authored-by: noamtzu <noamtzu@gmail.com>
Co-authored-by: Noam Tzuberi <noamtzu@users.noreply.github.com>
Co-authored-by: Laslo Chechur <laslo.chechur@ironsrc.com>
Co-authored-by: OronW <41260031+OronW@users.noreply.github.com>
Co-authored-by: lasloche <62240785+lasloche@users.noreply.github.com>
Co-authored-by: inna <innayare@gmail.com>
Co-authored-by: YakirLavi <yakir.lavi@risecodes.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.