Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 6 pull requests #110636

Merged
merged 17 commits into from
Apr 21, 2023
Merged

Rollup of 6 pull requests #110636

merged 17 commits into from
Apr 21, 2023

Commits on Apr 19, 2023

  1. Configuration menu
    Copy the full SHA
    204c516 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    73038d3 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    f362f6e View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2023

  1. remove unused message

    lcnr committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    4f757af View commit details
    Browse the repository at this point in the history
  2. more msg removal

    lcnr committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    82cb8a2 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    6b33245 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    4fd7739 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    3206100 View commit details
    Browse the repository at this point in the history
  6. ship clippy, miri and rustfmt with sysroot

    Signed-off-by: ozkanonur <work@onurozkan.dev>
    onur-ozkan committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    6d99d6a View commit details
    Browse the repository at this point in the history
  7. remove the early return in Sysroot::run which causes bypassing syml…

    …inking
    
    Signed-off-by: ozkanonur <work@onurozkan.dev>
    onur-ozkan committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    68fc568 View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2023

  1. Configuration menu
    Copy the full SHA
    a2f275d View commit details
    Browse the repository at this point in the history
  2. Rollup merge of rust-lang#110365 - ozkanonur:ship-tools-with-sysroot,…

    … r=jyn514
    
    ship tools with sysroot
    
    Provides tool binaries under the sysroot which can be used/tested with `cargo +custom-toolchain $tool`
    
    Clippy and fmt works without any problem.
    
    But can't say the same for miri:
    
    ```sh
      ~/devspace/.other/chunk-list  stable $ cargo +stage2 miri setup
    Running `"rustup" "component" "add" "rust-src"` to install the `rust-src` component for the selected toolchain.
    error: stage2 is a custom toolchain
    fatal error: failed to install the `rust-src` component for the selected toolchain
    ```
    
    it's looking for `$sysroot/lib/rustlib/src/rust/library` and that simply doesn't exists for `x build`.
    
    cc `@jyn514` (I thought you might be interested on this, since you did few review iterations on previous PRs of adding tools to sysroot)
    
    --
    
    **Update**
    
    Now we are able to use `miri` as well.
    
    After running `x b miri cargo-miri --stage 2`, I am able to run `cargo +stage2 miri setup` which works as expected.
    
    Resolves rust-lang#110625
    Resolves rust-lang#97762
    Resolves rust-lang#81431
    matthiaskrgr authored Apr 21, 2023
    Configuration menu
    Copy the full SHA
    f2321ec View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#110555 - compiler-errors:subst-missing-trai…

    …t-items, r=cjgillot
    
    Substitute missing trait items suggestion correctly
    
    Properly substitute missing item suggestions, so that when they reference generics from their parent trait they actually have the right time for the impl.
    
    Also, some other minor tweaks like using `/* Type */` to signify a GAT's type is actually missing, and fixing generic arg suggestions for GATs in general.
    matthiaskrgr authored Apr 21, 2023
    Configuration menu
    Copy the full SHA
    7d04655 View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#110578 - bvanjoi:fix-issue-110547, r=jackh726

    fix(error): normalize whitespace during msg_to_buffer
    
    close rust-lang#110547
    matthiaskrgr authored Apr 21, 2023
    Configuration menu
    Copy the full SHA
    637d9dd View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#110597 - lcnr:not-pin-via-negative-bound, r…

    …=compiler-errors
    
    remove unused ftl messages
    
    r? `@davidtwco`
    
    does it make sense to check via tidy that there exist no ftl message names which are never mentioned in `compiler/**.rs`
    matthiaskrgr authored Apr 21, 2023
    Configuration menu
    Copy the full SHA
    a8e2394 View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#110611 - GuillaumeGomez:regression-test-pub…

    …-reexport-pub-reexport, r=notriddle
    
    Add regression test for rust-lang#46506
    
    Fixes rust-lang#46506.
    
    This issue was fixed very likely alongside the others when we cleaned up the re-exports code.
    
    r? `@notriddle`
    matthiaskrgr authored Apr 21, 2023
    Configuration menu
    Copy the full SHA
    ea01135 View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#110618 - compiler-errors:eval-ctxt-tainted,…

    … r=BoxyUwU
    
    Track if EvalCtxt has been tainted, make sure it can't be used to make query responses after
    
    Just some additional protection against missing probes or strange candidate assembly behavior in the new solver.
    
    For background, we don't ever want to call `evaluate_added_goals_and_make_canonical_response` if a previous call to `try_evaluate_added_goals` has bailed with `NoSolution`, since our nested goals are left in an undefined state at that point. This most commonly suggests a missing `EvalCtxt::probe`, but could also signify some other shenanigans like dropping a `QueryResult` on the floor without properly `?`'ing it.
    
    r? `@lcnr`
    matthiaskrgr authored Apr 21, 2023
    Configuration menu
    Copy the full SHA
    77de5f0 View commit details
    Browse the repository at this point in the history