Improve the warning messages for the `#[diagnostic::on_unimplemented]` #116931

weiznich · 2023-10-19T06:52:41Z

This commit improves warnings emitted for malformed on unimplemented attributes by:

Improving the span of the warnings
Adding a label message to them
Separating the messages for missing and unexpected options
Adding a help message that says which options are supported

I'm happy to work on further improvements, so feel free to make suggestions.

Urgau

Diagnostics should not start with a Upper case.

There is some guidelines on the rustc-dev-guide https://rustc-dev-guide.rust-lang.org/diagnostics.html#suggestion-style-guide but unfortunatly not enough.

compiler/rustc_trait_selection/messages.ftl

This commit improves warnings emitted for malformed on unimplemented attributes by: * Improving the span of the warnings * Adding a label message to them * Separating the messages for missing and unexpected options * Adding a help message that says which options are supported

compiler-errors · 2023-10-19T16:29:31Z

...ic_namespace/on_unimplemented/ignore_unsupported_options_and_continue_to_use_fallback.stderr

@@ -22,8 +23,9 @@ LL | |     if(Self = ()),
 ...  |
 LL | |     note = "not used yet"
 LL | | )]
-   | |__^
+   | |__^ invalid option found here


Should be able to point at the if(Self = ()) here.

I've pushed a "fix" to address this somewhat. The problem there is that if(Self = ()) doesn't parse as meta_item_list(). I'm not sure why that's the case or whether that's the right behavior. The pushed "fix" just turns the attribute into something that can be parsed (if(Self = "()") in that case).

compiler-errors · 2023-10-25T15:24:07Z

@bors r+

bors · 2023-10-25T15:24:09Z

📌 Commit 3d03a8a has been approved by compiler-errors

It is now in the queue for this repository.

…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#116401 (Return multiple object-safety violation errors and code improvements to the object-safety check) - rust-lang#116553 (Do not suggest 'Trait<Assoc=arg>' when in trait impl) - rust-lang#116931 (Improve the warning messages for the `#[diagnostic::on_unimplemented]`) - rust-lang#117008 (Uplift `Canonical` to `rustc_type_ir`) - rust-lang#117009 (On unresolved imports, suggest a disambiguated path if necessary to avoid collision with local items) - rust-lang#117175 (Rename AsyncCoroutineKind to CoroutineSource) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#116931 - weiznich:improve_diagnostic_on_unimplemented_warnings, r=compiler-errors Improve the warning messages for the `#[diagnostic::on_unimplemented]` This commit improves warnings emitted for malformed on unimplemented attributes by: * Improving the span of the warnings * Adding a label message to them * Separating the messages for missing and unexpected options * Adding a help message that says which options are supported r? `@compiler-errors` I'm happy to work on further improvements, so feel free to make suggestions.

rustbot assigned compiler-errors Oct 19, 2023

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 19, 2023

Urgau reviewed Oct 19, 2023

View reviewed changes

compiler/rustc_trait_selection/messages.ftl Outdated Show resolved Hide resolved

compiler/rustc_trait_selection/messages.ftl Outdated Show resolved Hide resolved

weiznich force-pushed the improve_diagnostic_on_unimplemented_warnings branch from 6dfbcee to 9017b97 Compare October 19, 2023 13:01

compiler-errors reviewed Oct 19, 2023

View reviewed changes

Fix a span for one of the test cases

3d03a8a

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 25, 2023

matthiaskrgr mentioned this pull request Oct 25, 2023

Rollup of 6 pull requests #117193

Merged

bors merged commit d30fe8b into rust-lang:master Oct 26, 2023
11 checks passed

rustbot added this to the 1.75.0 milestone Oct 26, 2023

github-actions bot mentioned this pull request Oct 31, 2023

Automated pull from upstream master ferrocene/ferrocene#74

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improve the warning messages for the `#[diagnostic::on_unimplemented]` #116931

Improve the warning messages for the `#[diagnostic::on_unimplemented]` #116931

weiznich commented Oct 19, 2023

Urgau left a comment

compiler-errors Oct 19, 2023

weiznich Oct 20, 2023

compiler-errors Oct 20, 2023

compiler-errors commented Oct 25, 2023

bors commented Oct 25, 2023

Improve the warning messages for the #[diagnostic::on_unimplemented] #116931

Improve the warning messages for the #[diagnostic::on_unimplemented] #116931

Conversation

weiznich commented Oct 19, 2023

Urgau left a comment

Choose a reason for hiding this comment

compiler-errors Oct 19, 2023

Choose a reason for hiding this comment

weiznich Oct 20, 2023

Choose a reason for hiding this comment

compiler-errors Oct 20, 2023

Choose a reason for hiding this comment

compiler-errors commented Oct 25, 2023

bors commented Oct 25, 2023

Improve the warning messages for the `#[diagnostic::on_unimplemented]` #116931

Improve the warning messages for the `#[diagnostic::on_unimplemented]` #116931