x.ps1: remove the check for Python from Windows Store #117069

xobs · 2023-10-23T05:37:22Z

When installing Python from the Windows Store, a copy of python.exe is installed inder the Microsoft directory in the user's local AppData directory. Currently, x.ps1 checks for this file, because by default running python.exe opens a link to the Microsoft Store rather than running Python.

Once the user installs Python, however, this contains a valid interpreter. Unfortuantely, x.ps1 can't tell the difference between a legitimate Python install and the stub.

Remove the check, as it makes it impossible to use the official version from Microsoft once it has been installed.

This resolves #117067

When installing Python from the Windows Store, a copy of `python.exe` is installed inder the Microsoft directory in the user's local AppData directory. Currently, `x.ps1` checks for this file, because by default running `python.exe` opens a link to the Microsoft Store rather than running Python. Once the user installs Python, however, this contains a valid interpreter. Unfortuantely, `x.ps1` can't tell the difference between a legitimate Python install and the stub. Remove the check, as it makes it impossible to use the official version from Microsoft once it has been installed. Signed-off-by: Sean Cross <sean@xobs.io>

rustbot · 2023-10-23T05:37:30Z

r? @Mark-Simulacrum

(rustbot has picked a reviewer for you, use r? to override)

onur-ozkan · 2023-10-23T05:46:30Z

r? albertlarsan68

albertlarsan68 · 2023-10-23T05:48:11Z

Thanks for the PR!
@bors r+ rollup

bors · 2023-10-23T05:48:13Z

📌 Commit 1f9f041 has been approved by albertlarsan68

It is now in the queue for this repository.

…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#105666 (rustdoc: align stability badge to baseline instead of bottom) - rust-lang#117042 (coverage: Emit the filenames section before encoding per-function mappings) - rust-lang#117044 (Miri subtree update) - rust-lang#117049 (add a `csky-unknown-linux-gnuabiv2hf` target ) - rust-lang#117051 (fix broken link: update incremental compilation url) - rust-lang#117069 (x.ps1: remove the check for Python from Windows Store) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#117069 - xobs:x.ps1-remove-windows-store-check, r=albertlarsan68 x.ps1: remove the check for Python from Windows Store When installing Python from the Windows Store, a copy of `python.exe` is installed inder the Microsoft directory in the user's local AppData directory. Currently, `x.ps1` checks for this file, because by default running `python.exe` opens a link to the Microsoft Store rather than running Python. Once the user installs Python, however, this contains a valid interpreter. Unfortuantely, `x.ps1` can't tell the difference between a legitimate Python install and the stub. Remove the check, as it makes it impossible to use the official version from Microsoft once it has been installed. This resolves rust-lang#117067

rustbot assigned Mark-Simulacrum Oct 23, 2023

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Oct 23, 2023

xobs mentioned this pull request Oct 23, 2023

x.ps1 complains Python isn't installed, even though it is installed and working #117067

Closed

rustbot assigned albertlarsan68 and unassigned Mark-Simulacrum Oct 23, 2023

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 23, 2023

matthiaskrgr mentioned this pull request Oct 23, 2023

Rollup of 6 pull requests #117071

Merged

bors merged commit cec7d4a into rust-lang:master Oct 23, 2023
11 checks passed

rustbot added this to the 1.75.0 milestone Oct 23, 2023

github-actions bot mentioned this pull request Oct 31, 2023

Automated pull from upstream master ferrocene/ferrocene#74

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

x.ps1: remove the check for Python from Windows Store #117069

x.ps1: remove the check for Python from Windows Store #117069

xobs commented Oct 23, 2023

rustbot commented Oct 23, 2023

onur-ozkan commented Oct 23, 2023

albertlarsan68 commented Oct 23, 2023

bors commented Oct 23, 2023

x.ps1: remove the check for Python from Windows Store #117069

x.ps1: remove the check for Python from Windows Store #117069

Conversation

xobs commented Oct 23, 2023

rustbot commented Oct 23, 2023

onur-ozkan commented Oct 23, 2023

albertlarsan68 commented Oct 23, 2023

bors commented Oct 23, 2023