Create a new ConstantKind variant (ZeroSized) for StableMIR #117262

celinval · 2023-10-27T03:19:28Z

ZeroSized constants can be represented as mir::Const::Val even if their layout is not yet known. In those cases, CrateItem::body() was crashing when trying to convert a ConstValue::ZeroSized into its stable counterpart ConstantKind::Allocated.

Instead, we now map ConstValue::ZeroSized into a new variant: ConstantKind::ZeroSized.

Note: I didn't add any new test here since we already have covering tests in our project repository which I manually confirmed that will fix the issue.

ZeroSized constants can be represented as `mir::Const::Val` even if their layout is not yet known. In those cases, CrateItem::body() was crashing when trying to convert a `ConstValue::ZeroSized` into its stable counterpart `ConstantKind::Allocated`. Instead, we now map `ConstValue::ZeroSized` into a new variant: `ConstantKind::ZeroSized`.

rustbot · 2023-10-27T03:19:36Z

r? @b-naber

(rustbot has picked a reviewer for you, use r? to override)

rustbot · 2023-10-27T03:19:38Z

This PR changes Stable MIR

cc @oli-obk, @celinval, @spastorino, @ouz-a

celinval · 2023-10-27T03:20:16Z

r? @oli-obk
@ouz-a

ouz-a · 2023-10-27T05:03:22Z

Thanks for doing this I was going to attempt this last night but forgot about it!

oli-obk · 2023-10-27T08:15:27Z

@bors r+ rollup

bors · 2023-10-27T08:15:29Z

📌 Commit 613e618 has been approved by oli-obk

It is now in the queue for this repository.

…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#114998 (feat(docs): add cargo-pgo to PGO documentation 📝) - rust-lang#116868 (Tweak suggestion span for outer attr and point at item following invalid inner attr) - rust-lang#117240 (Fix documentation typo in std::iter::Iterator::collect_into) - rust-lang#117241 (Stash and cancel cycle errors for auto trait leakage in opaques) - rust-lang#117262 (Create a new ConstantKind variant (ZeroSized) for StableMIR) - rust-lang#117266 (replace transmute by raw pointer cast) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#117262 - celinval:issue-38-norm, r=oli-obk Create a new ConstantKind variant (ZeroSized) for StableMIR ZeroSized constants can be represented as `mir::Const::Val` even if their layout is not yet known. In those cases, CrateItem::body() was crashing when trying to convert a `ConstValue::ZeroSized` into its stable counterpart `ConstantKind::Allocated`. Instead, we now map `ConstValue::ZeroSized` into a new variant: `ConstantKind::ZeroSized`. **Note:** I didn't add any new test here since we already have covering tests in our project repository which I manually confirmed that will fix the issue.

rustbot assigned b-naber Oct 27, 2023

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 27, 2023

rustbot assigned oli-obk and unassigned b-naber Oct 27, 2023

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 27, 2023

matthiaskrgr mentioned this pull request Oct 27, 2023

Rollup of 6 pull requests #117272

Merged

bors merged commit 3374480 into rust-lang:master Oct 27, 2023
11 checks passed

rustbot added this to the 1.75.0 milestone Oct 27, 2023

github-actions bot mentioned this pull request Oct 31, 2023

Automated pull from upstream master ferrocene/ferrocene#74

Merged

celinval mentioned this pull request Nov 23, 2023

Panic while trying to get item body due to NormalizationFailure rust-lang/project-stable-mir#38

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Create a new ConstantKind variant (ZeroSized) for StableMIR #117262

Create a new ConstantKind variant (ZeroSized) for StableMIR #117262

celinval commented Oct 27, 2023

rustbot commented Oct 27, 2023

rustbot commented Oct 27, 2023

celinval commented Oct 27, 2023

ouz-a commented Oct 27, 2023

oli-obk commented Oct 27, 2023

bors commented Oct 27, 2023

Create a new ConstantKind variant (ZeroSized) for StableMIR #117262

Create a new ConstantKind variant (ZeroSized) for StableMIR #117262

Conversation

celinval commented Oct 27, 2023

rustbot commented Oct 27, 2023

rustbot commented Oct 27, 2023

celinval commented Oct 27, 2023

ouz-a commented Oct 27, 2023

oli-obk commented Oct 27, 2023

bors commented Oct 27, 2023