Poison check_well_formed if method receivers are invalid to prevent typeck from running on it #117403

oli-obk · 2023-10-30T15:58:13Z

Though if some code invokes typeck without having first invoked check_well_formed then we'll encounter this ICE again. This can happen in const and const fn bodies if they are evaluated due to other check_well_formed checks or similar

rustbot · 2023-10-30T15:58:22Z

r? @TaKO8Ki

(rustbot has picked a reviewer for you, use r? to override)

compiler/rustc_hir_analysis/src/check/wfcheck.rs

compiler-errors · 2023-10-30T16:11:51Z

r=me after changing the wf check to use ? -- i don't think we need to care about follow-up errors in this case, since we're only checking for bad method receivers.

…ypeck from running on it

oli-obk · 2023-10-30T16:13:35Z

compiler/rustc_hir_analysis/src/check/wfcheck.rs

-    f(&mut wfcx);
+    f(&mut wfcx)?;


Note that this causes any method receiver errors to prevent the trait solver from emitting any errors below

oli-obk · 2023-10-30T16:14:32Z

@bors r=compiler-errors

bors · 2023-10-30T16:14:34Z

📌 Commit ff3a818 has been approved by compiler-errors

It is now in the queue for this repository.

…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#116862 (Detect when trait is implemented for type and suggest importing it) - rust-lang#117389 (Some diagnostics improvements of `gen` blocks) - rust-lang#117396 (Don't treat closures/coroutine types as part of the public API) - rust-lang#117398 (Correctly handle nested or-patterns in exhaustiveness) - rust-lang#117403 (Poison check_well_formed if method receivers are invalid to prevent typeck from running on it) - rust-lang#117411 (Improve some diagnostics around `?Trait` bounds) - rust-lang#117414 (Don't normalize to an un-revealed opaque when we hit the recursion limit) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#117403 - oli-obk:the_gift_that_keeps_on_giving_116849, r=compiler-errors Poison check_well_formed if method receivers are invalid to prevent typeck from running on it fixes rust-lang#117379 Though if some code invokes typeck without having first invoked `check_well_formed` then we'll encounter this ICE again. This can happen in const and const fn bodies if they are evaluated due to other `check_well_formed` checks or similar

rustbot assigned TaKO8Ki Oct 30, 2023

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 30, 2023

compiler-errors reviewed Oct 30, 2023

View reviewed changes

compiler/rustc_hir_analysis/src/check/wfcheck.rs Outdated Show resolved Hide resolved

Poison check_well_formed if method receivers are invalid to prevent t…

ff3a818

…ypeck from running on it

oli-obk force-pushed the the_gift_that_keeps_on_giving_116849 branch from 8020f97 to ff3a818 Compare October 30, 2023 16:12

oli-obk commented Oct 30, 2023

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 30, 2023

compiler-errors assigned compiler-errors and unassigned TaKO8Ki Oct 30, 2023

matthiaskrgr mentioned this pull request Oct 30, 2023

Rollup of 7 pull requests #117415

Merged

bors merged commit 24c6b6c into rust-lang:master Oct 30, 2023
11 checks passed

rustbot added this to the 1.75.0 milestone Oct 30, 2023

github-actions bot mentioned this pull request Oct 31, 2023

Automated pull from upstream master ferrocene/ferrocene#74

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Poison check_well_formed if method receivers are invalid to prevent typeck from running on it #117403

Poison check_well_formed if method receivers are invalid to prevent typeck from running on it #117403

oli-obk commented Oct 30, 2023

rustbot commented Oct 30, 2023

compiler-errors commented Oct 30, 2023

oli-obk Oct 30, 2023

oli-obk commented Oct 30, 2023

bors commented Oct 30, 2023

Poison check_well_formed if method receivers are invalid to prevent typeck from running on it #117403

Poison check_well_formed if method receivers are invalid to prevent typeck from running on it #117403

Conversation

oli-obk commented Oct 30, 2023

rustbot commented Oct 30, 2023

compiler-errors commented Oct 30, 2023

oli-obk Oct 30, 2023

Choose a reason for hiding this comment

oli-obk commented Oct 30, 2023

bors commented Oct 30, 2023