Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement div_ceil for NonZero<unsigned> #132665

Merged
merged 1 commit into from
Nov 7, 2024
Merged

Implement div_ceil for NonZero<unsigned> #132665

merged 1 commit into from
Nov 7, 2024

Conversation

tyilo
Copy link
Contributor

@tyilo tyilo commented Nov 5, 2024

@rustbot
Copy link
Collaborator

rustbot commented Nov 5, 2024

r? @joboet

rustbot has assigned @joboet.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Nov 5, 2024
@tyilo tyilo requested a review from joboet November 6, 2024 22:54
@joboet
Copy link
Member

joboet commented Nov 7, 2024

Thank you
@bors r+ rollup

@bors
Copy link
Contributor

bors commented Nov 7, 2024

📌 Commit 97a1b94 has been approved by joboet

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 7, 2024
@joboet joboet mentioned this pull request Nov 7, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 7, 2024
@bors
Auto merge of rust-lang#132722 - joboet:rollup-0q67jyo, r=joboet
3d1dba8 
Rollup of 6 pull requests

Successful merges:

 - rust-lang#132057 (miri: update ABI compat checks to accept Option-like types)
 - rust-lang#132665 (Implement `div_ceil` for `NonZero<unsigned>`)
 - rust-lang#132694 (fix(x): fix a regex used to find python executable)
 - rust-lang#132707 (Add --diagnostic-width to some tests failing after 1a0c502)
 - rust-lang#132715 (fix `LazyLock::get` and `LazyLock::get_mut` document)
 - rust-lang#132716 (chore(issue-template): fix branch name)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 49a58c8 into rust-lang:master Nov 7, 2024
6 checks passed
@rustbot rustbot added this to the 1.84.0 milestone Nov 7, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Nov 7, 2024
@rust-timer
Unrolled build for rust-lang#132665
ea5b093 
Rollup merge of rust-lang#132665 - tyilo:nonzero-u-div-ceil, r=joboet

Implement `div_ceil` for `NonZero<unsigned>`

ACP: rust-lang/libs-team#471
@tyilo
Copy link
Contributor Author

tyilo commented Nov 8, 2024

@joboet What's the next step? Should I create tracking issue?

@joboet
Copy link
Member

joboet commented Nov 11, 2024

Yes, please. In fact, that should have been done before merging this, but I forgot about it, sorry!

@tyilo tyilo mentioned this pull request Nov 12, 2024
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joboet joboet Awaiting requested review from joboet

Assignees

@joboet joboet

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.84.0
Development

Successfully merging this pull request may close these issues.
4 participants
@tyilo @rustbot @joboet @bors