Initialize channel Blocks directly on the heap
#132738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
rustbot
added
S-waiting-on-review
|
r? libs |
cuviper
removed
the
T-compiler
This comment has been minimized.
This comment has been minimized.
The channel's `Block::new` was causing a stack overflow because it held 32 item slots, instantiated on the stack before moving to `Box::new`. The 32x multiplier made modestly-large item sizes untenable. That block is now initialized directly on the heap. Fixes rust-lang#102246
cuviper
force-pushed
the
channel-heap-init
branch
from
766ae45
to
03383ad
Compare
|
Can a corresponding PR be opened in the crossbeam-channel repository to avoid things getting out of sync? |
|
Well, I think crossbeam may not like MSRV 1.82 for edit: I've got something working with manual |
|
@bors r+ |
bors
added
S-waiting-on-bors
cuviper
added a commit
to cuviper/crossbeam
that referenced
this pull request
Nov 7, 2024
The list channel's `Block::new` was causing a stack overflow because it held 32 item slots, instantiated on the stack before moving to `Box::new`. The 32x multiplier made modestly-large item sizes untenable. That block is now initialized directly on the heap. References from the `std` channel implementation: * rust-lang/rust#102246 * rust-lang/rust#132738
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Nov 7, 2024
…eemdev Initialize channel `Block`s directly on the heap The channel's `Block::new` was causing a stack overflow because it held 32 item slots, instantiated on the stack before moving to `Box::new`. The 32x multiplier made modestly-large item sizes untenable. That block is now initialized directly on the heap. Fixes rust-lang#102246
cuviper
added a commit
to cuviper/crossbeam
that referenced
this pull request
Nov 7, 2024
The list channel's `Block::new` was causing a stack overflow because it held 32 item slots, instantiated on the stack before moving to `Box::new`. The 32x multiplier made modestly-large item sizes untenable. That block is now initialized directly on the heap. References from the `std` channel implementation: * rust-lang/rust#102246 * rust-lang/rust#132738
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 7, 2024
…llaumeGomez Rollup of 8 pull requests Successful merges: - rust-lang#130586 (Set "symbol name" in raw-dylib import libraries to the decorated name) - rust-lang#131913 (Add `{ignore,needs}-{rustc,std}-debug-assertions` directive support) - rust-lang#132095 (Fix rust-lang#131977 parens mangled in shared mut static lint suggestion) - rust-lang#132131 ([StableMIR] API to retrieve definitions from crates) - rust-lang#132696 (Compile `test_num_f128` conditionally on `reliable_f128_math` config) - rust-lang#132738 (Initialize channel `Block`s directly on the heap) - rust-lang#132739 (Fix `librustdoc/scrape_examples.rs` formatting) - rust-lang#132740 (Update test for LLVM 20's new vector splat syntax) r? `@ghost` `@rustbot` modify labels: rollup
|
@bors r- failed in #132751 (comment) |
bors
added
S-waiting-on-author
|
@bors try |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 8, 2024
Initialize channel `Block`s directly on the heap The channel's `Block::new` was causing a stack overflow because it held 32 item slots, instantiated on the stack before moving to `Box::new`. The 32x multiplier made modestly-large item sizes untenable. That block is now initialized directly on the heap. Fixes rust-lang#102246 try-job: test-various
taiki-e
pushed a commit
to crossbeam-rs/crossbeam
that referenced
this pull request
Nov 8, 2024
The list channel's `Block::new` was causing a stack overflow because it held 32 item slots, instantiated on the stack before moving to `Box::new`. The 32x multiplier made modestly-large item sizes untenable. That block is now initialized directly on the heap. References from the `std` channel implementation: * rust-lang/rust#102246 * rust-lang/rust#132738
This comment has been minimized.
This comment has been minimized.
|
💔 Test failed - checks-actions |
|
Added @bors r=ibraheemdev |
bors
added
S-waiting-on-bors
Noratrieb
reviewed
Nov 8, 2024
There was a problem hiding this comment.
is there a reason this can't be a std unit test?
There was a problem hiding this comment.
I couldn't get the old code to fail that way, I think because std tests are still built with optimization, which may be able avoid the stack slot altogether.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 8, 2024
Rollup of 5 pull requests Successful merges: - rust-lang#132161 ([StableMIR] A few fixes to pretty printing) - rust-lang#132389 (coverage: Simplify parts of coverage graph creation) - rust-lang#132452 (coverage: Extract safe FFI wrapper functions to `llvm_cov`) - rust-lang#132590 (Simplify FFI calls for `-Ztime-llvm-passes` and `-Zprint-codegen-stats`) - rust-lang#132738 (Initialize channel `Block`s directly on the heap) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 8, 2024
Rollup merge of rust-lang#132738 - cuviper:channel-heap-init, r=ibraheemdev Initialize channel `Block`s directly on the heap The channel's `Block::new` was causing a stack overflow because it held 32 item slots, instantiated on the stack before moving to `Box::new`. The 32x multiplier made modestly-large item sizes untenable. That block is now initialized directly on the heap. Fixes rust-lang#102246 try-job: test-various
mati865
pushed a commit
to mati865/rust
that referenced
this pull request
Nov 12, 2024
…eemdev Initialize channel `Block`s directly on the heap The channel's `Block::new` was causing a stack overflow because it held 32 item slots, instantiated on the stack before moving to `Box::new`. The 32x multiplier made modestly-large item sizes untenable. That block is now initialized directly on the heap. Fixes rust-lang#102246 try-job: test-various
mati865
pushed a commit
to mati865/rust
that referenced
this pull request
Nov 12, 2024
Rollup of 5 pull requests Successful merges: - rust-lang#132161 ([StableMIR] A few fixes to pretty printing) - rust-lang#132389 (coverage: Simplify parts of coverage graph creation) - rust-lang#132452 (coverage: Extract safe FFI wrapper functions to `llvm_cov`) - rust-lang#132590 (Simplify FFI calls for `-Ztime-llvm-passes` and `-Zprint-codegen-stats`) - rust-lang#132738 (Initialize channel `Block`s directly on the heap) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The channel's
Block::newwas causing a stack overflow because it held32 item slots, instantiated on the stack before moving to
Box::new.The 32x multiplier made modestly-large item sizes untenable.
That block is now initialized directly on the heap.
Fixes #102246
try-job: test-various