This repository has been archived by the owner on Mar 8, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initial HTTP server implementation
Renamed to REST proxy and project split into cmd and pkg
Using open-source SecretHub client
Configurable host
CircleCI setup
Add README with installation, usage and development instructions
Add passphrase fallback prompt
Set explicit localhost in Docker docs
Move to github.com/secrethub/secrethub-http-proxy
Use .zip format for Windows releases
Add badges to the readme
This makes the Dockerfile stand-alone instead of depending on goreleaser to create the binary. You can now build the image with "go build .".
Build the binary in the Dockerfile
Update secrethub-go to v0.18.0
mackenbach
approved these changes
Apr 30, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, nice work. Consider changing the release notes to:
This is the first beta release of the SecretHub HTTP proxy! 🎉
For now, it supports basic operations on secrets and we'll be adding more features soon.
### Added
- Read a secret
- Write a secret
- Delete a secret
Log errors when writing a response fails
Add a godoc badge to the readme
mackenbach
approved these changes
Apr 30, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked once more, looks good 👍
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first beta release of the SecretHub HTTP proxy! 🎉
For now, it supports basic operations on secrets and we'll be adding more features soon.
Added