Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow installing the latest version or extension specific versions from configuration #337

Closed
borekb opened this issue Jun 5, 2017 · 4 comments

Comments

@borekb
Copy link

borekb commented Jun 5, 2017

This is how info about extensions is currently stored:

[
  {
    "metadata": {
      "id": "6e440e71-8ed9-4f25-bb78-4b13096b8a03",
      "publisherId": "38bbe3f0-5204-4170-845e-c2f966d979b8",
      "publisherDisplayName": "Jun Han"
    },
    "name": "auto-rename-tag",
    "publisher": "formulahendry",
    "version": "0.0.12"
  },
  ...
]

There are version numbers which means that with every minor update, this file changes and new version of Gist is created. I think it would be better if extensions.json excluded those and new version of Gist would be uploaded on a true change of extensions.

@shanalikhan
Copy link
Owner

shanalikhan commented Jun 5, 2017

Actually it was on purpose to install the specified version from the marketplace.
and this is the one of the reason i have not switched to installing extensions using Code CLI so far - which provides a way only to download the latest version of extension , not by version.

But this can be a option to allow user to have the latest version by default, but only have the specified versions of extensions when he wants with a setting.

@shanalikhan shanalikhan changed the title extensions.json without version numbers Allow installing the latest version or extension specific versions from configuration Jun 5, 2017
@shanalikhan shanalikhan added this to the Backlog milestone Jun 5, 2017
@borekb
Copy link
Author

borekb commented Jun 5, 2017

I'd be interested in stats on how many people actually install concrete, non-latest version of extensions. I think that up until recently, it was even impossible to disable extension auto-updates although I might be wrong on that.

@shanalikhan
Copy link
Owner

shanalikhan commented Jun 6, 2017

microsoft/vscode#27375

Sometimes extension breaks on the new version though some authors may release in insiders first but if any extension breaks in the latest release, User will end up nothing so he can use the Gist to have the older version of extension. There can be more scenarios for that.

extensions.autoUpdate is the key that can be integrated if user installs the non-latest versions of extension it should be set to false always.

I'd be interested in stats on how many people actually install concrete, non-latest version of extensions.

Yes there will be less people bothering about controlling the versions but Settings Sync should provide complete solution.
Interaction with user is not possible via information messages, recently users ended up taking it as spam.

I have a plan #230 to show the monthly results on blog, after adding Google Analytic for events, if you know any alternative free tool then do share.

@shanalikhan shanalikhan modified the milestones: Backlog, v3.1 Feb 25, 2018
shanalikhan added a commit that referenced this issue Aug 14, 2018
shanalikhan added a commit that referenced this issue Aug 26, 2018
* german localization

* corrected naming of locale

* german localization

* corrected naming of locale

* fix: missing partial i18n translation

* fix: missing partial i18n translation

* fix: add missing key for German language file

* fix: typo

* Minor Wording Changes

The text on some parts looked strange and not correct, thought I'd update a few for grammar and looks.

* chore: update .gitignore

* chore: add tslint and prettier rules

* chore: add format script

* chore: update teslint rules to make it defined mutilple class in one file

* chore: run tslint before publish extension

* refactor: format the code with prettier

* chore: update tsconfig and tslint

* refactor: refactor utils.ts

* refactor: refactor localize.ts

* refactor: refactor setting.ts

* refactor: refactor environmentPath.ts

* refactor: refactor fileService.ts

* chore: update teslint rules

* refactor: replace github package with @octokit/rest

* chore: update teslint rules

* refactor: refactor commons.ts

* refactor: refactor pluginService.ts

* refactor: extension.ts

* feat: replace fs module with fs-extra, and use async await instead of callback style

* feat: update deps for vscode/typescript/adm-zip/tslint

* refactor: refactor callback style with async await

* remove unused dependencies ncp and rimraf, use fs-extra instead

* fix: invalid @octokit/rest constructor options

* chore: update travis script

* fix: lstat should be async no sync

* fix: user agent for proxy

* pref: improve performance when start up. use async instead of sync method #472

* fix: implement promisify and fix lockfile

* feat: use lockfile instead of proper-lockfile.

* pref: improve performance

* refactor: add sync class and clean up extension file. it should improve startup performance #472

* refactor: add lockfile.ts

* fix: typo ShowSummaryOutput

* refactor: refactor download function

* fix: lockfile

* refactor: rename 'en' to 'env'

* refactor: remove unused activationEvents

* refactor: refactor upload logic, make it clean

* style: rename lockfile function name, make it same style with other

* refactor: sync advance options

* chore: not allow unuser locals and params. make it clean

* refactor: remove unused local and params

* refactor: remove unneed await

* pref: improve localize performance, init when extension be actived

* fix: make sure resolve language merger with default language.

* Update tutorial message

* Fix slack img

* Update path to imgur link

* Update tutorial link again

* Extension Installation CLI Added
TSLint Improved
#434
#590
#513
#337

* Summary improved

* Github Api Code Improvements

Anonymous Gist Code Removed
Initializtion in contructor
github api updated
proxy addition
github enterprise support updated

* Ignored extensions can be accidentally deleted if removeExtensions is enabled. (#604)

* Fix for #516

* Update to fix `ignoredExtensions` where extensions were deleted if `removeExtensions` was enabled.

* #604

* Extension summary

#577

* Gist Name change
#513

* #611

* fix: error translation

* #611 - Changelog

CLI Improvements

* #611

* #611
@shanalikhan
Copy link
Owner

By default it will now install latest version.
If you need to keep version specific settings then use useCliBaseInstallation as false in Settings Sync Global Settings.
I will improve it more in next releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants