Discussion : Improving Startup Time

[lovelyjuice]

• Extension Name: code-settings-sync
• Extension Version: 2.8.7
• OS Version: Windows_NT x64 10.0.16299
• VSCode version: 1.19.0

We have written the needed data into your clipboard. Please paste:

{
	"activationTimes": {
		"startup": true,
		"codeLoadingTime": 346,
		"activateCallTime": 1,
		"activateResolvedTime": 261,
		"activationEvent": "*"
	}
}

Is it possible that the plugin was partly loaded at the vscode starting up, and then entirely loaded when I use it to synchonize my settings?

[shanalikhan]

can you share your settings sync settings

[lovelyjuice]

@shanalikhan

{ 
    "sync.gist": "ae956d6743ce0053f3bcb198ff6083cb",
    "sync.lastUpload": "",
    "sync.autoUpload": false,
    "sync.quietSync": false,
    "sync.autoDownload": false,
    "sync.lastDownload": "2017-12-17T09:37:53.357Z",
    "sync.forceDownload": false,
    "sync.anonymousGist": false,
    "sync.host": "",
    "sync.pathPrefix": "",
    "sync.askGistName": false
}

That's all settings about settings sync in my user settings file

[shanalikhan]

I have renamed this thread as discussion and open for pull request from anyone having ideas to improve the startup.
Feel free to discuss here.

code-settings-sync/src/extension.ts

Line 32 in 8686424

await common.StartMigrationProcess();

code-settings-sync/src/extension.ts

Line 33 in 8686424

let startUpSetting: ExtensionConfig = await common.GetSettings();

code-settings-sync/src/extension.ts

Line 34 in 8686424

let startUpCustomSetting: CustomSettings = await common.GetCustomSettings();

On startup, currently these things are performed:

1. Migration Process to update the versions and settings
2. Read across settings to allow auto upload and download on startup

[axetroy]

@shanalikhan
I found that in source code.

    "activationEvents": [
        "*",
        "onCommand:extension.updateSettings",
        "onCommand:extension.downloadSettings",
        "onCommand:extension.resetSettings",
        "onCommand:extension.HowSettings",
        "onCommand:extension.otherOptions"
    ],

It means the extension is always be activated.

I know this may be the function of automatically synchronizing settings when starting VSCode.

And we have to consider that: Do we really need to sync automatically?

So, here is my solution:

1. Turn off auto download. BREAKING CHANGE
2. Optimized activate function

Here are some sync method will blocking thread in activate function.

let lockExist: boolean = await FileService.FileExists(en.FILE_SYNC_LOCK);
if (!lockExist) {
  fs.closeSync(fs.openSync(en.FILE_SYNC_LOCK, 'w'));
}

let locked: boolean = lockfile.checkSync(en.FILE_SYNC_LOCK);
if (locked) {
  lockfile.unlockSync(en.FILE_SYNC_LOCK);
}

[shanalikhan]

Do we really need to sync automatically? Turn off auto download. BREAKING CHANGE

Yes Settings sync needs to supports auto upload and auto download features.
They are turned off by default but user can set it ON and use that.
In activation it checks either those modes are on or off and then perform the functions if found ON

[axetroy]

@shanalikhan

I didn't mean this.

I mean. set activationEvents: ["*"] then extension will always run activation function even user don't need it really. and activation function takes times to load. Slow down the speed of VSCode.

The best situation is: when I need it and when it runs.

I know why we can't remove it. because it required by auto download setting when VSCode startup

so, what I mean is: manual or automatic sync

If manual: We can remove activationEvents: ["*"]. the extension only run when it be trigger command.

If automatic: extension always run when VSCdoe startup

[shanalikhan]

Well, Lets keep this automatic for now.

[shanalikhan]

Startup Time in Linux :