Ignored extensions can be accidentally deleted if removeExtensions is enabled. #604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
March 21, 2018 17:52
…emoveExtensions` was enabled.
|
As i am going to release this PR in next version, there are some conflicts with the code base. |
|
Thanks, I will look into it. |
|
Getting ts-check errors in Travis ... all the changes are in there, but I do not work with Typescript so might need some checking. |
|
I will look into it, thanks |
shanalikhan
added a commit
that referenced
this pull request
Aug 26, 2018
* german localization * corrected naming of locale * german localization * corrected naming of locale * fix: missing partial i18n translation * fix: missing partial i18n translation * fix: add missing key for German language file * fix: typo * Minor Wording Changes The text on some parts looked strange and not correct, thought I'd update a few for grammar and looks. * chore: update .gitignore * chore: add tslint and prettier rules * chore: add format script * chore: update teslint rules to make it defined mutilple class in one file * chore: run tslint before publish extension * refactor: format the code with prettier * chore: update tsconfig and tslint * refactor: refactor utils.ts * refactor: refactor localize.ts * refactor: refactor setting.ts * refactor: refactor environmentPath.ts * refactor: refactor fileService.ts * chore: update teslint rules * refactor: replace github package with @octokit/rest * chore: update teslint rules * refactor: refactor commons.ts * refactor: refactor pluginService.ts * refactor: extension.ts * feat: replace fs module with fs-extra, and use async await instead of callback style * feat: update deps for vscode/typescript/adm-zip/tslint * refactor: refactor callback style with async await * remove unused dependencies ncp and rimraf, use fs-extra instead * fix: invalid @octokit/rest constructor options * chore: update travis script * fix: lstat should be async no sync * fix: user agent for proxy * pref: improve performance when start up. use async instead of sync method #472 * fix: implement promisify and fix lockfile * feat: use lockfile instead of proper-lockfile. * pref: improve performance * refactor: add sync class and clean up extension file. it should improve startup performance #472 * refactor: add lockfile.ts * fix: typo ShowSummaryOutput * refactor: refactor download function * fix: lockfile * refactor: rename 'en' to 'env' * refactor: remove unused activationEvents * refactor: refactor upload logic, make it clean * style: rename lockfile function name, make it same style with other * refactor: sync advance options * chore: not allow unuser locals and params. make it clean * refactor: remove unused local and params * refactor: remove unneed await * pref: improve localize performance, init when extension be actived * fix: make sure resolve language merger with default language. * Update tutorial message * Fix slack img * Update path to imgur link * Update tutorial link again * Extension Installation CLI Added TSLint Improved #434 #590 #513 #337 * Summary improved * Github Api Code Improvements Anonymous Gist Code Removed Initializtion in contructor github api updated proxy addition github enterprise support updated * Ignored extensions can be accidentally deleted if removeExtensions is enabled. (#604) * Fix for #516 * Update to fix `ignoredExtensions` where extensions were deleted if `removeExtensions` was enabled. * #604 * Extension summary #577 * Gist Name change #513 * #611 * fix: error translation * #611 - Changelog CLI Improvements * #611 * #611
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ignored extensions can be accidentally deleted if removeExtensions is enabled. This fixes it by filtering out the extensions at the remove and install stages.