syncLocalSettings does not support replacing setting with "False" value

[robertpeteuil]

Visual Studio Code Version : 1.21.0 (1.21.0)
Code Settings Sync Version : 2.9.0
Operating System : macOS 10.12.7, Ubuntu 16.04
Occurs On: Download
Proxy Enabled: No
GIst Id: (private)

Problem:

• If an entry in the replaceCodeSettings: section of syncLocalSettings.json sets the value of a setting to False, the setting is deleted from the local machines settings file (instead of setting it to a False value).
• This is an issue as there are many setting which default to True and require explicit values of False to turn them off.

Scenario:

• I'm syncing between multiple machines and only want the Docker sidebar visible on my Linux machines.
• Hiding the sidebar required adding "docker.showExplorer": false to settings, so I set:
  • "docker.showExplorer": false to syncLocalSettings.json on my Macs
  • "docker.showExplorer": true to syncLocalSettings.json on my Linux machines.
• When I sync, the setting "docker.showExplorer" is completely deleted from the settings file on my Macs.
• Since it defaults to True, deleting it is the same as setting it to True.

It appears that replaceCodeSettings assumes a value of False means it should delete the setting. How can I explicitly set a setting as False on specific machines?

[leepowelldev]

I am getting the same when trying to set http.proxyStrictSSL: false

[leepowelldev]

PR here: #521

[robertpeteuil]

@leepowellcouk Cool, thank you!

[shanalikhan]

Thanks for PR.
Will be released in next version.

[shanalikhan]

Released in v2.9.1
let me know if there is any issue.