Set Activity Center as the new default #14492

ilmotta · 2022-12-05T12:58:12Z

Partially implements #14490

Summary

This tiny little PR simply enables the new Activity Center (AC) by default. A follow up PR will then remove the old Notification Center code and the flag. The goal is for the AC to be usable in the next release, so we can dogfood the redesigned mobile app.

Types of notifications supported by the new AC as of 2022-12-06

Mentions
Contact requests
Identity verification requests (apparently will be deprecated in the MVP).

Why?

This PR is needed because I want to be sure the new AC won't disrupt the QA team in the first place. Also because I want the next PR (not yet created) that will remove the old Notification Center to be merged as fast as possible, in order to avoid code conflicts. Hence why enabling the flag is coming before code deletion.

Platforms

Android
iOS

Steps to test

The most important case to test IMO is the Contact Request flow, because it's a requirement to chat with other users. To test the Activity Center, simply click on the bell icon in the home screen.

There are many issues already created mapping the work left to be done for the AC. You can check them out here https://github.com/status-im/status-mobile/labels/Activity%20center.

Figma flows: https://www.figma.com/file/eDfxTa9IoaCMUy5cLTp0ys/Shell-for-Mobile?node-id=451%3A18681&t=gIS1Vt4Ucc2gSrlr-0

Note for QA review

There's an open issue I'm working on right now Pending contact requests are not displayed when the new Activity Center is enabled #14495

status: ready

status-im-auto · 2022-12-05T13:03:26Z

Jenkins Builds

Click to see older builds (8)

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`af2952e`	#1	2022-12-05 13:03:26	~4 min	`tests`	📄`log`
✔️	`af2952e`	#1	2022-12-05 13:06:10	~7 min	`android-e2e`	🤖`apk` 📲
✔️	`af2952e`	#1	2022-12-05 13:07:57	~9 min	`android`	🤖`apk` 📲
✔️	`af2952e`	#1	2022-12-05 13:15:24	~16 min	`ios`	📱`ipa` 📲

✔️	`f077ab6`	#2	2022-12-07 17:31:27	~2 min	`tests`	📄`log`
✔️	`f077ab6`	#2	2022-12-07 17:36:42	~8 min	`android-e2e`	🤖`apk` 📲
✔️	`f077ab6`	#2	2022-12-07 17:37:53	~9 min	`android`	🤖`apk` 📲
✔️	`f077ab6`	#2	2022-12-07 17:42:39	~13 min	`ios`	📱`ipa` 📲

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`4a3f3aa`	#3	2022-12-08 21:32:06	~2 min	`tests`	📄`log`
✔️	`4a3f3aa`	#3	2022-12-08 21:38:02	~8 min	`android`	🤖`apk` 📲
✔️	`4a3f3aa`	#3	2022-12-08 21:38:32	~8 min	`android-e2e`	🤖`apk` 📲
✔️	`4a3f3aa`	#3	2022-12-08 21:42:38	~12 min	`ios`	📱`ipa` 📲

✔️	`9c31dd1`	#4	2022-12-09 12:29:37	~4 min	`tests`	📄`log`
✔️	`9c31dd1`	#4	2022-12-09 12:33:09	~7 min	`android`	🤖`apk` 📲
✔️	`9c31dd1`	#4	2022-12-09 12:36:28	~11 min	`android-e2e`	🤖`apk` 📲
✔️	`9c31dd1`	#4	2022-12-09 12:43:48	~18 min	`ios`	📱`ipa` 📲

status-im-auto · 2022-12-06T12:37:27Z

0% of end-end tests have passed

Total executed tests: 4
Failed tests: 4
Passed tests: 0
Not executed tests: 3

IDs of not executed tests: 702774,702775,702776

IDs of failed tests: 702733,702745,702730,702731

Not executed tests (3)

Click to expand

Rerun not executed tests

Failed tests (4)

Click to expand

Rerun failed tests

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_text_message_delete_push_disappear, id: 702733
Test setup failed: critical/chats/test_1_1_public_chats.py:1246: in prepare_devices self.chat_2 = self.home_2.get_chat(self.default_username_1).click() ../views/home_view.py:265: in get_chat chat_in_ac.wait_for_element(20) ../views/base_element.py:116: in wait_for_element raise TimeoutException( Device `2`: `ActivityCenterChatElement` by` xpath`: `//*[@content-desc='chat-name-or-sender-text'][starts-with(@text,'Each Powerless Wasp')]/../..` is not found on the screen after wait_for_element
2. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
Test setup failed: critical/chats/test_1_1_public_chats.py:1246: in prepare_devices self.chat_2 = self.home_2.get_chat(self.default_username_1).click() ../views/home_view.py:265: in get_chat chat_in_ac.wait_for_element(20) ../views/base_element.py:116: in wait_for_element raise TimeoutException( Device `2`: `ActivityCenterChatElement` by` xpath`: `//*[@content-desc='chat-name-or-sender-text'][starts-with(@text,'Each Powerless Wasp')]/../..` is not found on the screen after wait_for_element
3. test_1_1_chat_message_reaction, id: 702730
Device 2: Tap on found: ChatsTab Device 2: Looking for chat: 'Each Powerless Wasp' Test setup failed: critical/chats/test_1_1_public_chats.py:1246: in prepare_devices self.chat_2 = self.home_2.get_chat(self.default_username_1).click() ../views/home_view.py:265: in get_chat chat_in_ac.wait_for_element(20) ../views/base_element.py:116: in wait_for_element raise TimeoutException( Device `2`: `ActivityCenterChatElement` by` xpath`: `//*[@content-desc='chat-name-or-sender-text'][starts-with(@text,'Each Powerless Wasp')]/../..` is not found on the screen after wait_for_element Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
4. test_1_1_chat_pin_messages, id: 702731
Test setup failed: critical/chats/test_1_1_public_chats.py:1246: in prepare_devices self.chat_2 = self.home_2.get_chat(self.default_username_1).click() ../views/home_view.py:265: in get_chat chat_in_ac.wait_for_element(20) ../views/base_element.py:116: in wait_for_element raise TimeoutException( Device `2`: `ActivityCenterChatElement` by` xpath`: `//*[@content-desc='chat-name-or-sender-text'][starts-with(@text,'Each Powerless Wasp')]/../..` is not found on the screen after wait_for_element

status-im-auto · 2022-12-06T13:40:19Z

0% of end-end tests have passed

Total executed tests: 4
Failed tests: 4
Passed tests: 0

IDs of failed tests: 702731,702745,702730,702733

Failed tests (4)

Click to expand

Rerun failed tests

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_pin_messages, id: 702731
Test setup failed: critical/chats/test_1_1_public_chats.py:1246: in prepare_devices self.chat_2 = self.home_2.get_chat(self.default_username_1).click() ../views/home_view.py:265: in get_chat chat_in_ac.wait_for_element(20) ../views/base_element.py:116: in wait_for_element raise TimeoutException( Device `2`: `ActivityCenterChatElement` by` xpath`: `//*[@content-desc='chat-name-or-sender-text'][starts-with(@text,'Safe Imaginative Australi')]/../..` is not found on the screen after wait_for_element
2. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
Test setup failed: critical/chats/test_1_1_public_chats.py:1246: in prepare_devices self.chat_2 = self.home_2.get_chat(self.default_username_1).click() ../views/home_view.py:265: in get_chat chat_in_ac.wait_for_element(20) ../views/base_element.py:116: in wait_for_element raise TimeoutException( Device `2`: `ActivityCenterChatElement` by` xpath`: `//*[@content-desc='chat-name-or-sender-text'][starts-with(@text,'Safe Imaginative Australi')]/../..` is not found on the screen after wait_for_element
3. test_1_1_chat_message_reaction, id: 702730
Device 2: Tap on found: ChatsTab Device 2: Looking for chat: 'Safe Imaginative Australiansilkyterrier' Test setup failed: critical/chats/test_1_1_public_chats.py:1246: in prepare_devices self.chat_2 = self.home_2.get_chat(self.default_username_1).click() ../views/home_view.py:265: in get_chat chat_in_ac.wait_for_element(20) ../views/base_element.py:116: in wait_for_element raise TimeoutException( Device `2`: `ActivityCenterChatElement` by` xpath`: `//*[@content-desc='chat-name-or-sender-text'][starts-with(@text,'Safe Imaginative Australi')]/../..` is not found on the screen after wait_for_element Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
4. test_1_1_chat_text_message_delete_push_disappear, id: 702733
Test setup failed: critical/chats/test_1_1_public_chats.py:1246: in prepare_devices self.chat_2 = self.home_2.get_chat(self.default_username_1).click() ../views/home_view.py:265: in get_chat chat_in_ac.wait_for_element(20) ../views/base_element.py:116: in wait_for_element raise TimeoutException( Device `2`: `ActivityCenterChatElement` by` xpath`: `//*[@content-desc='chat-name-or-sender-text'][starts-with(@text,'Safe Imaginative Australi')]/../..` is not found on the screen after wait_for_element

VolodLytvynenko · 2022-12-06T15:58:44Z

hi @ilmotta please, help me with clarification of the notification receiving flow in AC.
Currently, all e2e tests are broken due no ability to find 'ActivityCenterChatElement' element. This happens because the notification in the Activity Centre is not shown if the flow of chat key adding is going through this [+] button
that is shown on the chat page.
Is this an expected behavior that after key chat is pasted, the notification is not shown? If yes, what should be done with this button if it is not working anymore? Currently, I don't see reasons to use it.

ilmotta · 2022-12-06T19:19:25Z

hi @ilmotta please, help me with clarification of the notification receiving flow in AC. Currently, all e2e tests are broken due no ability to find 'ActivityCenterChatElement' element. This happens because the notification in the Activity Centre is not shown if the flow of chat key adding is going through this [+] button that is shown on the chat page. Is this an expected behavior that after key chat is pasted, the notification is not shown? If yes, what should be done with this button if it is not working anymore? Currently, I don't see reasons to use it.

Hey @VladimrLitvinenko, thanks for testing the PR. Let me try to explain some details that might not be obvious.

The new Activity Center is not (necessarily) going to display the same notifications displayed by the current Notification Center. What's currently implemented in the new AC is what I've shared in the PR description:

Notifications for mentions.
Notifications for contact requests.
Notifications for identity verification requests (apparently this feature will be deprecated for the MVP, so I'd say it's lower priority to test it now).

Other kinds of notifications will be supported in the next coming weeks/months. I think it's important to reinforce that the backend still generates/stores the same notifications, it's just that the new AC frontend has not yet implemented a way to display them. So the new AC has the same capabilities as the old Notification Center, but we need more time to achieve feature parity.

I've just created issue #14501, as it's related to this problem we're discussing now. As I mentioned in #14501, there will be different business rules to how/when 1:1 notifications are generated, but because I haven't been working on this specific type of notification I can't answer precisely the new requirements. This is left for the person that eventually pick the issue.

So, to answer your question:

If yes, what should be done with this button if it is not working anymore? Currently, I don't see reasons to use it.

I think for now we should keep the button. But perhaps we should disable the failing tests relying on a 1:1 notification being generated. Do you think we can skip the failing tests? I know it's not ideal 🤷‍♂️

VolodLytvynenko · 2022-12-07T10:58:24Z

Hi @ilmotta should these UI notifs be in the scope of the current PR

ISSUE 1: The notif in Activity is not shown as per visual if the light mode is used
Steps to reproduce:

Go to Appearance -> Set 'light' mode
Go to contacts as User_A
Add new contact using the chat key of User_B
Check the Activity center as User_B

Actual result:

The 'sent contact request' text is shifted and shown in 2 rows if '3 random name' is too long
The 'sent contact request' text is black in color

Expected result:

The 'sent contact request' text is shown in 1 row below if '3 random name' is too long
The 'sent contact request' text is white color

ENV: Any android device

I am not sure that issues #2 and #3 are in the scope of this PR. Let me know if they should be created separately
ISSUE 2. The empty Activity Center is not shown as per visual
Steps to reproduce:
Open empty activity center

Actual result:

Expected result:

ISSUE 3. The accepted and declined contact are not shown in the Activity Center
Steps to reproduce:

Go to contacts as User_A
Add new contact using the chat key of User_B
Check the Activity center as User_B
Accept or Decline the request

Actual result:
The notification is disappeared

Expected result:
The status of the request is shown as per visual as Accepted or Declined

VolodLytvynenko · 2022-12-07T11:01:34Z

Currently, I am blocked by #14362 to test this PR fully, because the mentions are not ready yet

ilmotta · 2022-12-07T12:31:01Z

Thanks for the detailed reports @VladimrLitvinenko. Let's see:

The 'sent contact request' text is black in color

I'm going to fix this real quick in a future PR. Good catch.

The 'sent contact request' text is shifted and shown in 2 rows if '3 random name' is too long

This is the expected behavior in Figma as well. In your screenshot we can see the text would not fit in a single line without overflowing the surrounding padding, so it has to be displayed in 2 rows.

The empty Activity Center is not shown as per visual.

This is on purpose, because the Design team has not finished the mockups for the empty state, so meanwhile it was decided to not waste time implementing that temporary empty state (the text will change, styles, etc). This is being tracked on issue Display empty tab state when there are no notifications

The accepted and declined contact are not shown in the Activity Center

I tried to reproduce this issue, but it works fine for me. So could you give more detailed instructions about the problem? Which tab you had selected? Was the all/unread filter enabled? If it's not asking too much, but a video would help me reproduce :)

VolodLytvynenko · 2022-12-07T12:56:42Z

I tried to reproduce this issue, but it works fine for me. So could you give more detailed instructions about the problem? Which tab you had selected? Was the all/unread filter enabled? If it's not asking too much, but a video would help me reproduce :)

Sorry, I didn't specify it should be done on Android. The record is done for android studio, but for my real device: Huawei p20 light; Android version: 9 it is reproducible as well.
https://user-images.githubusercontent.com/52490791/206184020-53a719a4-1f3e-4624-ac5e-abfc561d017f.mp4

Also, the error pop up appears when I try to navigate to any tab: "all", "admin", "mention" etc. that also visible on the record

ilmotta · 2022-12-07T13:34:53Z

@VladimrLitvinenko

Sorry, I didn't specify it should be done on Android. The record is done for android studio, but for my real device: Huawei p20 light; Android version: 9 it is reproducible as well.

I exclusively use GNU/Linux and Android Studio :)

Also, the error pop up appears when I try to navigate to any tab: "all", "admin", "mention" etc. that also visible on the record

I've never seen this error. I'll try to reproduce using other physical devices I have here, because it never happened to me in Android Studio.

About the disappearing notification, this is expected according to the current design. It vanished because once you interact with a notification with call to action, the notification is marked as read, but because you had the filter enabled to only display unread notifications, it disappeared. If you accept/reject the contact request with the filter disabled (i.e. show both read/unread), then you'll still see the notification.

As far as I remember, designers chose a behavior similar to WhatsApp or some other known product. I think some sort of animation could be helpful to users, to somehow hint what happens when a notification is marked as read. Some animations will be implemented before the MVP is released @VladimrLitvinenko. I'm taking note of your feedback for future reference.

ilmotta · 2022-12-07T13:48:54Z

Currently, I am blocked by #14362 to test this PR fully, because the mentions are not ready yet

What's exactly blocking this PR from being further reviewed/approved @VladimrLitvinenko? I'm not sure I understand the relationship between issue #14362 and this PR.

du82 · 2022-12-07T14:18:52Z

I am getting the same error. The top bar is also not the same color, and the blur color doesn't match designs

du82 · 2022-12-07T14:20:18Z

Visually looks good in dark mode, not in light mode. Bug wise, still having problems

VolodLytvynenko · 2022-12-07T14:34:21Z

Currently, I am blocked by #14362 to test this PR fully, because the mentions are not ready yet

What's exactly blocking this PR from being further reviewed/approved @VladimrLitvinenko? I'm not sure I understand the relationship between issue #14362 and this PR.

Currently, as a user, I am not able to mention other users in chats using @. It is described in #14362 in ISSUE 1.
The relation between those PRs that in the current PR implemented notification that should be shown after some users are mentioned. Am I right?

VolodLytvynenko · 2022-12-07T14:44:00Z

About the disappearing notification, this is expected according to the current design. It vanished because once you interact with a notification with call to action, the notification is marked as read, but because you had the filter enabled to only display unread notifications, it disappeared. If you accept/reject the contact request with the filter disabled (i.e. show both read/unread), then you'll still see the notification.

Oh. Now I got it. Thank you!

ilmotta · 2022-12-07T14:45:48Z

Visually looks good in dark mode, not in light mode. Bug wise, still having problems

@VladimrLitvinenko, @Du64: I'll try give a round of review for light mode and create an issue to fix these type of errors later.

ilmotta · 2022-12-07T14:47:32Z

I am getting the same error. The top bar is also not the same color, and the blur color doesn't match designs

@Du64, which "same error" are you referring to?

ilmotta · 2022-12-07T14:52:38Z

Currently, I am blocked by #14362 to test this PR fully, because the mentions are not ready yet

What's exactly blocking this PR from being further reviewed/approved @VladimrLitvinenko? I'm not sure I understand the relationship between issue #14362 and this PR.

Currently, as a user, I am not able to mention other users in chats using @. It is described in #14362 in ISSUE 1. The relation between those PRs that in the current PR implemented notification that should be shown after some users are mentioned. Am I right?

It's a bit more complicated @VladimrLitvinenko. As I mentioned previously, I've created the issue #14501, which is related to how mentions will be displayed in the new Activity Center. The business rules are different, and some of them still need the blessing/review from designers. We're not quite ready to play that issue. I believe this will affect your testing processes meanwhile.

du82 · 2022-12-07T14:55:41Z

@ilmotta this is the bug I was referring to, sent the wrong screenshot before

ilmotta · 2022-12-07T17:29:34Z

@ilmotta thank you for making the activity element in AC so easy-to-find for automation! Can I ask you in the scope of changes to add accessibility-label to the close button in AC? I found a workaround, but the XPath for this element doesn't look quite reliable.

Sure @churik, I just committed to add an accessibility label named close-activity-center in the button. Please, let me know if you have other unreliable selectors and I'll add the IDs in the code.

ilmotta · 2022-12-07T17:38:07Z

It's a bit more complicated @VladimrLitvinenko. As I mentioned previously, I've created the issue #14501, which is related to how mentions will be displayed in the new Activity Center. The business rules are different, and some of them still need the blessing/review from designers. We're not quite ready to play that issue. I believe this will affect your testing processes meanwhile.

From this comment and #14501 and from the fact that users just cannot send mentions for now due to #14362 does it make sense to reduce testing scope here only basic flow for contact request? I just see no way to send any type of mention now, including mentions in communities and mentions in group chats (perhaps we can from IOS, but not quite sure)

👍 I think your suggestion is the most sensible @churik. According to the new rules (yet to be set in stone), it could well be the case that mention notifications won't be generated in a way that's very testable (e.g. mentions could be aggregated for a certain amount of time to avoid spamming the user with too many in a short period of time).

status-im-auto · 2022-12-08T11:09:46Z

100% of end-end tests have passed

Total executed tests: 8
Failed tests: 0
Passed tests: 8

Passed tests (8)

Click to expand

Class TestDeeplinkOneDeviceNewUI:

1. test_deep_link_open_user_profile, id: 702775
Device sessions Device 1: Steps, video, logs
2. test_public_chat_open_using_deep_link, id: 702776
Device sessions Device 1: Steps, video, logs
3. test_deep_link_with_invalid_user_public_key_own_profile_key, id: 702774
Device sessions Device 1: Steps, video, logs

Class TestGroupChatMediumMultipleDeviceNewUI:

1. test_group_chat_pin_messages, id: 702732
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_text_message_delete_push_disappear, id: 702733
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_1_1_chat_message_reaction, id: 702730
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_1_1_chat_pin_messages, id: 702731
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

churik · 2022-12-08T11:11:37Z

Tests are fixed in #14506
Just tell me when PR can be retested, no blockers from the automation side anymore.

ilmotta · 2022-12-08T11:22:35Z

Tests are fixed in #14506 Just tell me when PR can be retested, no blockers from the automation side anymore.

That's great news @churik! Thank you.

This PR will receive a fix when I find out why a RN function is undefined after the app is released (error popup #14492 (comment))

I'll request your reviews again once I find the fix.

ilmotta · 2022-12-08T21:34:08Z

FYI: @VladimrLitvinenko, @churik, @Du64

I just pushed two fixes. Please, let me know if we're good to go and I'll merge into develop.

Switching tabs no longer shows an error popup.
When light mode is enabled, the notification "context tags" section displays the correct color.

VolodLytvynenko · 2022-12-09T09:01:40Z

FYI: @VladimrLitvinenko, @churik, @Du64

I just pushed two fixes. Please, let me know if we're good to go and I'll merge into develop.

Switching tabs no longer shows an error popup.

When light mode is enabled, the notification "context tags" section displays the correct color.

@ilmotta thank you for your work. Soon it'll be tested

status-im-auto · 2022-12-09T11:34:20Z

100% of end-end tests have passed

Total executed tests: 8
Failed tests: 0
Passed tests: 8
Not executed tests: 2

IDs of not executed tests: 702807,702808

Not executed tests (2)

Click to expand

Rerun not executed tests

Passed tests (8)

Click to expand

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_pin_messages, id: 702731
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_1_1_chat_message_reaction, id: 702730
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_1_1_chat_text_message_delete_push_disappear, id: 702733
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestDeeplinkOneDeviceNewUI:

1. test_deep_link_with_invalid_user_public_key_own_profile_key, id: 702774
Device sessions Device 1: Steps, video, logs
2. test_public_chat_open_using_deep_link, id: 702776
Device sessions Device 1: Steps, video, logs
3. test_deep_link_open_user_profile, id: 702775
Device sessions Device 1: Steps, video, logs

Class TestGroupChatMediumMultipleDeviceNewUI:

1. test_group_chat_pin_messages, id: 702732
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

VolodLytvynenko · 2022-12-09T12:21:31Z

@ilmotta testing for PR is passed and ready to be merged. Thank you!

ilmotta · 2022-12-09T12:23:59Z

@ilmotta testing for PR is passed and ready to be merged. Thank you!

ilmotta added request-manual-qa activity-center labels Dec 5, 2022

ilmotta requested a review from flexsurfer December 5, 2022 12:58

ilmotta self-assigned this Dec 5, 2022

flexsurfer approved these changes Dec 5, 2022

View reviewed changes

J-Son89 approved these changes Dec 5, 2022

View reviewed changes

VolodLytvynenko self-assigned this Dec 6, 2022

ilmotta force-pushed the feat/enable-new-activity-center-by-default branch from f077ab6 to 4a3f3aa Compare December 8, 2022 21:29

status-im deleted a comment from status-im-auto Dec 9, 2022

VolodLytvynenko added Tested - OK and removed request-manual-qa labels Dec 9, 2022

ilmotta added 4 commits December 9, 2022 09:24

Set Activity Center as the new default

0db6916

Add accessibility label

8897a3a

Fix incorrect color in light mode

98404a5

Fix compilation inconsistency due to lack of type hint

9c31dd1

ilmotta force-pushed the feat/enable-new-activity-center-by-default branch from 4a3f3aa to 9c31dd1 Compare December 9, 2022 12:24

ilmotta merged commit ae10908 into develop Dec 9, 2022

ilmotta deleted the feat/enable-new-activity-center-by-default branch December 9, 2022 12:52

cammellos pushed a commit that referenced this pull request Dec 12, 2022

Set Activity Center as the new default (#14492)

a008e82

pavloburykh mentioned this pull request Dec 13, 2022

"scrollTolndex should be used in conjuction with getItemLayout..." error after switching filters and reopening AC (IOS only) #14532

Closed

churik mentioned this pull request Dec 14, 2022

Cannot use "Chat" button on another user profile until accepting contact request #14541

Closed

Set Activity Center as the new default #14492

Set Activity Center as the new default #14492

Conversation

ilmotta commented Dec 5, 2022 • edited Loading

Summary

Why?

Platforms

Steps to test

Note for QA review

status-im-auto commented Dec 5, 2022 • edited Loading

Jenkins Builds

status-im-auto commented Dec 6, 2022

0% of end-end tests have passed

Not executed tests (3)

Failed tests (4)

Class TestOneToOneChatMultipleSharedDevicesNewUi:

status-im-auto commented Dec 6, 2022

0% of end-end tests have passed

Failed tests (4)

Class TestOneToOneChatMultipleSharedDevicesNewUi:

VolodLytvynenko commented Dec 6, 2022

ilmotta commented Dec 6, 2022 • edited Loading

VolodLytvynenko commented Dec 7, 2022

VolodLytvynenko commented Dec 7, 2022

ilmotta commented Dec 7, 2022

VolodLytvynenko commented Dec 7, 2022

ilmotta commented Dec 7, 2022

ilmotta commented Dec 7, 2022

du82 commented Dec 7, 2022

du82 commented Dec 7, 2022

VolodLytvynenko commented Dec 7, 2022 • edited Loading

VolodLytvynenko commented Dec 7, 2022

ilmotta commented Dec 7, 2022

ilmotta commented Dec 7, 2022

ilmotta commented Dec 7, 2022

du82 commented Dec 7, 2022

ilmotta commented Dec 7, 2022

ilmotta commented Dec 7, 2022 • edited Loading

status-im-auto commented Dec 8, 2022

100% of end-end tests have passed

Passed tests (8)

Class TestDeeplinkOneDeviceNewUI:

Class TestGroupChatMediumMultipleDeviceNewUI:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

churik commented Dec 8, 2022

ilmotta commented Dec 8, 2022 • edited Loading

ilmotta commented Dec 8, 2022

VolodLytvynenko commented Dec 9, 2022 • edited Loading

status-im-auto commented Dec 9, 2022

100% of end-end tests have passed

Not executed tests (2)

Passed tests (8)

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestDeeplinkOneDeviceNewUI:

Class TestGroupChatMediumMultipleDeviceNewUI:

VolodLytvynenko commented Dec 9, 2022

ilmotta commented Dec 9, 2022

ilmotta commented Dec 5, 2022 •

edited

Loading

status-im-auto commented Dec 5, 2022 •

edited

Loading

ilmotta commented Dec 6, 2022 •

edited

Loading

VolodLytvynenko commented Dec 7, 2022 •

edited

Loading

ilmotta commented Dec 7, 2022 •

edited

Loading

ilmotta commented Dec 8, 2022 •

edited

Loading

VolodLytvynenko commented Dec 9, 2022 •

edited

Loading