feat: add C implementation for `math/base/special/gamma-lanczos-sum-expg-scaled` #1836

gunjjoshi · 2024-03-11T21:18:10Z

Resolves #1835

Description

What is the purpose of this pull request?

This pull request:

adds C implementation for math/base/special/gamma-lanczos-sum-expg-scaled.

Related Issues

Does this pull request have any related issues?

This pull request:

resolves a part of [RFC]: Add C implementations to base special math functions (tracking issue) #649
fixes [RFC]: add C implementation for @stdlib/math/base/special/gamma-lanczos-sum-expg-scaled #1835

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

☑️ Read, understood, and followed the contributing guidelines.

@stdlib-js/reviewers

…pg-scaled

Signed-off-by: GUNJ JOSHI <gunjjoshi8372@gmail.com>

kgryte · 2024-03-11T22:54:03Z

lib/node_modules/@stdlib/math/base/special/gamma-lanczos-sum-expg-scaled/src/main.c

+	} else {
+		ax = x;
+	}
+	if ( ax <= 1.0 ) {


Same comment as in #1834 (comment)

If the issue is L58, we should update evalrational-compile-c to handle infinities.

Thanks for these suggestions. Once we are done with the PR for gamma-lanczos-sum, then I will make changes according to that here, so that things aren't repetitive.

Closes: #860 PR-URL: #1833 Co-authored-by: Athan Reines <kgryte@gmail.com> Reviewed-by: Athan Reines <kgryte@gmail.com> Signed-off-by: Snehil Shah <130062020+Snehil-Shah@users.noreply.github.com> Signed-off-by: Athan Reines <kgryte@gmail.com>

PR-URL: #1829 Closes: #1828

PR-URL: #1788 Closes: #41 --------- Signed-off-by: Sai Srikar Dumpeti <80447788+the-r3aper7@users.noreply.github.com> Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com> Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com> Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>

PR-URL: #1754 Closes: #1642 --------- Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com> Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com> Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>

PR-URL: #1717 --------- Signed-off-by: Pranav <85227306+Pranavchiku@users.noreply.github.com> Signed-off-by: Athan Reines <kgryte@gmail.com> Co-authored-by: Pranav <85227306+Pranavchiku@users.noreply.github.com> Co-authored-by: Athan Reines <kgryte@gmail.com> Reviewed-by: Pranav <85227306+Pranavchiku@users.noreply.github.com> Reviewed-by: Athan Reines <kgryte@gmail.com> Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>

PR-URL: #1774 Closes: #1637 --------- Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com> Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com> Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>

PR-URL: #1837 Signed-off-by: stdlib-bot <82920195+stdlib-bot@users.noreply.github.com> Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com> Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>

PR-URL: #1838 Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>

PR-URL: #1841 Closes: #649 --------- Signed-off-by: GUNJ JOSHI <gunjjoshi8372@gmail.com> Signed-off-by: Pranav <85227306+Pranavchiku@users.noreply.github.com> Co-authored-by: Pranav <85227306+Pranavchiku@users.noreply.github.com> Reviewed-by: Pranav <85227306+Pranavchiku@users.noreply.github.com>

PR-URL: #1840 Closes: #1420 --------- Signed-off-by: Rejoan Sardar <119718513+Rejoan-Sardar@users.noreply.github.com> Signed-off-by: Pranav <85227306+Pranavchiku@users.noreply.github.com> Co-authored-by: Pranav <85227306+Pranavchiku@users.noreply.github.com> Reviewed-by: Pranav <85227306+Pranavchiku@users.noreply.github.com> Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>

PR-URL: #1827 Closes: #1815 --------- Signed-off-by: Rutam <138517416+performant23@users.noreply.github.com> Signed-off-by: Pranav <85227306+Pranavchiku@users.noreply.github.com> Co-authored-by: Pranav <85227306+Pranavchiku@users.noreply.github.com> Reviewed-by: Pranav <85227306+Pranavchiku@users.noreply.github.com> Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>

PR-URL: #1786 Closes: #39 --------- Signed-off-by: Sai Srikar Dumpeti <80447788+the-r3aper7@users.noreply.github.com> Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com> Co-authored-by: stdlib-bot <82920195+stdlib-bot@users.noreply.github.com> Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com> Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>

PR-URL: #1785 Closes: #43 --------- Signed-off-by: Sai Srikar Dumpeti <80447788+the-r3aper7@users.noreply.github.com> Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com> Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com> Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>

PR-URL: #1789 Closes: #42 --------- Signed-off-by: Sai Srikar Dumpeti <80447788+the-r3aper7@users.noreply.github.com> Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>

PR-URL: #1787 Closes: #38 --------- Signed-off-by: Sai Srikar Dumpeti <80447788+the-r3aper7@users.noreply.github.com> Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com> Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com> Co-authored-by: stdlib-bot <82920195+stdlib-bot@users.noreply.github.com> Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>

PR-URL: #1843 Reviewed-by: Athan Reines <kgryte@gmail.com> Signed-off-by: stdlib-bot <82920195+stdlib-bot@users.noreply.github.com> Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com>

PR-URL: #1834 Closes: #1822 Ref: #649 Co-authored-by: Athan Reines <kgryte@gmail.com> Reviewed-by: Athan Reines <kgryte@gmail.com>

…ventions PR-URL: #1864 Closes: #1516 Ref: #1152 Co-authored-by: Athan Reines <kgryte@gmail.com> Reviewed-by: Athan Reines <kgryte@gmail.com>

PR-URL: #1972 Signed-off-by: stdlib-bot <82920195+stdlib-bot@users.noreply.github.com> Co-authored-by: Athan Reines <kgryte@gmail.com> Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>

PR-URL: #1945 Closes: #1519 --------- Signed-off-by: Bryan Elee <rxbryn@gmail.com> Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com> Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>

…onventions PR-URL: #1929 Closes: #1520 --------- Signed-off-by: Pranav <85227306+Pranavchiku@users.noreply.github.com> Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com> Co-authored-by: Pranav <85227306+Pranavchiku@users.noreply.github.com> Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com> Reviewed-by: Pranav Goswami <goswami.4@iitj.ac.in> Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>

PR-URL: #1974 Signed-off-by: stdlib-bot <82920195+stdlib-bot@users.noreply.github.com> Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com> Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>

Ref: #1929

Ref: #1945 Ref: 548f903

Ref: #1861

…ntions PR-URL: #1954 Closes: #1464 Ref: #1152 Co-authored-by: Athan Reines <kgryte@gmail.com> Reviewed-by: Athan Reines <kgryte@gmail.com> Signed-off-by: Athan Reines <kgryte@gmail.com>

…nventions PR-URL: #1850 Closes: #1510 Ref: #1152 Co-authored-by: Athan Reines <kgryte@gmail.com> Co-authored-by: Pranav Goswami <goswami.4@iitj.ac.in> Reviewed-by: Athan Reines <kgryte@gmail.com> Reviewed-by: Pranav Goswami <goswami.4@iitj.ac.in> Signed-off-by: GUNJ JOSHI <gunjjoshi8372@gmail.com> Signed-off-by: Pranav Goswami <goswami.4@iitj.ac.in> Signed-off-by: Athan Reines <kgryte@gmail.com>

PR-URL: #1975 Co-authored-by: Athan Reines <kgryte@gmail.com> Reviewed-by: Athan Reines <kgryte@gmail.com> Signed-off-by: stdlib-bot <82920195+stdlib-bot@users.noreply.github.com>

PR-URL: #1973 Co-authored-by: Athan Reines <kgryte@gmail.com> Reviewed-by: Athan Reines <kgryte@gmail.com> Signed-off-by: stdlib-bot <82920195+stdlib-bot@users.noreply.github.com>

Ref: #1861

…ntions PR-URL: #1824 Closes: #1509 Ref: #1152 Co-authored-by: Athan Reines <kgryte@gmail.com> Reviewed-by: Athan Reines <kgryte@gmail.com> Signed-off-by: Athan Reines <kgryte@gmail.com>

PR-URL: #1976 Ref: #1953 Reviewed-by: Athan Reines <kgryte@gmail.com>

PR-URL: #1977 Co-authored-by: Athan Reines <kgryte@gmail.com> Reviewed-by: Athan Reines <kgryte@gmail.com> Signed-off-by: stdlib-bot <82920195+stdlib-bot@users.noreply.github.com>

This reverts commit dbfeea7.

gunjjoshi · 2024-03-21T12:50:31Z

I will be opening a new pull request for this one, everything is getting mixed up here. Closing this for now.

feat: add C implementation for math/base/special/gamma-lanczos-sum-ex…

8fca2ea

…pg-scaled

Planeshifter added Needs Review A pull request which needs code review. Native Addons Issue involves or relates to Node.js native add-ons. C Issue involves or relates to C. labels Mar 11, 2024

gunjjoshi added 4 commits March 12, 2024 02:49

Update README.md

3d4f2fd

Signed-off-by: GUNJ JOSHI <gunjjoshi8372@gmail.com>

Update benchmark.native.js

2e58ac8

Signed-off-by: GUNJ JOSHI <gunjjoshi8372@gmail.com>

Update main.c

fea9971

Signed-off-by: GUNJ JOSHI <gunjjoshi8372@gmail.com>

Update test.native.js

dbfeea7

Signed-off-by: GUNJ JOSHI <gunjjoshi8372@gmail.com>

kgryte added Feature Issue or pull request for adding a new feature. Math Issue or pull request specific to math functionality. labels Mar 11, 2024

kgryte reviewed Mar 11, 2024

View reviewed changes

Pranavchiku added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Mar 12, 2024

Snehil-Shah and others added 17 commits March 21, 2024 15:50

feat: add math/base/assert/is-nonnegative-finite

5496499

PR-URL: #1829 Closes: #1828

build: run C benchmarks in CI workflow

e3e0f7d

docs: improve README examples for stats/base/dists/rayleigh namespace

89e11db

PR-URL: #1754 Closes: #1642 --------- Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com> Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com> Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>

docs: improve README examples of stats/base/dists/negative-binomial

51679a6

PR-URL: #1774 Closes: #1637 --------- Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com> Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com> Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>

docs: update list of contributors

88d6e8c

PR-URL: #1837 Signed-off-by: stdlib-bot <82920195+stdlib-bot@users.noreply.github.com> Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com> Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>

docs: update related packages sections

7666cf5

PR-URL: #1838 Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>

feat: add math/base/special/acscd

65f9f74

PR-URL: #1789 Closes: #42 --------- Signed-off-by: Sai Srikar Dumpeti <80447788+the-r3aper7@users.noreply.github.com> Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>

docs: update REPL namespace documentation

1462ad1

PR-URL: #1843 Reviewed-by: Athan Reines <kgryte@gmail.com> Signed-off-by: stdlib-bot <82920195+stdlib-bot@users.noreply.github.com> Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com>

gunjjoshi and others added 25 commits March 21, 2024 15:50

feat: add C implementation for math/base/special/gamma-lanczos-sum

94ab2a2

PR-URL: #1834 Closes: #1822 Ref: #649 Co-authored-by: Athan Reines <kgryte@gmail.com> Reviewed-by: Athan Reines <kgryte@gmail.com>

refactor: update blas/ext/base/scusum to follow current project con…

8470eb0

…ventions PR-URL: #1864 Closes: #1516 Ref: #1152 Co-authored-by: Athan Reines <kgryte@gmail.com> Reviewed-by: Athan Reines <kgryte@gmail.com>

docs: update REPL namespace documentation

82ddff4

PR-URL: #1972 Signed-off-by: stdlib-bot <82920195+stdlib-bot@users.noreply.github.com> Co-authored-by: Athan Reines <kgryte@gmail.com> Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>

refactor: update blas/ext/base/scusumors

7ca4c4c

PR-URL: #1945 Closes: #1519 --------- Signed-off-by: Bryan Elee <rxbryn@gmail.com> Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com> Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>

docs: update list of contributors

04e26c9

PR-URL: #1974 Signed-off-by: stdlib-bot <82920195+stdlib-bot@users.noreply.github.com> Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com> Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>

fix: update build configuration

376e743

Ref: #1929

fix: update build configuration

efea3bf

Ref: #1945 Ref: 548f903

fix: update build configuration and remove unnecessary cast

403d820

Ref: #1861

refactor: update blas/ext/base/dapx to follow current project conve…

b5ae04a

…ntions PR-URL: #1954 Closes: #1464 Ref: #1152 Co-authored-by: Athan Reines <kgryte@gmail.com> Reviewed-by: Athan Reines <kgryte@gmail.com> Signed-off-by: Athan Reines <kgryte@gmail.com>

docs: update namespace TypeScript declarations

52ab774

PR-URL: #1975 Co-authored-by: Athan Reines <kgryte@gmail.com> Reviewed-by: Athan Reines <kgryte@gmail.com> Signed-off-by: stdlib-bot <82920195+stdlib-bot@users.noreply.github.com>

docs: update REPL namespace documentation

b0c96c9

PR-URL: #1973 Co-authored-by: Athan Reines <kgryte@gmail.com> Reviewed-by: Athan Reines <kgryte@gmail.com> Signed-off-by: stdlib-bot <82920195+stdlib-bot@users.noreply.github.com>

style: fix indentation

407b4d0

Ref: #1861

fix: remove trailing commas

c21a718

fix: use correct variable names and fix configuration file

f4e9f11

refactor: remove explicit cast

4623e89

refactor: remove explicit cast

ccab848

refactor: remove explicit cast

cda3983

refactor: update blas/ext/base/sapx to follow current project conve…

920d8db

…ntions PR-URL: #1824 Closes: #1509 Ref: #1152 Co-authored-by: Athan Reines <kgryte@gmail.com> Reviewed-by: Athan Reines <kgryte@gmail.com> Signed-off-by: Athan Reines <kgryte@gmail.com>

fix: rename include directory for constants/float32/half-pi

6e9fae3

PR-URL: #1976 Ref: #1953 Reviewed-by: Athan Reines <kgryte@gmail.com>

docs: update REPL namespace documentation

78242e1

PR-URL: #1977 Co-authored-by: Athan Reines <kgryte@gmail.com> Reviewed-by: Athan Reines <kgryte@gmail.com> Signed-off-by: stdlib-bot <82920195+stdlib-bot@users.noreply.github.com>

feat: add C implementation for gamma-lanczos-sum-expg-scaled

3fc4974

feat: add C implementation for gamma-lanczos-sum-expg-scaled

e49bb9d

Revert "Update test.native.js"

d537af9

This reverts commit dbfeea7.

gunjjoshi closed this Mar 21, 2024

gunjjoshi deleted the gamma-lanczos-sum-expg-scaled branch March 21, 2024 12:50

gunjjoshi restored the gamma-lanczos-sum-expg-scaled branch March 21, 2024 12:50

gunjjoshi deleted the gamma-lanczos-sum-expg-scaled branch March 21, 2024 16:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add C implementation for `math/base/special/gamma-lanczos-sum-expg-scaled` #1836

feat: add C implementation for `math/base/special/gamma-lanczos-sum-expg-scaled` #1836

gunjjoshi commented Mar 11, 2024 •

edited

Loading

kgryte Mar 11, 2024

kgryte Mar 11, 2024

gunjjoshi Mar 12, 2024

gunjjoshi commented Mar 21, 2024

feat: add C implementation for math/base/special/gamma-lanczos-sum-expg-scaled #1836

feat: add C implementation for math/base/special/gamma-lanczos-sum-expg-scaled #1836

Conversation

gunjjoshi commented Mar 11, 2024 • edited Loading

Description

Related Issues

Questions

Other

Checklist

kgryte Mar 11, 2024

Choose a reason for hiding this comment

kgryte Mar 11, 2024

Choose a reason for hiding this comment

gunjjoshi Mar 12, 2024

Choose a reason for hiding this comment

gunjjoshi commented Mar 21, 2024

feat: add C implementation for `math/base/special/gamma-lanczos-sum-expg-scaled` #1836

feat: add C implementation for `math/base/special/gamma-lanczos-sum-expg-scaled` #1836

gunjjoshi commented Mar 11, 2024 •

edited

Loading