Log retried errors #2613
Merged
Log retried errors #2613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for testcontainers-go ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
ash2k
commented
Jun 29, 2024
ash2k
commented
Jun 29, 2024
ash2k
force-pushed
the
log-retriable-errors
branch
from
5e02f4e
to
988d165
Compare
ash2k
commented
Jun 29, 2024
|
Could you please update this PR with the changes in #2606 🙏 Thanks! |
ash2k
force-pushed
the
log-retriable-errors
branch
from
988d165
to
e00d678
Compare
|
Rebased |
|
Tests are failing with: |
I'm sorry but I do not see the changes for the lifecycle.go function, adding a retry for checking all exposed ports are already available. |
|
Hm, I've just checked and I think all commits are there:
Am I missing something? |
|
Oh sorry, I probably did not explain myself very well. I asked you to check (and update if neeeded) the retry added in #2606, to include the RetryNotify pattern this PR introduces 🙏 |
ash2k
force-pushed
the
log-retriable-errors
branch
from
e00d678
to
0bedcc0
Compare
|
Ah, ok. Done! |
ash2k
force-pushed
the
log-retriable-errors
branch
from
0bedcc0
to
e6538c7
Compare
mdelapenya
reviewed
Jul 3, 2024
mdelapenya
reviewed
Jul 3, 2024
mdelapenya
reviewed
Jul 3, 2024
ash2k
force-pushed
the
log-retriable-errors
branch
from
e6538c7
to
a400ba8
Compare
mdelapenya
added a commit
that referenced
this pull request
Jul 15, 2024
* main: fix: log output after context timeout (#2643) chore(deps): use "github.com/containerd/platforms" instead (#2638) chore(deps): bump google.golang.org/grpc to 1.64.1 (#2635) chore(deps): bump certifi from 2024.2.2 to 2024.7.4 (#2631) chore: prepare for next minor development cycle (0.33.0) chore: use new version (v0.32.0) in modules and examples feat: honour go toolchain's verbose flag to print out logs (#2624) Fix issues in BuildImage() (#2626) docs: indicate version for the Run function (#2627) chore: remove duplicated tests for config (#2628) Log retried errors (#2613)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add logging of errors that are retried.
Why is it important?
I want to see any unexpected errors when they happen. Otherwise nothing is logged and the test appears to be stuck forever.
Related issues