Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): use "github.com/containerd/platforms" instead #2638

Merged

Conversation

mdelapenya
Copy link
Member

  • chore: use "github.com/containerd/platforms" in core
  • chore: run mod tidy

What does this PR do?

This PR uses "github.com/containerd/platforms" as dependency instead of "github.com/containerd/containerd"

Why is it important?

It will reduce the dependencies surface, removing "github.com/Microsoft/hcsshim", among others, from the dependencies.

Related issues

@mdelapenya mdelapenya requested a review from a team as a code owner July 11, 2024 11:59
@mdelapenya mdelapenya added the dependencies Dependencies or external services label Jul 11, 2024
@mdelapenya mdelapenya self-assigned this Jul 11, 2024
Copy link

netlify bot commented Jul 11, 2024

Deploy Preview for testcontainers-go ready!

Name Link
🔨 Latest commit dc70f3d
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-go/deploys/668fc90e48ace30008f0c2f0
😎 Deploy Preview https://deploy-preview-2638--testcontainers-go.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mdelapenya
Copy link
Member Author

@thaJeztah changed as you suggested, thank you for the suggestion! 🙇

Copy link
Contributor

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (if CI is happy 😊)

@mdelapenya mdelapenya merged commit 53b0ddf into testcontainers:main Jul 11, 2024
108 checks passed
@mdelapenya mdelapenya deleted the containerd-platform-package branch July 15, 2024 07:30
mdelapenya added a commit that referenced this pull request Jul 15, 2024
* main:
  fix: log output after context timeout (#2643)
  chore(deps): use "github.com/containerd/platforms" instead (#2638)
  chore(deps): bump google.golang.org/grpc to 1.64.1 (#2635)
  chore(deps): bump certifi from 2024.2.2 to 2024.7.4 (#2631)
  chore: prepare for next minor development cycle (0.33.0)
  chore: use new version (v0.32.0) in modules and examples
  feat: honour go toolchain's verbose flag to print out logs (#2624)
  Fix issues in BuildImage() (#2626)
  docs: indicate version for the Run function (#2627)
  chore: remove duplicated tests for config (#2628)
  Log retried errors (#2613)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Dependencies or external services
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants