Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: log output after context timeout #2643

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

stevenh
Copy link
Collaborator

@stevenh stevenh commented Jul 14, 2024

Still try to output the logs when the error which triggered is due to context timeout so that the user has a better chance to debug the issue.

@stevenh stevenh requested a review from a team as a code owner July 14, 2024 10:38
Copy link

netlify bot commented Jul 14, 2024

Deploy Preview for testcontainers-go ready!

Name Link
🔨 Latest commit 0e3ca69
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-go/deploys/6693aad1f290f00008c30af4
😎 Deploy Preview https://deploy-preview-2643--testcontainers-go.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Still try to output the logs when the error which triggered is due
to context timeout so that the user has a better chance to debug the
issue.
@stevenh stevenh changed the title fix: log out after context timeout fix: log output after context timeout Jul 14, 2024
@stevenh
Copy link
Collaborator Author

stevenh commented Jul 14, 2024

CI failures are unrelated

@mdelapenya mdelapenya self-assigned this Jul 15, 2024
@mdelapenya mdelapenya added the bug An issue with the library label Jul 15, 2024
Copy link
Member

@mdelapenya mdelapenya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mdelapenya mdelapenya merged commit eb22239 into testcontainers:main Jul 15, 2024
108 checks passed
@stevenh stevenh deleted the fix/log-timeout branch July 15, 2024 09:25
mdelapenya added a commit that referenced this pull request Jul 15, 2024
* main:
  fix: log output after context timeout (#2643)
  chore(deps): use "github.com/containerd/platforms" instead (#2638)
  chore(deps): bump google.golang.org/grpc to 1.64.1 (#2635)
  chore(deps): bump certifi from 2024.2.2 to 2024.7.4 (#2631)
  chore: prepare for next minor development cycle (0.33.0)
  chore: use new version (v0.32.0) in modules and examples
  feat: honour go toolchain's verbose flag to print out logs (#2624)
  Fix issues in BuildImage() (#2626)
  docs: indicate version for the Run function (#2627)
  chore: remove duplicated tests for config (#2628)
  Log retried errors (#2613)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue with the library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants