Cory and Scott Submission #99
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created the PR template for the project.
Create pull_request_template.md
User Story 1
… The show page user story doesn't call for the email so I just removed it and removed the corresponding line in the test.
…g code in the view/show page
…ith a movies controller, a movies view folder, a movies index page, and routing for the discover page corresponding to a specific user.
…e annoying ones. Not gonna worry about it but just have this branch to practice
… was being clever doing a movies_controller, but I think the movies have to be a different thing and discover seems to be its own thing. So changed it to discover#index/controller.
Dashboard page
…to user_registration_page
User registration page
…to movie_results_page
…to discover-movies-page
Movie details 2
…_party_lite_7 into refactor
…ts show_spec to have a within block.
WOO! Got the coverage to remove off of github and we can merge without it yelling at us again!
…ing a jump on the stubs and mocks for testing
…tests to be more robust. Also changed some names of things to make more sense. All in all it feels really cleaned up
Hooray! We have working mock testing on everything made thus far!
…nd added some private methods in the controller for viewing_party. I remembered the before_action from the final mod 2 project so I'll probably try and implement that elsewhere if I can, but we'll see. Signing off for the night, but going to hit hard tomorrow and do everything I can before we submit
… adding simplecov again, but not sure how to get it to work again. Not a big deal, but was just curious.
…and viewing parties. Also tested the relationships and validations for them in the model tests
…to add other users. I think I know where to go with it next though.
…n viewing party. Also got the form to show users using an if each in the view that I think works? It passes in the test thus far, but the testing suite is taking 10 seconds to load each time so not sure what happened. I assume it's the new migrations but that seems strange as the new migrations are empty tables. Either way, it adds a lot of time to the testing process.
…l it to make the presentation video
Final one before submission! Whew.
…t'? Not sure. I think this works more correctly now. Not sure how it worked in the video but afterwards it stopped passing the movie_id correctly so I added a hidden field that has the movie_id.
Finally got the flash error to work in the controller, but switched to the user_viewing_parties_controller because it seems to be more RESTful to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is our submission PR. We were able to get to attempting the second to last user story creating a new viewing party, but did not finish all the testing to complete it.