Merging release 2.2.41 into master #1585

vrdmr · 2019-07-16T18:57:44Z

Description

Merging release 2.2.41 into master

PR information

The title of the PR is clear and informative.
There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
If applicable, the PR references the bug/issue that it fixes in the description.
New Unit tests were added for the changes made and Travis.CI is passing.

Quality of Code and Contribution Guidelines

I have read the contribution guidelines.

This change is

Merging Release 2.2.37 into develop

18.04 changed the method of managing resolv.conf vs. 16.04; the new method involves letting systemd-networkd manage that file. A previous fix corrected waagent behavior for 18.04 but did not do so for subsequent releases. Now that Ubuntu's direction is clear, this commit makes the correction in all versions of Ubuntu from 18.04 onwards. Other distros are unaffected by this bug and by this fix.

Updating Travis settings

* Added description for Extension Error Codes * Correcting the test - to send the correct CRP Extension Error code * Adding docstring to describe ExtensionErrorCodes

…is not Pkcs7BlobWithPfxContents (#1474) * Certificates parser gracefully exits if format of package is not Pkcs7BlobWithPfxContents * Add missing files * change message to warning

…re (#1481)

Release 2.2.38

* add fixes for cgroup setup and PID tracking * cleanup code comments * disable cgroups test if not supported by environment * remove wrapper cgroup tracking and other nits * fix whitespace * nit fixes; addressing CR comments

…s - when it was downloaded directly or through HostGA

* Suppress 'Errno 2' messages when deleting extensions * Added unit tests * Fixes for unit tests

…de; Also modified test to follow AAA pattern for unit-tests

…rotocol

Fix for sending wrong header to HostGA /extensionManifest calls

* Release 2.2.39 (#1494) * Fix header * Update agent version to 2.2.40

* API for extension cgroups * add systemd implemented methods for extensions * fix and improve tests * add comments * add daemon-reload after removing units * code refactoring * fix tests * change how we check systemd * fix updated check for systemd * fix systemd check again * update comment for systemd check * address most CR comments * add unit test for API resolution * address CR comments and add unit tests * revert is_systemd method

Also, added a test for empty_cgroup.

Changed the implementation and the unittests for the is_tracked check.

Also scope name is now not created in this PR

Bug fixes for duplicate copies and scope name

Exposed the cgroups.collect exceptions to distinguish difference between incorrect configuration and 0 value.

Revert "Rhel8 changes"

Preventing incorrect metrics to be sent on telemetry

Merge CGroups into Develop

* Preventing empty extensions to be sent into telemetry * nit; adding comment

* add failure checks for systemd-run * add unit tests * disable systemd-run tests if not root * refactor systemd-run check to use stdout/err instead of journalctl

* Prevent logging for ERRNO-2 cases

codecov · 2019-07-16T23:37:20Z

Codecov Report

Merging #1585 into master will increase coverage by 2.55%.
The diff coverage is 80.7%.

@@            Coverage Diff             @@
##           master    #1585      +/-   ##
==========================================
+ Coverage   60.82%   63.38%   +2.55%     
==========================================
  Files          75       78       +3     
  Lines       10878    11056     +178     
  Branches     1559     1559              
==========================================
+ Hits         6617     7008     +391     
+ Misses       3946     3709     -237     
- Partials      315      339      +24

Impacted Files	Coverage Δ
azurelinuxagent/common/exception.py	`91.35% <100%> (+0.33%)`	⬆️
azurelinuxagent/common/version.py	`68.96% <100%> (ø)`	⬆️
azurelinuxagent/common/utils/shellutil.py	`47.16% <100%> (ø)`	⬆️
azurelinuxagent/ga/update.py	`88.31% <100%> (+0.11%)`	⬆️
azurelinuxagent/daemon/main.py	`72.91% <100%> (ø)`	⬆️
azurelinuxagent/ga/exthandlers.py	`81.29% <100%> (+0.4%)`	⬆️
azurelinuxagent/common/utils/processutil.py	`100% <100%> (ø)`	⬆️
azurelinuxagent/common/event.py	`82.75% <100%> (+2.44%)`	⬆️
azurelinuxagent/common/logger.py	`88.59% <100%> (+1.18%)`	⬆️
azurelinuxagent/common/cgroupapi.py	`62.77% <62.77%> (ø)`
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d3757a...bc4b721. Read the comment docs.

vrdmr and others added 30 commits March 4, 2019 13:24

Merge pull request #1478 from Azure/release-2.2.37

4f7042a

Merging Release 2.2.37 into develop

Updating Travis settings

52a3ec0

Merge pull request #1480 from vrdmr/vameru/travis-update

c9699c6

Updating Travis settings

Added description for Extension Error Codes (#1482)

5fe89a8

* Added description for Extension Error Codes * Correcting the test - to send the correct CRP Extension Error code * Adding docstring to describe ExtensionErrorCodes

Make launch_command resilient to cgroups failures (#1484)

eac8f39

WireServer Certificates parser gracefully exits if format of package …

ec51856

…is not Pkcs7BlobWithPfxContents (#1474) * Certificates parser gracefully exits if format of package is not Pkcs7BlobWithPfxContents * Add missing files * change message to warning

Removing the requirement of passing cipher-name. Default is more secu…

3f83843

…re (#1481)

Merge pull request #1490 from Azure/release-2.2.38

ca1d395

Release 2.2.38

Fix PID tracking for cgroups (#1489)

ff01b37

* add fixes for cgroup setup and PID tracking * cleanup code comments * disable cgroups test if not supported by environment * remove wrapper cgroup tracking and other nits * fix whitespace * nit fixes; addressing CR comments

Do not report restart_if warnings as errors (#1498)

4c7c892

Setting the host.manifest_uri even if it was not downloaded using host

5f310b5

Added a unit test to check if the manifest is being set for both case…

4f368b6

…s - when it was downloaded directly or through HostGA

Suppress 'Errno 2' messages when deleting extensions (#1504)

2dc43ce

* Suppress 'Errno 2' messages when deleting extensions * Added unit tests * Fixes for unit tests

Test code cleanup

a8e6589

Removed unusable comments for a cleaner code

1daa2b9

Modified unit test to follow AAA pattern

0d52a7d

Addressed PR comments, added comments to the tests and cleaned the co…

6756a30

…de; Also modified test to follow AAA pattern for unit-tests

verbose test comments

e1332c8

Mocking the return call of mock_host instead of the whole HostPluginP…

840c0ba

…rotocol

Merge pull request #1510 from larohra/nsg_dcr_hostga_issue

cc648d5

Fix for sending wrong header to HostGA /extensionManifest calls

Release 2.2.40 (#1516)

de02445

* Release 2.2.39 (#1494) * Fix header * Update agent version to 2.2.40

Split cgroups.py into smaller files and rename classes. (#1524)

df97eec

Add logging for cert management

830c422

Defined API for initialization of cgroups (#1530)

ab8f394

API for extension cgroups (#1533)

8d02446

Do not test Python nightly (#1535)

8309d14

Refactor start_extension_command to CGroupsApi (#1534)

8e537f5

Refactor configurator (#1537)

4da18d3

vrdmr and others added 24 commits June 11, 2019 09:39

Prevent adding duplicates in _tracked data structure.

a780d28

Change the scope name to have the .scope suffix

0767eb9

Also, added a test for empty_cgroup.

nit fixes; correcting the systemd filename and other unittest fixes.

5d628b0

is_tracked check only with path now.

909de2c

Changed the implementation and the unittests for the is_tracked check.

Fix the test_monitor unittest

994eb17

Rebased on cgroups, and fixed unittests.

74bd5f7

Also scope name is now not created in this PR

Review comments addressed.

8194f84

Merge pull request #1548 from vrdmr/vameru/cgroups-bug-fixes

d12a03a

Bug fixes for duplicate copies and scope name

Merge remote-tracking branch 'upstream/cgroups' into cgroups

51471d4

Preventing incorrect metrics to be sent on telemetry

ee8a741

Exposed the cgroups.collect exceptions to distinguish difference between incorrect configuration and 0 value.

Fixing the unittests

52a5994

Review comments addressed

bb622b1

Addressing review comments; periodic logger expanded

113fc1b

Refactored periodic logger, and other review comments addressed

aae9fc9

Revert "Rhel8 changes"

f2b7888

Merge pull request #1554 from Azure/revert-1547-Rhel8Changes

3323a88

Revert "Rhel8 changes"

Simplifying periodic_* interfaces

338adc0

Merge pull request #1553 from vrdmr/vameru/remove-empty-perf-metrics

ab9cffe

Preventing incorrect metrics to be sent on telemetry

Merge pull request #1555 from Azure/cgroups

3816e53

Merge CGroups into Develop

Preventing empty extensions to be sent into telemetry (#1557)

1e7e63b

* Preventing empty extensions to be sent into telemetry * nit; adding comment

Handle systemd failures when invoking extensions (#1556)

9aae8a0

* add failure checks for systemd-run * add unit tests * disable systemd-run tests if not root * refactor systemd-run check to use stdout/err instead of journalctl

Prevents over-logging in known cases. (#1558)

8761775

* Prevent logging for ERRNO-2 cases

Version update for release 2.2.41

0f1f1cf

Merging release 2.2.41 into master

94e873f

vrdmr requested a review from narrieta July 16, 2019 18:57

vrdmr mentioned this pull request Jul 16, 2019

Merge release 2.2.41 to master #1582

Closed

6 tasks

Fixing the LaunchCommandTestCase

bc4b721

narrieta approved these changes Jul 17, 2019

View reviewed changes

vrdmr merged commit a0bb361 into Azure:master Jul 17, 2019

This pull request was closed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Merging release 2.2.41 into master #1585

Merging release 2.2.41 into master #1585

vrdmr commented Jul 16, 2019 •

edited

Loading

codecov bot commented Jul 16, 2019 •

edited

Loading

Merging release 2.2.41 into master #1585

Merging release 2.2.41 into master #1585

Conversation

vrdmr commented Jul 16, 2019 • edited Loading

Description

PR information

Quality of Code and Contribution Guidelines

codecov bot commented Jul 16, 2019 • edited Loading

Codecov Report

vrdmr commented Jul 16, 2019 •

edited

Loading

codecov bot commented Jul 16, 2019 •

edited

Loading