Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed 'show ip route' command: ipv6 -> ipv4. #179

Open
wants to merge 22 commits into
base: 201709
Choose a base branch
from
Open

Fixed 'show ip route' command: ipv6 -> ipv4. #179

wants to merge 22 commits into from

Conversation

nazarii-gnydyn
Copy link

- What I did
Fixed 'show ip route' command: ipv6 -> ipv4.

- How I did it

@ip.command()
@click.argument('ipaddress', required=False)
def route(ipaddress):
    """Show IPv6 routing table"""

@ipv6.command()
@click.argument('ipaddress', required=False)
def route(ipaddress):
    """Show IPv6 routing table"""

- How to verify it

admin@sonic:~$ show ip route
Command: sudo vtysh -c "show ip route"
Codes: K - kernel route, C - connected, S - static, R - RIP,
       O - OSPF, I - IS-IS, B - BGP, P - PIM, A - Babel,
       > - selected route, * - FIB route

K>* 0.0.0.0/0 via 10.7.0.1, eth0
C>* 10.1.1.0/24 is directly connected, Ethernet101
C>* 10.2.2.0/24 is directly connected, Ethernet102
C>* 10.3.3.0/24 is directly connected, Ethernet103
C>* 10.4.4.0/24 is directly connected, Ethernet104
C>* 10.7.0.0/22 is directly connected, eth0
C>* 101.101.101.0/24 is directly connected, lo
C>* 127.0.0.0/8 is directly connected, lo
C>* 240.127.1.0/24 is directly connected, docker0

- Previous command output (if the output of a command-line utility has changed)

admin@sonic:~$ show ip route
Command: sudo vtysh -c "show ipv6 route"
Codes: K - kernel route, C - connected, S - static, R - RIPng,
       O - OSPFv6, I - IS-IS, B - BGP, A - Babel,
       > - selected route, * - FIB route

C>* ::1/128 is directly connected, lo
C * fe80::/64 is directly connected, Ethernet101
C * fe80::/64 is directly connected, Ethernet103
C * fe80::/64 is directly connected, Ethernet102
C * fe80::/64 is directly connected, Ethernet104
C>* fe80::/64 is directly connected, eth0

- New command output (if the output of a command-line utility has changed)

admin@sonic:~$ show ip route
Command: sudo vtysh -c "show ip route"
Codes: K - kernel route, C - connected, S - static, R - RIP,
       O - OSPF, I - IS-IS, B - BGP, P - PIM, A - Babel,
       > - selected route, * - FIB route

K>* 0.0.0.0/0 via 10.7.0.1, eth0
C>* 10.1.1.0/24 is directly connected, Ethernet101
C>* 10.2.2.0/24 is directly connected, Ethernet102
C>* 10.3.3.0/24 is directly connected, Ethernet103
C>* 10.4.4.0/24 is directly connected, Ethernet104
C>* 10.7.0.0/22 is directly connected, eth0
C>* 101.101.101.0/24 is directly connected, lo
C>* 127.0.0.0/8 is directly connected, lo
C>* 240.127.1.0/24 is directly connected, docker0

pavel-shirshov and others added 22 commits August 14, 2017 15:45
@pavel-shirshov
[FastReboot]: Update FR to make it working with 1.0.3 (sonic-net#95)
51fc8ee 
* Update FR to make it working with 1.0.3
Merge remote-tracking branch 'origin/v1.0.3'
a7be3b7
@taoyl-ms
Adapt to new minigraph_parser schema (sonic-net#103)
b48573f
@lguohan
Added syncd SAI dump to sysdump script (sonic-net#89)
85dd072
[generate_dump]: Skip the sparse file /var/log/lastlog (sonic-net#104)
cdf2fe6 
This sparse file is HUGE and without ignoring this file, it will take
forever to gzip this file and ultimately causing the script to hang.
@jleveque
Add 'ipv6' group along with 'bgp' and 'route' subcommands; Remove dup…
0338eee 
…licate commands ('bgp,' 'route') from under root group (sonic-net#102)
@jleveque @lguohan
[show]: Add 'show interfaces alias' command to display port name/alia…
70422b5 
…s mapping (sonic-net#107)
@prsunny
CLI support for Layer 2 MAC/FDB show (sonic-net#106)
206aabe 
* CLI support to show MAC/FDB entries learnt in Hardware
* Updated to use common library API to get bridge port mapping
* Rearranged imports
* Addressed review comments, check-logic modified
* Show command hookup added
Fixed parser logic to handle non mandatory TLV.
4b036b9
@samaity @jleveque
Enhancement of 'show' commands and addition of 'debug', and 'undebug'… (
63f05ad 
sonic-net#113)

- added script to get interface status.
- added few subcommands under "show interfaces" command.
- enhanced "show process" to get all processes sorted by CPU & memory.
- added "show services" command to get all the running process from all the dockers.
- added "show vlan" command.
- enhanced multiple subcommands under
- added debug', and 'undebug' CLI utilities.
@taoyl-ms
Flush DB first when loading from minigraph (sonic-net#114)
b27d4f9 
* Flush DB first when loading from minigraph and add a config reload command to flush db and reload from json.
@jleveque
Reorder dependencies to fix wheel build (sonic-net#117)
2c63a41
@jleveque
[show]: Fix improper indents (sonic-net#119)
ddadc2b
[lldpshow]: Fixed parser logic to handle non mandatory TLV (sonic-net…
635735d 
…#110)
@jleveque
[show]: Remove default commands; add missing docstrings (sonic-net#121)
52dd13e 
* [show]: Remove default groups; add missing docstrings

* Copy all bash completion files by glob
@taoyl-ms
[config load_mgmt_config] add default route (sonic-net#123)
2dab9da
@taoyl-ms
[sonic-installer] Fix an issue that old config is not preserved in ab…
3a40ff9 
…oot image upgrade (sonic-net#122)
@jleveque
Remove explicit dependency on swsssdk (sonic-net#124)
77c9f81
Merge pull request #2 from nazarii-gnydyn/201709-lldpshow-parser-fix
991ff2d 
Fixed parser logic to handle non mandatory TLV.
Merge remote-tracking branch 'upstream/201709' into 201709
2ca13e2
Merge remote-tracking branch 'origin/master-201709-update' into 20170…
eeb840f 
…9-master-update

Conflicts:
	config/main.py
Fixed 'show ip route' command: ipv6 -> ipv4.
9d0280e
@stcheng
Copy link
Contributor

stcheng commented Jan 3, 2018

it seems that the pull request includes more than needed.

@nazarii-gnydyn
Copy link
Author

nazarii-gnydyn commented Jan 4, 2018 •
edited
Loading

@stcheng This is because #176 is not merged yet.
This is done in scope of our previous conversation here: sonic-net/sonic-buildimage#1199.

vdahiya12 pushed a commit to vdahiya12/sonic-utilities that referenced this pull request Jul 23, 2021
@alexrallen
[psud] Add PSU Hardware Revision to Redis STATE_DB (sonic-net#179)
807b304 
Added "hardware revision" field to list of platform fields to sync to STATE_DB for the PSU. Also updated relevant unit tests. 

Now that hardware revision exists as a platform 2.0 field for all devices, it is appropriate to synchronize this field to STATE_DB for PSUs as is done with all other fields. This will allow this field to be exposed to CLI tools through psushow in the future which reads state from STATE_DB.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@nazarii-gnydyn @stcheng @pavel-shirshov @taoyl-ms @jleveque @prsunny @samaity