update BigqueryDatapolicy to ga #6797

DrFaust92 · 2022-11-08T17:46:48Z

If this PR is for Terraform, I acknowledge that I have:

Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

bigquerydatapolicy: promoted `google_bigquery_datapolicy_data_policy` to GA

modular-magician · 2022-11-08T17:47:54Z

Hello! I am a robot who works on Magic Modules PRs.

I've detected that you're a community contributor. @shuyama1, a repository maintainer, has been assigned to assist you and help review your changes.

❓ First time contributing? Click here for more details

Your assigned reviewer will help review your code by:

Ensuring it's backwards compatible, covers common error cases, etc.
Summarizing the change into a user-facing changelog note.
Passes tests, either our "VCR" suite, a set of presubmit tests, or with manual test runs.

You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails.

If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox.

modular-magician · 2022-11-08T18:04:26Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 9 files changed, 1188 insertions(+), 14 deletions(-))
Terraform Beta: Diff ( 4 files changed, 35 insertions(+), 40 deletions(-))
TF Validator: Diff ( 7 files changed, 468 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 1 file changed, 3 deletions(-))

modular-magician · 2022-11-08T18:55:19Z

Tests analytics

Total tests: 2228
Passed tests 1982
Skipped tests: 241
Failed tests: 5

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccFirebaserulesRelease_BasicRelease|TestAccComputeForwardingRule_update|TestAccBigqueryDatapolicyDataPolicy_bigqueryDatapolicyDataPolicyUpdate|TestAccBigqueryDatapolicyDataPolicyIamMemberGenerated|TestAccBigqueryDatapolicyDataPolicyIamPolicyGenerated

modular-magician · 2022-11-08T18:56:41Z

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccComputeForwardingRule_update[Debug log]
TestAccBigqueryDatapolicyDataPolicyIamMemberGenerated[Debug log]
TestAccBigqueryDatapolicyDataPolicyIamPolicyGenerated[Debug log]

Tests failed during RECORDING mode:
TestAccBigqueryDatapolicyDataPolicy_bigqueryDatapolicyDataPolicyUpdate[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

shuyama1

Looks like we also need to bump the version in handwritten test TestAccBigqueryDatapolicyDataPolicy_bigqueryDatapolicyDataPolicyUpdate at mmv1/third_party/terraform/tests/resource_bigquery_datapolicy_data_policy_test.go.erb

DrFaust92 · 2022-11-10T07:27:16Z

missed that, fixing

modular-magician · 2022-11-11T10:03:37Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 10 files changed, 1252 insertions(+), 14 deletions(-))
Terraform Beta: Diff ( 5 files changed, 36 insertions(+), 45 deletions(-))
TF Validator: Diff ( 7 files changed, 468 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 1 file changed, 3 deletions(-))

modular-magician · 2022-11-11T10:54:07Z

Tests analytics

Total tests: 2242
Passed tests 2001
Skipped tests: 241
Failed tests: 0

All tests passed in REPLAYING mode
View the build log

shuyama1 · 2022-11-12T20:27:31Z

Running GA test: https://ci-oss.hashicorp.engineering/buildConfiguration/GoogleCloud_ProviderGoogleCloudMmUpstream/352254

shuyama1

@DrFaust92 GA tests failed. Looks like the tests have dependency on google_data_catalog_policy_tag and google_data_catalog_taxonomy which are both beta resources.

DrFaust92 · 2022-12-18T17:18:36Z

shuyama1 luckily these are GAable so ill open another PR #6989

shuyama1 · 2023-02-27T17:50:23Z

/gcbrun

modular-magician · 2023-02-27T18:07:10Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 25 files changed, 3244 insertions(+), 43 deletions(-))
Terraform Beta: Diff ( 13 files changed, 23 insertions(+), 138 deletions(-))
TF Validator: Diff ( 14 files changed, 1274 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 4 files changed, 1 insertion(+), 14 deletions(-))

modular-magician · 2023-02-27T18:53:40Z

Tests analytics

Total tests: 2473
Passed tests 2207
Skipped tests: 255
Failed tests: 11

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccDataCatalogTaxonomy_dataCatalogTaxonomyBasicExample|TestAccDataCatalogPolicyTag_dataCatalogTaxonomiesPolicyTagChildPoliciesExample|TestAccDataCatalogPolicyTag_dataCatalogTaxonomiesPolicyTagBasicExample|TestAccComputeForwardingRule_update|TestAccDataCatalogPolicyTagIamPolicyGenerated|TestAccDataCatalogTaxonomyIamPolicyGenerated|TestAccDataCatalogTaxonomyIamMemberGenerated|TestAccDataCatalogPolicyTagIamMemberGenerated|TestAccDataCatalogPolicyTagIamBindingGenerated|TestAccDataCatalogTaxonomyIamBindingGenerated|TestAccWorkstationsWorkstationConfig_workstationConfigEncryptionKeyExample

modular-magician · 2023-02-27T19:49:11Z

Tests passed during RECORDING mode:
TestAccDataCatalogTaxonomy_dataCatalogTaxonomyBasicExample[Debug log]
TestAccDataCatalogPolicyTag_dataCatalogTaxonomiesPolicyTagChildPoliciesExample[Debug log]
TestAccDataCatalogPolicyTag_dataCatalogTaxonomiesPolicyTagBasicExample[Debug log]
TestAccComputeForwardingRule_update[Debug log]
TestAccDataCatalogPolicyTagIamPolicyGenerated[Debug log]
TestAccDataCatalogTaxonomyIamPolicyGenerated[Debug log]
TestAccDataCatalogTaxonomyIamMemberGenerated[Debug log]
TestAccDataCatalogPolicyTagIamMemberGenerated[Debug log]
TestAccDataCatalogPolicyTagIamBindingGenerated[Debug log]
TestAccDataCatalogTaxonomyIamBindingGenerated[Debug log]

Tests failed during RECORDING mode:
TestAccWorkstationsWorkstationConfig_workstationConfigEncryptionKeyExample[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

shuyama1 · 2023-03-07T19:20:44Z

@DrFaust92 Thanks for making the updates. Please let me know if this PR is ready to review.
Plus, we recently split the product level api.yaml file to individual resource files. You'll likely need to move the code change in api.yaml file in this PR to each resource .yaml file. Sorry about it.

DrFaust92 · 2023-03-07T20:44:41Z

@shuyama1 done

shuyama1 · 2023-03-07T21:14:06Z

/gcbrun

modular-magician · 2023-03-07T21:31:36Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 10 files changed, 1189 insertions(+), 14 deletions(-))
Terraform Beta: Diff ( 4 files changed, 4 insertions(+), 40 deletions(-))
TF Validator: Diff ( 8 files changed, 469 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 1 file changed, 3 deletions(-))

modular-magician · 2023-03-07T22:18:59Z

Tests analytics

Total tests: 2494
Passed tests 2231
Skipped tests: 258
Affected tests: 5

Action taken

Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccWorkstationsWorkstationConfig_workstationConfigEncryptionKeyExample|TestAccBigqueryDatapolicyDataPolicyIamPolicyGenerated|TestAccBigqueryDatapolicyDataPolicyIamMemberGenerated|TestAccFirebaserulesRelease_BasicRelease|TestAccBigqueryDatapolicyDataPolicy_bigqueryDatapolicyDataPolicyUpdate

Get to know how VCR tests work

modular-magician · 2023-03-07T23:10:10Z

Tests passed during RECORDING mode:
TestAccBigqueryDatapolicyDataPolicyIamPolicyGenerated[Debug log]
TestAccBigqueryDatapolicyDataPolicyIamMemberGenerated[Debug log]
TestAccFirebaserulesRelease_BasicRelease[Debug log]

Tests failed during RECORDING mode:
TestAccWorkstationsWorkstationConfig_workstationConfigEncryptionKeyExample[Error message] [Debug log]
TestAccBigqueryDatapolicyDataPolicy_bigqueryDatapolicyDataPolicyUpdate[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

shuyama1 · 2023-03-08T19:31:08Z

/gcbrun

modular-magician · 2023-03-08T19:48:13Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 11 files changed, 1263 insertions(+), 14 deletions(-))
Terraform Beta: Diff ( 5 files changed, 4 insertions(+), 45 deletions(-))
TF Validator: Diff ( 8 files changed, 469 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 1 file changed, 3 deletions(-))

modular-magician · 2023-03-08T20:36:33Z

Tests analytics

Total tests: 2497
Passed tests 2232
Skipped tests: 262
Affected tests: 3

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccComposerEnvironment_withEncryptionConfigComposer2|TestAccBigqueryDatapolicyDataPolicy_bigqueryDatapolicyDataPolicyUpdate|TestAccCloudRunV2Job_cloudrunv2JobFullUpdate

Get to know how VCR tests work

modular-magician · 2023-03-08T21:04:33Z

Tests passed during RECORDING mode:
TestAccComposerEnvironment_withEncryptionConfigComposer2[Debug log]
TestAccCloudRunV2Job_cloudrunv2JobFullUpdate[Debug log]

Tests failed during RECORDING mode:
TestAccBigqueryDatapolicyDataPolicy_bigqueryDatapolicyDataPolicyUpdate[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

shuyama1

tpg unit test failed due to

google/resource_bigquery_datapolicy_data_policy_test.go:18:17: undefined: TestAccProvidersOiCS

We'll likely need to change the test provider from TestAccProvidersOiCS to TestAccProviders, as TestAccProvidersOiCS is set up for beta-only tests

shuyama1 · 2023-03-14T07:06:25Z

/gcbrun

modular-magician · 2023-03-14T07:23:25Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 11 files changed, 1263 insertions(+), 14 deletions(-))
Terraform Beta: Diff ( 5 files changed, 5 insertions(+), 46 deletions(-))
TF Validator: Diff ( 8 files changed, 469 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 1 file changed, 3 deletions(-))

modular-magician · 2023-03-14T08:12:12Z

Tests analytics

Total tests: 2496
Passed tests 2233
Skipped tests: 262
Affected tests: 1

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDataSourceDnsManagedZone_basic

Get to know how VCR tests work

modular-magician · 2023-03-14T08:12:35Z

Tests failed during RECORDING mode:
TestAccDataSourceDnsManagedZone_basic[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

shuyama1 · 2023-03-14T17:09:33Z

Kicked off GA tests at https://ci-oss.hashicorp.engineering/buildConfiguration/GoogleCloud_ProviderGoogleCloudMmUpstream/382506.

Update: tests passed

shuyama1

Thank you!

Adding AuthorizedOrgsDesc to AccessContextManager (GoogleCloudPlatform#7178) Allow project field in Firebase apps datasource (GoogleCloudPlatform#7300) * Allow project field in Firebase apps datasource * Add tf_test to the display name * update to capitalized dependencies Rename compute_(region)_per_instance_config test files to .erb files … (GoogleCloudPlatform#7409) * Rename compute_(region)_per_instance_config test files to .erb files since the resources have fields in beta. * Omit stateful_ip tests for GA Bootstrap network cleanup (GoogleCloudPlatform#7367) * Update bootstrapped networks for alloydb * Update bootstrapped networks for redis * Update bootstrapped networks for vertexai * Update comment for BootstrapSharedTestNetwork to be more clear Fix override directory concat (GoogleCloudPlatform#7413) Bootstrap required permissions for composer environment tests (GoogleCloudPlatform#7391) * Bootstrap the required permissions * Make BootstrapAllPSARoles actually work Also adds some helper functions for debugging what the bootstrap function does. It will now log the roles that were missing in the policy. * Add missing return, fix nits * Fix typo in service agent name * Account for newly exported test functions Add maintenance_interval field to Instance Template and Instance scheduling. (GoogleCloudPlatform#7365) * Move testing to handwritten * Move testing to handwritten * Fix lint * Fix typo * Add remove step and update documentation * Add remove step and update documentation * Fix comparing string to nil * Add field to handwritten defs * rebase on main & resolve conflicts * Fix doc formatting * Add maintenance interval to Instance resource * Add maintenance interval to Instance resource * Add maintenance interval to Instance resource * Change function names to valid * Fix type mismatch * Fix type mismatch * Fix function name Fix naming of resource policies in tests to be sweepable (GoogleCloudPlatform#7412) Skip TestAccWorkstationsWorkstationConfig_workstationConfigEncryptionKeyExample (GoogleCloudPlatform#7415) Add support for Apigee Sharedflow (GoogleCloudPlatform#7202) * added sharedflows mmv1 with error * fix indentation issue for sharedflow * add semi auto generated resourceApigeeSharedFlow * remove sharedflow mmv1 and add sharedflow manual provider * adding files for debugging review, test have issue * adding files for debugging review, test have issue * update test, doc, provider for apigee * Update api.yaml remove empty new line * Update api.yaml * Rename resource_apigee_shared_flow_generated_test.go to resource_apigee_shared_flow_test.go * Update resource_apigee_shared_flow.go update import regex, change debug messages to log.Printf * Update mmv1/third_party/terraform/utils/provider.go.erb Co-authored-by: megan07 <mbang@hashicorp.com> * update PR to address comments * update test * fix sharedflow attribute update issue, add sharedflow deployment * Update apigee_shared_flow_deployment.html.markdown minor doc fix * Update mmv1/third_party/terraform/utils/provider.go.erb Co-authored-by: megan07 <mbang@hashicorp.com> * Update mmv1/third_party/terraform/website/docs/r/apigee_shared_flow.html.markdown Co-authored-by: megan07 <mbang@hashicorp.com> * Update resource_apigee_shared_flow_test.go remove commented out (unused) line of code * Delete api.yaml remove api.yaml as it is not needed for handwritten resource. Current repo structure no longer uses aggregated api.yaml * Rename apigee_shared_flow.html.markdown to apigee_sharedflow.html.markdown * Rename apigee_shared_flow_deployment.html.markdown to apigee_sharedflow_deployment.html.markdown * Rename resource_apigee_shared_flow.go to resource_apigee_sharedflow.go * Rename resource_apigee_shared_flow_deployment_test.go to resource_apigee_sharedflow_deployment_test.go * Rename resource_apigee_shared_flow_test.go to resource_apigee_sharedflow_test.go * Rename resource_apigee_shared_flow_sweeper_test.go to resource_apigee_sharedflow_sweeper_test.go * Update resource_apigee_sharedflow.go remove comment lines * Update mmv1/third_party/terraform/resources/resource_apigee_sharedflow.go Co-authored-by: megan07 <mbang@hashicorp.com> * Update resource_apigee_sharedflow_deployment_test.go remove unused debugging log * update function name to capitalize * Update resource_apigee_sharedflow_deployment_test.go remove fmt.print * add flowhook * move flowhook doc * Update mmv1/third_party/terraform/tests/resource_apigee_flowhook_test.go Co-authored-by: megan07 <mbang@hashicorp.com> * Update mmv1/third_party/terraform/website/docs/r/apigee_flowhook.html.markdown Co-authored-by: megan07 <mbang@hashicorp.com> * Update mmv1/third_party/terraform/website/docs/r/apigee_flowhook.html.markdown Co-authored-by: megan07 <mbang@hashicorp.com> * Update mmv1/third_party/terraform/tests/resource_apigee_flowhook_test.go Co-authored-by: megan07 <mbang@hashicorp.com> * Update resource_apigee_flowhook_test.go remove fmt.print * update some resource attribute properties * Update apigee_flowhook.html.markdown updated `description` and `continue_on_error` as optional * update referenced function naming case --------- Co-authored-by: Ray Xu <xrc@google.com> Co-authored-by: megan07 <mbang@hashicorp.com> add tests (GoogleCloudPlatform#7357) Co-authored-by: Edward Sun <sunedward@google.com> run gofmt + fix capitalization errors from previous PRs (GoogleCloudPlatform#7420) switch ci secrets to use secret manager (GoogleCloudPlatform#7408) Update field descriptions (GoogleCloudPlatform#7402) HA VPN over Cloud Interconnect has launched in GA We should still probably add a sample or two showing how to use it. Document PRODUCT_BASE_PATH override for DCL resource IAM (GoogleCloudPlatform#7418) yaqs/1723187608399380480 Add support for accelerators to google_datafusion_instance (GoogleCloudPlatform#6851) Added support to the field for Data Fusion, updated corresponding generated and handwritten tests, and added a custom diffsuppressfunc. Currently suggests a manual fix to a potential diff issue, will be able to update down line based on feedback from API team. Fix alloydb_cluster permadiff (GoogleCloudPlatform#7421) Fix dns_managed_zone tests using unverified domain (GoogleCloudPlatform#7422) Add SKIP_PROJECT_SWEEPER env variable for skipping the project sweeper (GoogleCloudPlatform#7432) Remove percent sign when parsing metadata name (GoogleCloudPlatform#7417) * Remove percent sign when parsing metadata name * Remove percent sign when parsing metadata name Merge branch 'GoogleCloudPlatform:main' into feature/iam_policy Add ignore read on reserved ip ranges (GoogleCloudPlatform#7429) Fix serviceusage links, clean up service resource stub (GoogleCloudPlatform#7435) Remove use of `make generate` from TPG/TPGB-specific step in CI (GoogleCloudPlatform#7379) Updating default accelerator.state field behavior in Data Fusion Instance (GoogleCloudPlatform#7434) Making suggested default behavior functionality updates in previous accelerators PR. Modify resource attribute 'input' to 'immutable' (GoogleCloudPlatform#7431) * Modify resource attribute 'input' to 'immutable' Remove noisy logging of project sweeper being skipped (GoogleCloudPlatform#7439) Fix PubSub-to-BigQuery push configuration example (GoogleCloudPlatform#7410) Rework + reflow provider reference, touch up index (GoogleCloudPlatform#7437) Fix eventarc tests to use dedicated bootstrapped keys (GoogleCloudPlatform#7440) Update docs for changing attribute `input` to `immutable` (GoogleCloudPlatform#7442) Feat name constraints (GoogleCloudPlatform#7400) Remove game_service_cluster_basic test (GoogleCloudPlatform#7443) send friendly_name (GoogleCloudPlatform#7433) * send friendly_name * fixed validator failures * update * fix validator errors --------- Co-authored-by: Edward Sun <sunedward@google.com> Fix headline of google_iam_workload_identity_pool (GoogleCloudPlatform#7449) Move IAM bootstrap to its own file, improve error messages (GoogleCloudPlatform#7424) * Move IAM bootstrap to its own file, improve errors Also bootstrap roles/cloudbuild.builds.builder for cloudbuild service agent. * Re-add BootstrapConfig (accidentally deleted) * Fix wrong variable name * Bootstrap the role previously hardcoded for pubsub * Move error message back into bootstrap function This will dedup the code that calls this function. It now returns a boolean and sends the more useful error through t.Error. * Bootstrap the permissions for pubsub service agent * Bootstrap the role in the correct test * Fix formatting Changing name field on google_compute_disk for TestAccComputeInstanceTemplate_sourceSnapshotEncryptionKey to include randomly generated string (GoogleCloudPlatform#7392) * Changed name within google_compute_disk on line 3162 to inclue and randomly generated string * Cleaned up arguments being passed in to be more inline with other tests * Updated based on addtional PR comments * Fixed swapping of values within new context If not specified, a default Workstations service agent SA is returned (GoogleCloudPlatform#7428) * If not specified, a default service agent SA is returned * Revert "Skip TestAccWorkstationsWorkstationConfig_workstationConfigEncryptionKeyExample" This reverts commit 097bdbe. * remove `rotation_period` update BigqueryDatapolicy to ga (GoogleCloudPlatform#6797) fix managed.dnsAuthorizations: (GoogleCloudPlatform#7445) Co-authored-by: Edward Sun <sunedward@google.com> google_compute_security_policy: force send enforce_on_key so it can be unset on (GoogleCloudPlatform#7454) Make `hostname` and `matcher` fields immutable (GoogleCloudPlatform#7448) Add note on requiredness (GoogleCloudPlatform#7453) Update BootstrapProject to support use across multiple projects/environments (GoogleCloudPlatform#7369) * Update BootstrapProject to support use across multiple projects/environments * Fix typo * Fix arguments for getTestProjectFromEnv * Fix project naming strategy for BootstrapProject to produce valid names in all envs * Fix typo * Fix function name after rebase Update resource names in acceptance test to use `tf-test-` prefix (GoogleCloudPlatform#7450) fix datastream_stream dataset id import (GoogleCloudPlatform#7451) Merge branch 'GoogleCloudPlatform:main' into feature/iam_policy Removing api.yaml and replacing with per product configs Merge branch 'feature/iam_policy' of https://github.com/dbjnbnrj/magic-modules into feature/iam_policy

modular-magician requested a review from shuyama1 November 8, 2022 17:47

shuyama1 requested changes Nov 8, 2022

View reviewed changes

modular-magician requested a review from shuyama1 November 11, 2022 09:50

shuyama1 reviewed Nov 14, 2022

View reviewed changes

DrFaust92 marked this pull request as draft December 31, 2022 18:44

DrFaust92 force-pushed the bq-data-policy-ga branch from 74d57a1 to a900a93 Compare February 25, 2023 18:41

modular-magician requested a review from shuyama1 February 27, 2023 17:51

shuyama1 self-assigned this Feb 27, 2023

DrFaust92 force-pushed the bq-data-policy-ga branch from a900a93 to 97e10d8 Compare March 7, 2023 20:44

DrFaust92 marked this pull request as ready for review March 7, 2023 20:44

DrFaust92 requested a review from a team as a code owner March 7, 2023 20:44

shuyama1 removed the request for review from a team March 7, 2023 21:13

shuyama1 removed their assignment Mar 8, 2023

shuyama1 requested changes Mar 10, 2023

View reviewed changes

DrFaust92 added 3 commits March 14, 2023 08:44

rebase

a2001ea

add field update

45ebc0c

add field update

78142d2

DrFaust92 force-pushed the bq-data-policy-ga branch from cdae187 to 78142d2 Compare March 14, 2023 06:44

modular-magician requested a review from shuyama1 March 14, 2023 07:07

shuyama1 approved these changes Mar 14, 2023

View reviewed changes

shuyama1 merged commit d80d5d3 into GoogleCloudPlatform:main Mar 14, 2023

600lyy pushed a commit to 600lyy/magic-modules that referenced this pull request Mar 15, 2023

update BigqueryDatapolicy to ga (GoogleCloudPlatform#6797)

fbe6b07

ericayyliu pushed a commit to ericayyliu/magic-modules that referenced this pull request Jul 26, 2023

update BigqueryDatapolicy to ga (GoogleCloudPlatform#6797)

4484e0f

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

update BigqueryDatapolicy to ga #6797

update BigqueryDatapolicy to ga #6797

DrFaust92 commented Nov 8, 2022 •

edited

Loading

modular-magician commented Nov 8, 2022

modular-magician commented Nov 8, 2022

modular-magician commented Nov 8, 2022

modular-magician commented Nov 8, 2022

shuyama1 left a comment

DrFaust92 commented Nov 10, 2022

modular-magician commented Nov 11, 2022

modular-magician commented Nov 11, 2022

shuyama1 commented Nov 12, 2022

shuyama1 left a comment

DrFaust92 commented Dec 18, 2022

shuyama1 commented Feb 27, 2023

modular-magician commented Feb 27, 2023

modular-magician commented Feb 27, 2023

modular-magician commented Feb 27, 2023

shuyama1 commented Mar 7, 2023

DrFaust92 commented Mar 7, 2023

shuyama1 commented Mar 7, 2023

modular-magician commented Mar 7, 2023

modular-magician commented Mar 7, 2023

modular-magician commented Mar 7, 2023

shuyama1 commented Mar 8, 2023

modular-magician commented Mar 8, 2023

modular-magician commented Mar 8, 2023

modular-magician commented Mar 8, 2023

shuyama1 left a comment

shuyama1 commented Mar 14, 2023

modular-magician commented Mar 14, 2023

modular-magician commented Mar 14, 2023

modular-magician commented Mar 14, 2023

shuyama1 commented Mar 14, 2023 •

edited

Loading

shuyama1 left a comment

update BigqueryDatapolicy to ga #6797

update BigqueryDatapolicy to ga #6797

Conversation

DrFaust92 commented Nov 8, 2022 • edited Loading

modular-magician commented Nov 8, 2022

modular-magician commented Nov 8, 2022

Diff report

modular-magician commented Nov 8, 2022

Tests analytics

Action taken

modular-magician commented Nov 8, 2022

shuyama1 left a comment

Choose a reason for hiding this comment

DrFaust92 commented Nov 10, 2022

modular-magician commented Nov 11, 2022

Diff report

modular-magician commented Nov 11, 2022

Tests analytics

shuyama1 commented Nov 12, 2022

shuyama1 left a comment

Choose a reason for hiding this comment

DrFaust92 commented Dec 18, 2022

shuyama1 commented Feb 27, 2023

modular-magician commented Feb 27, 2023

Diff report

modular-magician commented Feb 27, 2023

Tests analytics

Action taken

modular-magician commented Feb 27, 2023

shuyama1 commented Mar 7, 2023

DrFaust92 commented Mar 7, 2023

shuyama1 commented Mar 7, 2023

modular-magician commented Mar 7, 2023

Diff report

modular-magician commented Mar 7, 2023

Tests analytics

Action taken

modular-magician commented Mar 7, 2023

shuyama1 commented Mar 8, 2023

modular-magician commented Mar 8, 2023

Diff report

modular-magician commented Mar 8, 2023

Tests analytics

Action taken

modular-magician commented Mar 8, 2023

shuyama1 left a comment

Choose a reason for hiding this comment

shuyama1 commented Mar 14, 2023

modular-magician commented Mar 14, 2023

Diff report

modular-magician commented Mar 14, 2023

Tests analytics

Action taken

modular-magician commented Mar 14, 2023

shuyama1 commented Mar 14, 2023 • edited Loading

shuyama1 left a comment

Choose a reason for hiding this comment

DrFaust92 commented Nov 8, 2022 •

edited

Loading

shuyama1 commented Mar 14, 2023 •

edited

Loading