Allow project field in Firebase apps datasource

[rainshen49]

Fix the edge case where if the provider setup doesn't include a project field, the datasource requires an unconfigurable project field.

Without project field:

data "google_firebase_android_app" "my_app" {
  app_id = google_firebase_android_app.my_app.app_id
}

It throws:

│ Error: project: required field is not set
│ 
│   with data.google_firebase_android_app.my_app,
│   on main.tf line 52, in data "google_firebase_android_app" "source":
│   52: data "google_firebase_android_app" "my_app" {
│ 
╵

If I specify a project field, it throws this:

│ Error: Value for unconfigurable attribute
│ 
│   with data.google_firebase_android_app.my_app,
│   on main.tf line 53, in data "google_firebase_android_app" "my_app":
│   53:   project = google_project.default.project_id
│ 
│ Can't configure a value for "project": its value will be decided automatically based
│ on the result of applying this configuration.

If this PR is for Terraform, I acknowledge that I have:

• Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
• Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
• Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
• Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
• Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

firebase: allowed specifying a `project` field on datasources for `google_firebase_android_app`, `google_firebase_web_app`, and `google_firebase_apple_app`.

[ScottSuarez]

/gcbrun

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 1 insertion(+))
Terraform Beta: Diff ( 6 files changed, 75 insertions(+))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

[modular-magician]

Tests analytics

Total tests: 2466
Passed tests 2205
Skipped tests: 257
Failed tests: 4

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccFirebaserulesRelease_BasicRelease|TestAccApigeeAddonsConfig_apigeeAddonsTestExample|TestAccDataSourceGoogleFirebaseAndroidApp|TestAccDataSourceGoogleFirebaseAppleApp

[modular-magician]

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccApigeeAddonsConfig_apigeeAddonsTestExample[Debug log]
TestAccDataSourceGoogleFirebaseAndroidApp[Debug log]
TestAccDataSourceGoogleFirebaseAppleApp[Debug log]

All tests passed
View the build log or the debug log for each test

[ScottSuarez]

reroling reviewer since I won't be here tomorrow and Tuesday

[hao-nan-li]

It looks like the added test TestAccDataSourceGoogleFirebaseWebApp didn't fail during recording mode. Not too sure if the new test actually runs. Can you confirm the test passed on your local environment?

[rainshen49]

@hao-nan-li yes, the test passed locally.

[hao-nan-li]

/gcbrun

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 1 insertion(+))
Terraform Beta: Diff ( 6 files changed, 75 insertions(+))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

[modular-magician]

Tests analytics

Total tests: 2473
Passed tests 2215
Skipped tests: 256
Failed tests: 2

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccLoggingBucketConfigProject_cmekSettings|TestAccApigeeAddonsConfig_apigeeAddonsTestExample

[modular-magician]

Tests passed during RECORDING mode:
TestAccLoggingBucketConfigProject_cmekSettings[Debug log]
TestAccApigeeAddonsConfig_apigeeAddonsTestExample[Debug log]

All tests passed
View the build log or the debug log for each test

[hao-nan-li]

LGTM in general, adding a second reviewer to sign off.

[roaks3]

Yea, I was also surprised to not see the WebApp test, but it appears to have passed during replay here. I suppose the API requests being made during that test are all requests we were already make?

Otherwise LGTM, but we will want the display name to be sweepable.

[roaks3]

/gcbrun

[roaks3]

@rainshen49 This change looks ready to go, but we recently updated many of our utility functions to start with a capital letter, so I think you need to go and update a few function calls in this PR.

This is the error I'm seeing in the GitHub check:

google-beta/data_source_google_firebase_web_app_test.go:13:19: undefined: getTestProjectFromEnv
google-beta/data_source_google_firebase_web_app_test.go:19:2: undefined: vcrTest
google-beta/data_source_google_firebase_web_app_test.go:21:14: undefined: testAccProviders
?   	github.com/hashicorp/terraform-provider-google-beta	[no test files]
FAIL	github.com/hashicorp/terraform-provider-google-beta/google-beta [build failed]
?   	github.com/hashicorp/terraform-provider-google-beta/version	[no test files]
FAIL

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 1 insertion(+))
Terraform Beta: Diff ( 6 files changed, 75 insertions(+))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

[modular-magician]

Tests analytics

Total tests: 0
Passed tests 0
Skipped tests: 0
Affected tests: 0

Errors occurred during REPLAYING mode. Please fix them to complete your PR
View the build log

[hao-nan-li]

/gcbrun

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 1 insertion(+))
Terraform Beta: Diff ( 6 files changed, 75 insertions(+))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

[modular-magician]

Tests analytics

Total tests: 2492
Passed tests 2233
Skipped tests: 258
Affected tests: 1

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccWorkstationsWorkstationConfig_workstationConfigEncryptionKeyExample

Get to know how VCR tests work

[modular-magician]

Tests failed during RECORDING mode:
TestAccWorkstationsWorkstationConfig_workstationConfigEncryptionKeyExample[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test