Adding AuthorizedOrgsDesc to AccessContextManager #7178

vmoros · 2023-01-27T00:27:52Z

If this PR is for Terraform, I acknowledge that I have:

Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

`google_access_context_manager_authorized_orgs_desc`

…orks.

… Other changes require destructive updates.

…h can be updated in-place and which cannot. Also updated some description strings.

modular-magician · 2023-01-27T00:28:07Z

Oops! It looks like you're using an unknown release-note type in your changelog entries:

REPLACEME

Please only use the types listed in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md.

modular-magician · 2023-01-27T00:28:50Z

Hello! I am a robot who works on Magic Modules PRs.

I've detected that you're a community contributor. @shuyama1, a repository maintainer, has been assigned to assist you and help review your changes.

❓ First time contributing? Click here for more details

Your assigned reviewer will help review your code by:

Ensuring it's backwards compatible, covers common error cases, etc.
Summarizing the change into a user-facing changelog note.
Passes tests, either our "VCR" suite, a set of presubmit tests, or with manual test runs.

You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails.

If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox.

modular-magician · 2023-01-27T00:43:03Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 712 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 4 files changed, 712 insertions(+), 2 deletions(-))
TF Validator: Diff ( 3 files changed, 121 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 4 files changed, 114 insertions(+))

modular-magician · 2023-01-27T01:11:32Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 5 files changed, 713 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 5 files changed, 713 insertions(+), 2 deletions(-))
TF Validator: Diff ( 3 files changed, 121 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 4 files changed, 114 insertions(+))

modular-magician · 2023-01-27T01:54:21Z

Tests analytics

Total tests: 2436
Passed tests 2177
Skipped tests: 254
Failed tests: 5

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccAccessContextManager|TestAccFirebaserulesRelease_BasicRelease|TestAccRegionInstanceGroupManager_stateful|TestAccAccessContextManagerAuthorizedOrgsDesc_accessContextManagerAuthorizedOrgsDescBasicExample|TestAccContainerCluster_failedCreation

modular-magician · 2023-01-27T02:09:06Z

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccContainerCluster_failedCreation[Debug log]

Tests failed during RECORDING mode:
TestAccAccessContextManager[Error message] [Debug log]
TestAccRegionInstanceGroupManager_stateful[Error message] [Debug log]
TestAccAccessContextManagerAuthorizedOrgsDesc_accessContextManagerAuthorizedOrgsDescBasicExample[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

modular-magician · 2023-01-27T05:46:21Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 5 files changed, 694 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 5 files changed, 694 insertions(+), 2 deletions(-))
TF Validator: Diff ( 3 files changed, 121 insertions(+), 3 deletions(-))

modular-magician · 2023-01-27T06:28:09Z

Tests analytics

Total tests: 2435
Passed tests 2179
Skipped tests: 254
Failed tests: 2

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccAccessContextManager|TestAccContainerCluster_failedCreation

modular-magician · 2023-01-27T06:43:30Z

Tests passed during RECORDING mode:
TestAccContainerCluster_failedCreation[Debug log]

Tests failed during RECORDING mode:
TestAccAccessContextManager[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

mmv1/products/accesscontextmanager/AuthorizedOrgsDesc.yaml

modular-magician · 2023-01-27T16:40:03Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 5 files changed, 695 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 5 files changed, 695 insertions(+), 2 deletions(-))
TF Validator: Diff ( 3 files changed, 121 insertions(+), 3 deletions(-))

modular-magician · 2023-01-27T17:19:41Z

Tests analytics

Total tests: 2435
Passed tests 2179
Skipped tests: 254
Failed tests: 2

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccAccessContextManager|TestAccContainerCluster_failedCreation

modular-magician · 2023-01-27T17:34:46Z

Tests passed during RECORDING mode:
TestAccContainerCluster_failedCreation[Debug log]

Tests failed during RECORDING mode:
TestAccAccessContextManager[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

modular-magician · 2023-01-30T19:02:37Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 5 files changed, 694 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 5 files changed, 694 insertions(+), 2 deletions(-))
TF Validator: Diff ( 3 files changed, 121 insertions(+), 3 deletions(-))

modular-magician · 2023-01-30T19:49:36Z

Tests analytics

Total tests: 2439
Passed tests 2182
Skipped tests: 254
Failed tests: 3

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccAccessContextManager|TestAccContainerCluster_failedCreation|TestAccFirebaserulesRelease_BasicRelease

…er_authorized_orgs_desc_test.go Co-authored-by: Shuya Ma <87669292+shuyama1@users.noreply.github.com>

shuyama1 · 2023-03-06T21:04:40Z

/gcbrun

modular-magician · 2023-03-06T21:22:55Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 5 files changed, 697 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 5 files changed, 697 insertions(+), 2 deletions(-))
TF Validator: Diff ( 3 files changed, 121 insertions(+), 3 deletions(-))

modular-magician · 2023-03-06T21:24:32Z

Tests analytics

Total tests: 0
Passed tests 0
Skipped tests: 0
Affected tests: 0

Errors occurred during REPLAYING mode. Please fix them to complete your PR
View the build log

shuyama1

sorry for missing this one!

mmv1/third_party/terraform/tests/resource_access_context_manager_authorized_orgs_desc_test.go

…er_authorized_orgs_desc_test.go

shuyama1 · 2023-03-06T21:32:02Z

/gcbrun

modular-magician · 2023-03-06T21:47:35Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 5 files changed, 697 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 5 files changed, 697 insertions(+), 2 deletions(-))
TF Validator: Diff ( 3 files changed, 121 insertions(+), 3 deletions(-))

modular-magician · 2023-03-06T22:35:26Z

Tests analytics

Total tests: 2491
Passed tests 2231
Skipped tests: 258
Affected tests: 2

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccWorkstationsWorkstationConfig_workstationConfigEncryptionKeyExample|TestAccFirebaserulesRelease_BasicRelease

Get to know how VCR tests work

modular-magician · 2023-03-06T23:28:32Z

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]

Tests failed during RECORDING mode:
TestAccWorkstationsWorkstationConfig_workstationConfigEncryptionKeyExample[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

shuyama1

Only a couple small comments.

I've triggered VCR recording test on TC and therefore cassette should be forced recording for the newly added test

shuyama1 · 2023-03-06T23:45:38Z

mmv1/products/accesscontextmanager/AuthorizedOrgsDesc.yaml

+    - !ruby/object:Api::Type::Time
+      name: 'createTime'
+      description: |
+        Time the AuthorizedOrgsDesc was created in UTC.
+      output: true
+    - !ruby/object:Api::Type::Time
+      name: 'updateTime'
+      description: |
+        Time the AuthorizedOrgsDesc was updated in UTC.
+      output: true


We can remove these two fields as they may not be useful for Terraform users

shuyama1 · 2023-03-07T00:22:50Z

mmv1/products/accesscontextmanager/AuthorizedOrgsDesc.yaml

+    - !ruby/object:Api::Type::Enum
+      name: assetType
+      input: true
+      description: |
+        The type of entities that need to use the authorization relationship during
+        evaluation, such as a device. Valid values are "ASSET_TYPE_DEVICE" and
+        "ASSET_TYPE_CREDENTIAL_STRENGTH".
+      values:
+        - :ASSET_TYPE_UNSPECIFIED
+        - :ASSET_TYPE_DEVICE
+        - :ASSET_TYPE_CREDENTIAL_STRENGTH
+    - !ruby/object:Api::Type::Enum
+      name: authorizationDirection
+      input: true
+      description: |
+        The direction of the authorization relationship between this organization
+        and the organizations listed in the "orgs" field. The valid values for this
+        field include the following:
+
+        AUTHORIZATION_DIRECTION_FROM: Allows this organization to evaluate traffic
+        in the organizations listed in the `orgs` field.
+
+        AUTHORIZATION_DIRECTION_TO: Allows the organizations listed in the `orgs`
+        field to evaluate the traffic in this organization.
+
+        For the authorization relationship to take effect, all of the organizations
+        must authorize and specify the appropriate relationship direction. For
+        example, if organization A authorized organization B and C to evaluate its
+        traffic, by specifying "AUTHORIZATION_DIRECTION_TO" as the authorization
+        direction, organizations B and C must specify
+        "AUTHORIZATION_DIRECTION_FROM" as the authorization direction in their
+        "AuthorizedOrgsDesc" resource.
+      values:
+        - :AUTHORIZATION_DIRECTION_UNSPECIFIED
+        - :AUTHORIZATION_DIRECTION_TO
+        - :AUTHORIZATION_DIRECTION_FROM
+    - !ruby/object:Api::Type::Enum
+      name: authorizationType
+      input: true
+      description: |
+        A granular control type for authorization levels. Valid value is "AUTHORIZATION_TYPE_TRUST".
+      values:
+        - :AUTHORIZATION_TYPE_UNSPECIFIED
+        - :AUTHORIZATION_TYPE_TRUST


Is there a server-side default values for these fields -- Does API return values for them if they are not explicitly specified?

Also should we remove *_UNSPECIFIED values? My understanding is that they are not valid values for users to specify.

There are no server-side default values for assetType, authorizationDirection, or authorizationType. The user must specify them.

The *_UNSPECIFIED values exist under the hood, which is why I added them in the code here, but they cannot be used so IMO it's reasonable to remove them here.

shuyama1 · 2023-03-07T00:52:46Z

/gcbrun

modular-magician · 2023-03-07T01:14:19Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 5 files changed, 697 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 5 files changed, 697 insertions(+), 2 deletions(-))
TF Validator: Diff ( 3 files changed, 121 insertions(+), 3 deletions(-))

modular-magician · 2023-03-07T02:06:04Z

Tests analytics

Total tests: 2491
Passed tests 2230
Skipped tests: 258
Affected tests: 3

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccFirebaserulesRelease_BasicRelease|TestAccComputeForwardingRule_update|TestAccWorkstationsWorkstationConfig_workstationConfigEncryptionKeyExample

Get to know how VCR tests work

modular-magician · 2023-03-07T03:03:19Z

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccComputeForwardingRule_update[Debug log]

Tests failed during RECORDING mode:
TestAccWorkstationsWorkstationConfig_workstationConfigEncryptionKeyExample[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

shuyama1

LGTM! Thank you!

Adding AuthorizedOrgsDesc to AccessContextManager (GoogleCloudPlatform#7178) Allow project field in Firebase apps datasource (GoogleCloudPlatform#7300) * Allow project field in Firebase apps datasource * Add tf_test to the display name * update to capitalized dependencies Rename compute_(region)_per_instance_config test files to .erb files … (GoogleCloudPlatform#7409) * Rename compute_(region)_per_instance_config test files to .erb files since the resources have fields in beta. * Omit stateful_ip tests for GA Bootstrap network cleanup (GoogleCloudPlatform#7367) * Update bootstrapped networks for alloydb * Update bootstrapped networks for redis * Update bootstrapped networks for vertexai * Update comment for BootstrapSharedTestNetwork to be more clear Fix override directory concat (GoogleCloudPlatform#7413) Bootstrap required permissions for composer environment tests (GoogleCloudPlatform#7391) * Bootstrap the required permissions * Make BootstrapAllPSARoles actually work Also adds some helper functions for debugging what the bootstrap function does. It will now log the roles that were missing in the policy. * Add missing return, fix nits * Fix typo in service agent name * Account for newly exported test functions Add maintenance_interval field to Instance Template and Instance scheduling. (GoogleCloudPlatform#7365) * Move testing to handwritten * Move testing to handwritten * Fix lint * Fix typo * Add remove step and update documentation * Add remove step and update documentation * Fix comparing string to nil * Add field to handwritten defs * rebase on main & resolve conflicts * Fix doc formatting * Add maintenance interval to Instance resource * Add maintenance interval to Instance resource * Add maintenance interval to Instance resource * Change function names to valid * Fix type mismatch * Fix type mismatch * Fix function name Fix naming of resource policies in tests to be sweepable (GoogleCloudPlatform#7412) Skip TestAccWorkstationsWorkstationConfig_workstationConfigEncryptionKeyExample (GoogleCloudPlatform#7415) Add support for Apigee Sharedflow (GoogleCloudPlatform#7202) * added sharedflows mmv1 with error * fix indentation issue for sharedflow * add semi auto generated resourceApigeeSharedFlow * remove sharedflow mmv1 and add sharedflow manual provider * adding files for debugging review, test have issue * adding files for debugging review, test have issue * update test, doc, provider for apigee * Update api.yaml remove empty new line * Update api.yaml * Rename resource_apigee_shared_flow_generated_test.go to resource_apigee_shared_flow_test.go * Update resource_apigee_shared_flow.go update import regex, change debug messages to log.Printf * Update mmv1/third_party/terraform/utils/provider.go.erb Co-authored-by: megan07 <mbang@hashicorp.com> * update PR to address comments * update test * fix sharedflow attribute update issue, add sharedflow deployment * Update apigee_shared_flow_deployment.html.markdown minor doc fix * Update mmv1/third_party/terraform/utils/provider.go.erb Co-authored-by: megan07 <mbang@hashicorp.com> * Update mmv1/third_party/terraform/website/docs/r/apigee_shared_flow.html.markdown Co-authored-by: megan07 <mbang@hashicorp.com> * Update resource_apigee_shared_flow_test.go remove commented out (unused) line of code * Delete api.yaml remove api.yaml as it is not needed for handwritten resource. Current repo structure no longer uses aggregated api.yaml * Rename apigee_shared_flow.html.markdown to apigee_sharedflow.html.markdown * Rename apigee_shared_flow_deployment.html.markdown to apigee_sharedflow_deployment.html.markdown * Rename resource_apigee_shared_flow.go to resource_apigee_sharedflow.go * Rename resource_apigee_shared_flow_deployment_test.go to resource_apigee_sharedflow_deployment_test.go * Rename resource_apigee_shared_flow_test.go to resource_apigee_sharedflow_test.go * Rename resource_apigee_shared_flow_sweeper_test.go to resource_apigee_sharedflow_sweeper_test.go * Update resource_apigee_sharedflow.go remove comment lines * Update mmv1/third_party/terraform/resources/resource_apigee_sharedflow.go Co-authored-by: megan07 <mbang@hashicorp.com> * Update resource_apigee_sharedflow_deployment_test.go remove unused debugging log * update function name to capitalize * Update resource_apigee_sharedflow_deployment_test.go remove fmt.print * add flowhook * move flowhook doc * Update mmv1/third_party/terraform/tests/resource_apigee_flowhook_test.go Co-authored-by: megan07 <mbang@hashicorp.com> * Update mmv1/third_party/terraform/website/docs/r/apigee_flowhook.html.markdown Co-authored-by: megan07 <mbang@hashicorp.com> * Update mmv1/third_party/terraform/website/docs/r/apigee_flowhook.html.markdown Co-authored-by: megan07 <mbang@hashicorp.com> * Update mmv1/third_party/terraform/tests/resource_apigee_flowhook_test.go Co-authored-by: megan07 <mbang@hashicorp.com> * Update resource_apigee_flowhook_test.go remove fmt.print * update some resource attribute properties * Update apigee_flowhook.html.markdown updated `description` and `continue_on_error` as optional * update referenced function naming case --------- Co-authored-by: Ray Xu <xrc@google.com> Co-authored-by: megan07 <mbang@hashicorp.com> add tests (GoogleCloudPlatform#7357) Co-authored-by: Edward Sun <sunedward@google.com> run gofmt + fix capitalization errors from previous PRs (GoogleCloudPlatform#7420) switch ci secrets to use secret manager (GoogleCloudPlatform#7408) Update field descriptions (GoogleCloudPlatform#7402) HA VPN over Cloud Interconnect has launched in GA We should still probably add a sample or two showing how to use it. Document PRODUCT_BASE_PATH override for DCL resource IAM (GoogleCloudPlatform#7418) yaqs/1723187608399380480 Add support for accelerators to google_datafusion_instance (GoogleCloudPlatform#6851) Added support to the field for Data Fusion, updated corresponding generated and handwritten tests, and added a custom diffsuppressfunc. Currently suggests a manual fix to a potential diff issue, will be able to update down line based on feedback from API team. Fix alloydb_cluster permadiff (GoogleCloudPlatform#7421) Fix dns_managed_zone tests using unverified domain (GoogleCloudPlatform#7422) Add SKIP_PROJECT_SWEEPER env variable for skipping the project sweeper (GoogleCloudPlatform#7432) Remove percent sign when parsing metadata name (GoogleCloudPlatform#7417) * Remove percent sign when parsing metadata name * Remove percent sign when parsing metadata name Merge branch 'GoogleCloudPlatform:main' into feature/iam_policy Add ignore read on reserved ip ranges (GoogleCloudPlatform#7429) Fix serviceusage links, clean up service resource stub (GoogleCloudPlatform#7435) Remove use of `make generate` from TPG/TPGB-specific step in CI (GoogleCloudPlatform#7379) Updating default accelerator.state field behavior in Data Fusion Instance (GoogleCloudPlatform#7434) Making suggested default behavior functionality updates in previous accelerators PR. Modify resource attribute 'input' to 'immutable' (GoogleCloudPlatform#7431) * Modify resource attribute 'input' to 'immutable' Remove noisy logging of project sweeper being skipped (GoogleCloudPlatform#7439) Fix PubSub-to-BigQuery push configuration example (GoogleCloudPlatform#7410) Rework + reflow provider reference, touch up index (GoogleCloudPlatform#7437) Fix eventarc tests to use dedicated bootstrapped keys (GoogleCloudPlatform#7440) Update docs for changing attribute `input` to `immutable` (GoogleCloudPlatform#7442) Feat name constraints (GoogleCloudPlatform#7400) Remove game_service_cluster_basic test (GoogleCloudPlatform#7443) send friendly_name (GoogleCloudPlatform#7433) * send friendly_name * fixed validator failures * update * fix validator errors --------- Co-authored-by: Edward Sun <sunedward@google.com> Fix headline of google_iam_workload_identity_pool (GoogleCloudPlatform#7449) Move IAM bootstrap to its own file, improve error messages (GoogleCloudPlatform#7424) * Move IAM bootstrap to its own file, improve errors Also bootstrap roles/cloudbuild.builds.builder for cloudbuild service agent. * Re-add BootstrapConfig (accidentally deleted) * Fix wrong variable name * Bootstrap the role previously hardcoded for pubsub * Move error message back into bootstrap function This will dedup the code that calls this function. It now returns a boolean and sends the more useful error through t.Error. * Bootstrap the permissions for pubsub service agent * Bootstrap the role in the correct test * Fix formatting Changing name field on google_compute_disk for TestAccComputeInstanceTemplate_sourceSnapshotEncryptionKey to include randomly generated string (GoogleCloudPlatform#7392) * Changed name within google_compute_disk on line 3162 to inclue and randomly generated string * Cleaned up arguments being passed in to be more inline with other tests * Updated based on addtional PR comments * Fixed swapping of values within new context If not specified, a default Workstations service agent SA is returned (GoogleCloudPlatform#7428) * If not specified, a default service agent SA is returned * Revert "Skip TestAccWorkstationsWorkstationConfig_workstationConfigEncryptionKeyExample" This reverts commit 097bdbe. * remove `rotation_period` update BigqueryDatapolicy to ga (GoogleCloudPlatform#6797) fix managed.dnsAuthorizations: (GoogleCloudPlatform#7445) Co-authored-by: Edward Sun <sunedward@google.com> google_compute_security_policy: force send enforce_on_key so it can be unset on (GoogleCloudPlatform#7454) Make `hostname` and `matcher` fields immutable (GoogleCloudPlatform#7448) Add note on requiredness (GoogleCloudPlatform#7453) Update BootstrapProject to support use across multiple projects/environments (GoogleCloudPlatform#7369) * Update BootstrapProject to support use across multiple projects/environments * Fix typo * Fix arguments for getTestProjectFromEnv * Fix project naming strategy for BootstrapProject to produce valid names in all envs * Fix typo * Fix function name after rebase Update resource names in acceptance test to use `tf-test-` prefix (GoogleCloudPlatform#7450) fix datastream_stream dataset id import (GoogleCloudPlatform#7451) Merge branch 'GoogleCloudPlatform:main' into feature/iam_policy Removing api.yaml and replacing with per product configs Merge branch 'feature/iam_policy' of https://github.com/dbjnbnrj/magic-modules into feature/iam_policy

…m#7178)

vmoros and others added 7 commits January 24, 2023 17:21

First commit. My manual testing of creating an authorized orgs desc w…

009e34c

…orks.

Merge branch 'GoogleCloudPlatform:main' into main

1662c19

Merge branch 'GoogleCloudPlatform:main' into main

5e20cb8

Creating and updating are working. Only orgs can be updated in-place.…

83c042b

… Other changes require destructive updates.

Marking the correct parameters as 'input' so Terraform will know whic…

3f54964

…h can be updated in-place and which cannot. Also updated some description strings.

Merge branch 'GoogleCloudPlatform:main' into main

3d68146

Don't skip the test

6130b03

modular-magician requested a review from shuyama1 January 27, 2023 00:28

Adding the AuthorizedOrgsDesc test to the overall ACM test sequence

eb22b20

vmoros added 4 commits January 26, 2023 20:47

Trying new way to generate access policy in the test example

46b9105

Empty push to run checks again

ec65e59

Improving test & example for authorize orgs desc

873f448

Skip generating tests for authorized orgs desc

5dc4370

drebes reviewed Jan 27, 2023

View reviewed changes

mmv1/products/accesscontextmanager/AuthorizedOrgsDesc.yaml Show resolved Hide resolved

Adding org_id to test's context

267ab53

Removing unused variable

7dba1e3

vmoros and others added 5 commits March 6, 2023 12:58

Update mmv1/third_party/terraform/tests/resource_access_context_manag…

1201f54

…er_authorized_orgs_desc_test.go Co-authored-by: Shuya Ma <87669292+shuyama1@users.noreply.github.com>

Update mmv1/third_party/terraform/tests/resource_access_context_manag…

1119f49

…er_authorized_orgs_desc_test.go Co-authored-by: Shuya Ma <87669292+shuyama1@users.noreply.github.com>

Update mmv1/third_party/terraform/tests/resource_access_context_manag…

c8f5d4b

…er_authorized_orgs_desc_test.go Co-authored-by: Shuya Ma <87669292+shuyama1@users.noreply.github.com>

Update mmv1/third_party/terraform/tests/resource_access_context_manag…

e0a2386

…er_authorized_orgs_desc_test.go Co-authored-by: Shuya Ma <87669292+shuyama1@users.noreply.github.com>

Merge branch 'GoogleCloudPlatform:main' into main

98ad4ce

modular-magician requested a review from shuyama1 March 6, 2023 21:05

shuyama1 reviewed Mar 6, 2023

View reviewed changes

mmv1/third_party/terraform/tests/resource_access_context_manager_authorized_orgs_desc_test.go Outdated Show resolved Hide resolved

Update mmv1/third_party/terraform/tests/resource_access_context_manag…

5478868

…er_authorized_orgs_desc_test.go

modular-magician requested a review from shuyama1 March 6, 2023 21:33

shuyama1 reviewed Mar 7, 2023

View reviewed changes

Removing *_UNSPECIFIED values because they're not available to users

94134ba

modular-magician requested a review from shuyama1 March 7, 2023 00:53

shuyama1 approved these changes Mar 7, 2023

View reviewed changes

shuyama1 merged commit d01b08c into GoogleCloudPlatform:main Mar 7, 2023

ericayyliu pushed a commit to ericayyliu/magic-modules that referenced this pull request Jul 26, 2023

Adding AuthorizedOrgsDesc to AccessContextManager (GoogleCloudPlatfor…

ba32999

…m#7178)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding AuthorizedOrgsDesc to AccessContextManager #7178

Adding AuthorizedOrgsDesc to AccessContextManager #7178

vmoros commented Jan 27, 2023 •

edited

Loading

modular-magician commented Jan 27, 2023

modular-magician commented Jan 27, 2023

modular-magician commented Jan 27, 2023

modular-magician commented Jan 27, 2023

modular-magician commented Jan 27, 2023

modular-magician commented Jan 27, 2023

modular-magician commented Jan 27, 2023

modular-magician commented Jan 27, 2023

modular-magician commented Jan 27, 2023

modular-magician commented Jan 27, 2023

modular-magician commented Jan 27, 2023

modular-magician commented Jan 27, 2023

modular-magician commented Jan 30, 2023

modular-magician commented Jan 30, 2023

shuyama1 commented Mar 6, 2023

modular-magician commented Mar 6, 2023

modular-magician commented Mar 6, 2023

shuyama1 left a comment

shuyama1 commented Mar 6, 2023

modular-magician commented Mar 6, 2023

modular-magician commented Mar 6, 2023

modular-magician commented Mar 6, 2023

shuyama1 left a comment

shuyama1 Mar 6, 2023

shuyama1 Mar 7, 2023

vmoros Mar 7, 2023

shuyama1 commented Mar 7, 2023

modular-magician commented Mar 7, 2023

modular-magician commented Mar 7, 2023

modular-magician commented Mar 7, 2023

shuyama1 left a comment

Adding AuthorizedOrgsDesc to AccessContextManager #7178

Adding AuthorizedOrgsDesc to AccessContextManager #7178

Conversation

vmoros commented Jan 27, 2023 • edited Loading

modular-magician commented Jan 27, 2023

modular-magician commented Jan 27, 2023

modular-magician commented Jan 27, 2023

Diff report

modular-magician commented Jan 27, 2023

Diff report

modular-magician commented Jan 27, 2023

Tests analytics

Action taken

modular-magician commented Jan 27, 2023

modular-magician commented Jan 27, 2023

Diff report

modular-magician commented Jan 27, 2023

Tests analytics

Action taken

modular-magician commented Jan 27, 2023

modular-magician commented Jan 27, 2023

Diff report

modular-magician commented Jan 27, 2023

Tests analytics

Action taken

modular-magician commented Jan 27, 2023

modular-magician commented Jan 30, 2023

Diff report

modular-magician commented Jan 30, 2023

Tests analytics

Action taken

shuyama1 commented Mar 6, 2023

modular-magician commented Mar 6, 2023

Diff report

modular-magician commented Mar 6, 2023

Tests analytics

shuyama1 left a comment

Choose a reason for hiding this comment

shuyama1 commented Mar 6, 2023

modular-magician commented Mar 6, 2023

Diff report

modular-magician commented Mar 6, 2023

Tests analytics

Action taken

modular-magician commented Mar 6, 2023

shuyama1 left a comment

Choose a reason for hiding this comment

shuyama1 Mar 6, 2023

Choose a reason for hiding this comment

shuyama1 Mar 7, 2023

Choose a reason for hiding this comment

vmoros Mar 7, 2023

Choose a reason for hiding this comment

shuyama1 commented Mar 7, 2023

modular-magician commented Mar 7, 2023

Diff report

modular-magician commented Mar 7, 2023

Tests analytics

Action taken

modular-magician commented Mar 7, 2023

shuyama1 left a comment

Choose a reason for hiding this comment

vmoros commented Jan 27, 2023 •

edited

Loading