Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release Stabilisation Bugfixing 4 #2946

Merged
merged 34 commits into from
May 9, 2022
Merged

Release Stabilisation Bugfixing 4 #2946

merged 34 commits into from
May 9, 2022

Conversation

thesan
Copy link
Collaborator

@thesan thesan commented Apr 29, 2022

Reminders:

thesan and others added 30 commits April 12, 2022 17:07
* GeneralParametersStep refactor

* AddBountyModal form refactor

* Stories cleanup

* Machine cleanup

* Improvements based on meeting

* Test fixes

* Build fixes

* Replace "Controlled" naming

* Build fixes
* Proposal: Slash WG Lead needs to show current stake by lead

* Add leadWorkerStake & setLeadWorkerStake to SlashWorkingGroupLeadParameters & SlashWorkingGroupLeadProps

* Show working group name.

* Show working group name.
🎖️ Fix on flashing validation when selecting staking account (#2852)
* husky added

* additional rule added

* new rule

* additional rule

* html added

* test lint

* new rules added

* Optimize tsconfig

* Run eslint first

* Fix the typescript config

Co-authored-by: tomekstepien <tomasz.stepien@elliptic.co>
Co-authored-by: Theophile Sandoz <theophile.sandoz@gmail.com>
* leave role fixed

* leave role fixed

* condition fixed

Co-authored-by: tomekstepien <tomasz.stepien@elliptic.co>
* Initial commit

* Validation on pasting account address

* New validation helpers

* Making SelectAccount.tsx controllable

* AddBountyModal update on validation helpers

* Rework on stake step of ApplyForRoleModal.tsx

* Rework on form step of ApplyForRoleModal.tsx

* Extracting helpers to new file

* Making form question component controllable

* Main modal refactor

* Code cleanup

* Test fix
Co-authored-by: tomekstepien <tomasz.stepien@elliptic.co>
Co-authored-by: tomekstepien <tomasz.stepien@elliptic.co>
* Create members only once in `createMembersCommand`

* Add the `addUpcomingOpeningCommand`

* Document the upcoming opening creation script
Merge olympia hotfixes (#2862) into dev
* Extract vote stake locks logic to hook

* Apply useIsVoteStakeLocked in past votes

* Refactor useIsCouncilMember hook

* Apply useIsCouncilMember hook

* Fix boolean type

* Pass electionFinished to hook

* Use isCouncilMember instead of hook

* Use isCouncilMember in Member

* Delete useIsCouncilMember hook

* Fix useIsVoteStakeLocked logic

* Add isCouncilMember to member mock data

* Fix ProposalPreview test
Co-authored-by: tomekstepien <tomasz.stepien@elliptic.co>
* Add an helper command to benchmark `paymentInfo`

* Benchmark the api transaction in the app

* Format the average time better

* Improve the `api-benchmarking` script
* Fixes on ContributeFundsModal

* Test update
* Exclude Voting from conflicting locks

* Refactor isConflictingWith function

* Fix test
* Show correct stake required for the WG Opening.

* Pre-populate required stake with the minimum required stake.
* POC on AddNewProposalModal

* Refactor on AnnounceWorkEntry

* Refactor on ContributeFundsModal

* Refactor on WithdrawWorkEntryModal

* Refactor on WithdrawStakeModal

* Refactor on AnnounceCandidacyModal

* Making transaction streamable

* Bringing back global loading modal on fee calculation

* Refactor on VoteForProposalModal

* Refactor on ApplyForRoleModal

* Refactor on EditPostModal

* Refactor on DeletePostModal

* Refactor on CreatePostModal

* Refactor on DeleteThreadModal

* Refactor on CreateThreadModal

* Simplify the `useTransactionFee` hook

Co-authored-by: Theophile Sandoz <theophile.sandoz@gmail.com>
* Fixed #2838

* Fixed #2838 - case

* PR comments addressed

* revert changes in AddProposalModal
* style fixes - part I

* ongoing status added

* schema updated

* time calculation for bounty

Co-authored-by: tomekstepien <tomasz.stepien@elliptic.co>
…2902)

* Pass placeholder as props for SelectWorkingGroupOpening.

* Update text to correspond the SOW>

* Update text for cancel opening.

* Update text.

* Upldate placeholder text for SelectWorkingGroupApplication to Choose application.

* Make placeholder a property of SelectWorkingGroupApplication.
* query and hook updated

* deadline list improved

* tests fixed

* improvements added

* improvements added

* Finalize the PR

Co-authored-by: tomekstepien <tomasz.stepien@elliptic.co>
Co-authored-by: Theophile Sandoz <theophile.sandoz@gmail.com>
* Exposing transaction events to context

* Handling displaying error messages on status modal

* Passing observed error events into machine

* Changes based on call

* Tests improvements
* Fix script for creating opening mock

* Include status in proposal discussions posts

* Fix postId and proposalId order

* Filter deleted posts

* Fix checkbox behavior
WRadoslaw and others added 3 commits April 29, 2022 18:23
* Fixes on AnnounceWorkEntryModal

* Tooltip added

* Test fix
* Making local-mocks invisible in production

* Fix on seeding error

* Fix contentWorkingGroup name in mocks and regenerate mocks

* Fix ContentWorkingGroup page test

* Show the `local-mocks` option in development mode

* Fix tests

Co-authored-by: WRadoslaw <r.wyszynski00@gmail.com>
Co-authored-by: Theophile Sandoz <theophile.sandoz@gmail.com>
@thesan thesan requested a review from dmtrjsg April 29, 2022 16:53
@vercel
Copy link

vercel bot commented Apr 29, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
dao ✅ Ready (Inspect) Visit Preview May 9, 2022 at 9:58AM (UTC)
pioneer-2 ✅ Ready (Inspect) Visit Preview May 9, 2022 at 9:58AM (UTC)
pioneer-2-storybook ✅ Ready (Inspect) Visit Preview May 9, 2022 at 9:58AM (UTC)
pioneer-rhodes ✅ Ready (Inspect) Visit Preview May 9, 2022 at 9:58AM (UTC)

@traumschule
Copy link
Collaborator

lgtm, using this regularly, especially for voting. two issues remain: #2985 #2986

Copy link
Contributor

@dmtrjsg dmtrjsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lezzgo!

@thesan thesan merged commit 6799dce into olympia May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants