Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge master into v12.3.0 #27392

Merged
merged 10 commits into from
Sep 25, 2024
Merged

Merge master into v12.3.0 #27392

merged 10 commits into from
Sep 25, 2024

Commits on Sep 11, 2024

  1. Version v12.2.3

    metamaskbot committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    75fed52 View commit details
    Browse the repository at this point in the history
  2. fix (cherry-pick): Adding patch on eth-json-rpc-middleware to disable…

    … verifyContract field validation for cosmos (#27065)
    
    Cherry-picks #27021
    (4ee09fc)
    
    ## **Description**
    
    Adding patch on eth-json-rpc-middleware to disable verifyContract field
    validation for cosmos
    
    ## **Related issues**
    
    Fixes: #26980
    
    ## **Manual testing steps**
    
    1. Submit a types signature request with verifyingContract set to
    `cosmos`
    2. Ensure that you are able to sign it
    
    ## **Screenshots/Recordings**
    <img width="360" alt="Screenshot 2024-09-10 at 4 08 00 PM"
    src="https://github.com/user-attachments/assets/a56bb8bd-abed-4fae-9c50-a3a25addd5b5">
    
    ## **Pre-merge author checklist**
    
    - [X] I've followed [MetaMask Contributor
    Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
    Extension Coding
    Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
    - [X] I've completed the PR template to the best of my ability
    - [X] I’ve included tests if applicable
    - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
    if applicable
    - [X] I’ve applied the right labels on the PR (see [labeling
    guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
    Not required for external contributors.
    
    ## **Pre-merge reviewer checklist**
    
    - [ ] I've manually tested the PR (e.g. pull and build branch, run the
    app, test code being changed).
    - [ ] I confirm that this PR addresses all acceptance criteria described
    in the ticket it closes and includes the necessary testing evidence such
    as recordings and or screenshots.
    jpuri authored Sep 11, 2024
    Configuration menu
    Copy the full SHA
    5eaa9d3 View commit details
    Browse the repository at this point in the history
  3. v12.2.3 changelog (#27073)

    Updates the changelog for v12.2.3
    danjm authored Sep 11, 2024
    Configuration menu
    Copy the full SHA
    3611836 View commit details
    Browse the repository at this point in the history
  4. Merge pull request #27066 from MetaMask/Version-v12.2.3

    Version v12.2.3 RC
    danjm authored Sep 11, 2024
    Configuration menu
    Copy the full SHA
    086bb90 View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2024

  1. Version v12.2.4

    metamaskbot committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    5de824b View commit details
    Browse the repository at this point in the history
  2. Update changelog for v12.2.4 (#27207)

    V12.2.4 changelog
    danjm authored Sep 17, 2024
    Configuration menu
    Copy the full SHA
    4b48aa9 View commit details
    Browse the repository at this point in the history
  3. fix(cherry-pick) : selector getKnownMethodData should return empty ob…

    …ject if user has opted out for using 4Byte Resolution (#27213)
    
    ## **Description**
    If user has toggled off **Decode smart contracts** setting he is not
    able to approve ERC20. This is regression introduced recently.
    
    ## **Related issues**
    
    Fixes: #27188
    
    ## **Manual testing steps**
    
    1. Toggle off setting "Decode smart contracts"
    2. Try to approve an ERC 20 
    3. It should not throw error
    
    ## **Screenshots/Recordings**
    
    
    https://github.com/user-attachments/assets/7f0fd8f9-3d97-4f4b-8e99-c694445ad929
    
    
    ## **Pre-merge author checklist**
    
    - [X] I've followed [MetaMask Contributor
    Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
    Extension Coding
    Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
    - [X] I've completed the PR template to the best of my ability
    - [X] I’ve included tests if applicable
    - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
    if applicable
    - [X] I’ve applied the right labels on the PR (see [labeling
    guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
    Not required for external contributors.
    
    ## **Pre-merge reviewer checklist**
    
    - [ ] I've manually tested the PR (e.g. pull and build branch, run the
    app, test code being changed).
    - [ ] I confirm that this PR addresses all acceptance criteria described
    in the ticket it closes and includes the necessary testing evidence such
    as recordings and or screenshots.
    jpuri authored Sep 17, 2024
    Configuration menu
    Copy the full SHA
    a09d076 View commit details
    Browse the repository at this point in the history
  4. Merge pull request #27206 from MetaMask/Version-v12.2.4

    Version v12.2.4 RC
    danjm authored Sep 17, 2024
    Configuration menu
    Copy the full SHA
    d6b95fc View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2024

  1. Configuration menu
    Copy the full SHA
    b17fc84 View commit details
    Browse the repository at this point in the history
  2. Fix changelog lint error

    danjm committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    eca8bdb View commit details
    Browse the repository at this point in the history