-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge master into v12.3.0 #27392
Merge master into v12.3.0 #27392
Commits on Sep 11, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 75fed52 - Browse repository at this point
Copy the full SHA 75fed52View commit details -
fix (cherry-pick): Adding patch on eth-json-rpc-middleware to disable…
… verifyContract field validation for cosmos (#27065) Cherry-picks #27021 (4ee09fc) ## **Description** Adding patch on eth-json-rpc-middleware to disable verifyContract field validation for cosmos ## **Related issues** Fixes: #26980 ## **Manual testing steps** 1. Submit a types signature request with verifyingContract set to `cosmos` 2. Ensure that you are able to sign it ## **Screenshots/Recordings** <img width="360" alt="Screenshot 2024-09-10 at 4 08 00 PM" src="https://github.com/user-attachments/assets/a56bb8bd-abed-4fae-9c50-a3a25addd5b5"> ## **Pre-merge author checklist** - [X] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [X] I've completed the PR template to the best of my ability - [X] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [X] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
Configuration menu - View commit details
-
Copy full SHA for 5eaa9d3 - Browse repository at this point
Copy the full SHA 5eaa9d3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3611836 - Browse repository at this point
Copy the full SHA 3611836View commit details -
Merge pull request #27066 from MetaMask/Version-v12.2.3
Version v12.2.3 RC
Configuration menu - View commit details
-
Copy full SHA for 086bb90 - Browse repository at this point
Copy the full SHA 086bb90View commit details
Commits on Sep 17, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 5de824b - Browse repository at this point
Copy the full SHA 5de824bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4b48aa9 - Browse repository at this point
Copy the full SHA 4b48aa9View commit details -
fix(cherry-pick) : selector getKnownMethodData should return empty ob…
…ject if user has opted out for using 4Byte Resolution (#27213) ## **Description** If user has toggled off **Decode smart contracts** setting he is not able to approve ERC20. This is regression introduced recently. ## **Related issues** Fixes: #27188 ## **Manual testing steps** 1. Toggle off setting "Decode smart contracts" 2. Try to approve an ERC 20 3. It should not throw error ## **Screenshots/Recordings** https://github.com/user-attachments/assets/7f0fd8f9-3d97-4f4b-8e99-c694445ad929 ## **Pre-merge author checklist** - [X] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [X] I've completed the PR template to the best of my ability - [X] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [X] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
Configuration menu - View commit details
-
Copy full SHA for a09d076 - Browse repository at this point
Copy the full SHA a09d076View commit details -
Merge pull request #27206 from MetaMask/Version-v12.2.4
Version v12.2.4 RC
Configuration menu - View commit details
-
Copy full SHA for d6b95fc - Browse repository at this point
Copy the full SHA d6b95fcView commit details
Commits on Sep 25, 2024
-
Configuration menu - View commit details
-
Copy full SHA for b17fc84 - Browse repository at this point
Copy the full SHA b17fc84View commit details -
Configuration menu - View commit details
-
Copy full SHA for eca8bdb - Browse repository at this point
Copy the full SHA eca8bdbView commit details