Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMPROVE] Custom sounds refactor #17485

Merged
merged 28 commits into from
May 5, 2020
Merged

[IMPROVE] Custom sounds refactor #17485

merged 28 commits into from
May 5, 2020

Conversation

MartinSchoeler
Copy link
Contributor

@MartinSchoeler MartinSchoeler commented Apr 29, 2020 •
edited
Loading

TODO:

  • Fix reactiveness on main list
  • Add some form of informing text to the upload button
  • Iron out bugs and inconsistencies

@MartinSchoeler MartinSchoeler changed the base branch from develop to admin-refactor April 29, 2020 22:57
@lgtm-com
Copy link

lgtm-com bot commented Apr 29, 2020

This pull request introduces 2 alerts when merging eccef79 into 84169b6 - view on LGTM.com

new alerts:

  • 2 for Property access on null or undefined

@lgtm-com
Copy link

lgtm-com bot commented Apr 29, 2020

This pull request introduces 2 alerts when merging eccef79 into 60e1452 - view on LGTM.com

new alerts:

  • 2 for Property access on null or undefined

@MartinSchoeler MartinSchoeler requested a review from a team May 4, 2020 15:01
MartinSchoeler
MartinSchoeler commented May 4, 2020
View reviewed changes
app/custom-sounds/client/admin/EditSound.js Outdated
<Box display='flex' flexDirection='row' mbs='none'>
<Margins inline='x4'>
<Button square onClick={clickUpload}><Icon name='upload' size='x20'/></Button>
{(sound && sound.name) || 'none'}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need a better element to add this info, any suggestions?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<Box is='span' />?

MartinSchoeler and others added 5 commits May 4, 2020 14:00
@MartinSchoeler
Remove old files
c4abce2
@MartinSchoeler
Hook me up!
658c5ad
@MartinSchoeler
lint
97e3ef5
@ggazzo
Merge branch 'admin-refactor' into custom-sounds-refactor
f027a40 
* admin-refactor:
  Regression: Removed old user and room files from admin (#17528)
  [IMPROVE] Custom emoji refactor (#17499)
  Fix storybook
  LingoHub based on develop (#17520)
  RegExp improvements suggested by LGTM (#17500)
@ggazzo
Fix review
c0b2781
@lgtm-com
Copy link

lgtm-com bot commented May 5, 2020

This pull request introduces 1 alert and fixes 2 when merging c0b2781 into db7b469 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

fixed alerts:

  • 2 for Superfluous trailing arguments

@lgtm-com
Copy link

lgtm-com bot commented May 5, 2020

This pull request fixes 2 alerts when merging c5101b5 into db7b469 - view on LGTM.com

fixed alerts:

  • 2 for Superfluous trailing arguments

@MartinSchoeler MartinSchoeler marked this pull request as ready for review May 5, 2020 15:04
@lgtm-com
Copy link

lgtm-com bot commented May 5, 2020

This pull request fixes 2 alerts when merging e78f4a7 into db7b469 - view on LGTM.com

fixed alerts:

  • 2 for Superfluous trailing arguments

@MartinSchoeler MartinSchoeler changed the title [WIP] Custom sounds refactor [IMPROVE] Custom sounds refactor May 5, 2020
@ggazzo ggazzo merged commit 9896f31 into admin-refactor May 5, 2020
@ggazzo ggazzo deleted the custom-sounds-refactor branch May 5, 2020 15:25
gabriellsh added a commit that referenced this pull request May 6, 2020
@gabriellsh
Merge branch 'admin-refactor' of github.com:RocketChat/Rocket.Chat in…
d03803d 
…to integrations

* 'admin-refactor' of github.com:RocketChat/Rocket.Chat:
  fix all paddings and mixed content between screens (#17538)
  [IMPROVE] Add new webhooks to the Omnichannel integration feature (#17503)
  [BREAK] Remove deprecated Omnichannel Knowledge Base feature (#17387)
  [FIX] Reactions may present empty names of who reacted when using Real Names (#17536)
  [IMPROVE] Custom sounds refactor (#17485)
  Allow to filter omnichannel analytics dashboards per departments. (#17463)
  [FIX] Uncessary updates on Settings, Roles and Permissions on startup (#17160)
  [NEW] Add the ability to send Livechat offline messages to a channel (#17442)
  [FIX] Federation attachment URL for audio and video files (#16430)
  [NEW] Add Livechat website URL to the offline message e-mail (#17429)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabriellsh gabriellsh gabriellsh left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MartinSchoeler @gabriellsh @ggazzo