Finalize Buildpack API 0.8 #302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Fixes link to SBOM section in buildpack spec
Add sbom as a reserved buildpack ID
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Add deprecation path for buildpacks using the legacy BOM format.
Signed-off-by: Natalie Arellano <narellano@vmware.com>
…le.d Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com> Co-authored-by: Emily Casey <ecasey@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Per RFC 100: https://github.com/buildpacks/rfcs/blob/main/text/0100-buildpack-input-vars.md Fixes #294. Signed-off-by: Mikey Boldt <mboldt@vmware.com>
Signed-off-by: Mikey Boldt <mboldt@vmware.com>
Signed-off-by: Mikey Boldt <mboldt@vmware.com>
Process specific working directory
Signed-off-by: Mikey Boldt <mboldt@vmware.com>
- Remove API version headings. - Add "Deprecated in Buildpack API X.Y" to each item. - Order the list of deprecations newest-on-top. Signed-off-by: Mikey Boldt <mboldt@vmware.com>
Deprecate positional args to `build` and `detect` and add env vars
natalieparellano
requested review from
ekcasey,
nebhale,
hone,
jkutner and
sclevine
jkutner
approved these changes
Apr 1, 2022
sambhav
approved these changes
Apr 1, 2022
nebhale
approved these changes
Apr 4, 2022
sclevine
approved these changes
Apr 4, 2022
ekcasey
reviewed
Apr 5, 2022
buildpack.md
Outdated
Comment on lines
125
to
126
| | `$CNB_BUILD_PLAN_PATH` | E | Absolute path of the build plan | | ||
| | `$CNB_PLATFORM_DIR` | AR | Absolute path of the platform directory | |
There was a problem hiding this comment.
Suggested change
| | `$CNB_BUILD_PLAN_PATH` | E | Absolute path of the build plan | | |
| | `$CNB_PLATFORM_DIR` | AR | Absolute path of the platform directory | | |
| | `$CNB_BUILD_PLAN_PATH` | E | Absolute path of the build plan | | |
| | `$CNB_BUILDPACK_DIR` | ER | Absolute path of the buildpack root directory | | |
| | `$CNB_PLATFORM_DIR` | AR | Absolute path of the platform directory | |
Realizing that it is strange not to include the buildpack dir here. Maybe we want to get rid of https://github.com/buildpacks/spec/pull/302/files#diff-d5ffdcac80bcacec34b3a8a1ba9da8efbbc4df5ad118ec581201736330f73183R746?
There was a problem hiding this comment.
Maybe my browser is busted, but I'm not sure where that link points to, but I agree we should probably include buildpack dir here.
There was a problem hiding this comment.
Apologies, please see #304 - if we merge that PR before we merge this one, it will have the effect intended by these suggestions.
There was a problem hiding this comment.
Is #304 intended to be merged as part of this?
There was a problem hiding this comment.
Yes, first 304 and then this one. I couldn't commit directly to the buildpack/0.8 branch.
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
List CNB_BUILDPACK_DIR with other lifecycle provided variables
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.