-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finalize Buildpack API 0.8 #302
Conversation
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Fixes link to SBOM section in buildpack spec
Add sbom as a reserved buildpack ID
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Add deprecation path for buildpacks using the legacy BOM format.
Signed-off-by: Natalie Arellano <narellano@vmware.com>
…le.d Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com> Co-authored-by: Emily Casey <ecasey@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Per RFC 100: https://github.com/buildpacks/rfcs/blob/main/text/0100-buildpack-input-vars.md Fixes #294. Signed-off-by: Mikey Boldt <mboldt@vmware.com>
Signed-off-by: Mikey Boldt <mboldt@vmware.com>
Signed-off-by: Mikey Boldt <mboldt@vmware.com>
Process specific working directory
Signed-off-by: Mikey Boldt <mboldt@vmware.com>
- Remove API version headings. - Add "Deprecated in Buildpack API X.Y" to each item. - Order the list of deprecations newest-on-top. Signed-off-by: Mikey Boldt <mboldt@vmware.com>
Deprecate positional args to `build` and `detect` and add env vars
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving, but I'd suggest we make the attributes columns more clear somehow, evenually
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies if the table alignment is off in some of these suggestions.
buildpack.md
Outdated
| `$CNB_BUILD_PLAN_PATH` | E | Absolute path of the build plan | | ||
| `$CNB_PLATFORM_DIR` | AR | Absolute path of the platform directory | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| `$CNB_BUILD_PLAN_PATH` | E | Absolute path of the build plan | | |
| `$CNB_PLATFORM_DIR` | AR | Absolute path of the platform directory | | |
| `$CNB_BUILD_PLAN_PATH` | E | Absolute path of the build plan | | |
| `$CNB_BUILDPACK_DIR` | ER | Absolute path of the buildpack root directory | | |
| `$CNB_PLATFORM_DIR` | AR | Absolute path of the platform directory | |
Realizing that it is strange not to include the buildpack dir here. Maybe we want to get rid of https://github.com/buildpacks/spec/pull/302/files#diff-d5ffdcac80bcacec34b3a8a1ba9da8efbbc4df5ad118ec581201736330f73183R746?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe my browser is busted, but I'm not sure where that link points to, but I agree we should probably include buildpack dir here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies, please see #304 - if we merge that PR before we merge this one, it will have the effect intended by these suggestions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is #304 intended to be merged as part of this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, first 304 and then this one. I couldn't commit directly to the buildpack/0.8 branch.
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
List CNB_BUILDPACK_DIR with other lifecycle provided variables
No description provided.