-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Start standalone using spacetime start #91
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tyler Cloutier <cloutiertyler@users.noreply.github.com>
Co-authored-by: Tyler Cloutier <cloutiertyler@aol.com>
* Clippy runs on default module * Fix clippy issue with default module --------- Co-authored-by: Boppy <no-reply@boppygames.gg>
* I think somehow we are adding all tables as orphans, added log * Removed unneeded clone --------- Co-authored-by: Boppy <no-reply@boppygames.gg>
* Forbid unsupported syntax in SELECT (like ORDER BY) & improve accuracy of sql test suite * Update crates/sqltest/src/main.rs Co-authored-by: Mazdak Farrokhzad <twingoow@gmail.com> Signed-off-by: Mario Montoya <mamcx@elmalabarista.com> --------- Signed-off-by: Mario Montoya <mamcx@elmalabarista.com> Co-authored-by: Mazdak Farrokhzad <twingoow@gmail.com>
Signed-off-by: John Detter <4099508+jdetter@users.noreply.github.com> Co-authored-by: Boppy <no-reply@boppygames.gg>
* Working on improving commands that use identities * Fix lints * Reverted file that shouldn't have changed * Found and fixed all other todos * Addressed more CLI TODOs * Fixes for formatting issues * Set names of identities * Set name of identities + clippy * Small fix * Added the start of a doc comment, switching over to another PR * Fixed tests that needed to be updated * Addressed more feedback and fixed several clippy issues * Small fix * Apply suggestions from code review Co-authored-by: Mazdak Farrokhzad <twingoow@gmail.com> Signed-off-by: John Detter <4099508+jdetter@users.noreply.github.com> * Added more doc comments * Addressing more feedback * Fixed really old bug in SpacetimeDB * Tests to verify new functionality * Fix clippy lints * Email during identity creation is optional * Fix output so testsuite passes --------- Signed-off-by: John Detter <4099508+jdetter@users.noreply.github.com> Co-authored-by: Boppy <no-reply@boppygames.gg> Co-authored-by: Mazdak Farrokhzad <twingoow@gmail.com>
* Some work * Getting smoketests working on mac * All tests are passing except known failing tests --------- Co-authored-by: Boppy <no-reply@boppygames.gg>
…urn wether or not reducer has subscribers; Moved all ReducerEvent and ReducerArgs code into a single file (#10) Co-authored-by: Steve <steve@codefics.com>
Co-authored-by: Boppy <no-reply@boppygames.gg>
* Changed C# reducer signature; Change reducer invocation method to return wether or not reducer has subscribers; Moved all ReducerEvent and ReducerArgs code into a single file * Formatting, tests * Clippy * Removed union from C# codegen * Tests * Update crates/cli/src/subcommands/generate/csharp.rs Co-authored-by: Tyler Cloutier <cloutiertyler@users.noreply.github.com> Signed-off-by: John Detter <4099508+jdetter@users.noreply.github.com> * Removed duplicate code * Lint * Clippy * CLIPPY * Generating custom indexes for unique / primary keys --------- Signed-off-by: John Detter <4099508+jdetter@users.noreply.github.com> Co-authored-by: Steve <steve@codefics.com> Co-authored-by: John Detter <4099508+jdetter@users.noreply.github.com> Co-authored-by: Tyler Cloutier <cloutiertyler@users.noreply.github.com>
* Fix incomplete transaction bug * Clippy
Co-authored-by: Steve <steve@codefics.com>
tokio runtimes cannot be nested, so we only create one if no ambient context can be found and pass around a runtime handle for spawning tasks.
* integrate jdetter's review * address phoebe's comments * improve errnos naming
Prior to this commit, callbacks in the Rust client SDK shared access to the global ClientCache while running asynchronously. This meant that a long-running or delayed callback could observe the ClientCache in a state later than the one that caused the callback's invocation, and had no way to access the specific state for which it was invoked. With this commit, each `Invoke` message to the callback worker includes an `Arc<ClientCache>` snapshot of the DB state when that callback was invoked. The callback worker stores that state in a `thread_local`, and methods that inspect tables (e.g. `TableType::iter`) read the state out of the `thread_local` when it is present. This allows callbacks to observe exactly the state which caused their invocation, never a later state, while maintaining the C#-like API where `ClientCache` access is based on free functions or static trait methods. --------- Co-authored-by: John Detter <4099508+jdetter@users.noreply.github.com>
* Fix bug and added a test * Test updates * Fix tests --------- Co-authored-by: Boppy <no-reply@boppygames.gg>
…ialization changes
spacetimedb.com/spacetimedb Co-authored-by: Boppy <no-reply@boppygames.gg>
This commit renames the first argument to connect from host to spacetimedb_uri. It's not just a host(name), it's the URI of the SpacetimeDB instance.
* Fix bug in locating fields when a JOIN clause is present * Update crates/lib/src/relation.rs Co-authored-by: Mazdak Farrokhzad <twingoow@gmail.com> Signed-off-by: Mario Montoya <mamcx@elmalabarista.com> * Update crates/lib/src/relation.rs Co-authored-by: Mazdak Farrokhzad <twingoow@gmail.com> Signed-off-by: Mario Montoya <mamcx@elmalabarista.com> * Update crates/core/src/subscription/subscription.rs Co-authored-by: Mazdak Farrokhzad <twingoow@gmail.com> Signed-off-by: Mario Montoya <mamcx@elmalabarista.com> * Update crates/core/src/subscription/subscription.rs Co-authored-by: Mazdak Farrokhzad <twingoow@gmail.com> Signed-off-by: Mario Montoya <mamcx@elmalabarista.com> * Update crates/core/src/subscription/subscription.rs Co-authored-by: Mazdak Farrokhzad <twingoow@gmail.com> Signed-off-by: Mario Montoya <mamcx@elmalabarista.com> * Update crates/core/src/subscription/query.rs Co-authored-by: Mazdak Farrokhzad <twingoow@gmail.com> Signed-off-by: Mario Montoya <mamcx@elmalabarista.com> * Small doc nits * Fix test --------- Signed-off-by: Mario Montoya <mamcx@elmalabarista.com> Co-authored-by: Mazdak Farrokhzad <twingoow@gmail.com>
This commit adds the `quickstart-chat` Rust module and client to the appropriate examples dirs.
* Refactoring some stuff for energy * Fix an issue with i128 query params * Infinite budget in Standalone * Energy and crash fixes * Hopefully fixed the test that now has energy * Addresses Centril's comments * Cargo fmt --------- Signed-off-by: Tyler Cloutier <cloutiertyler@users.noreply.github.com>
Committing suggested changes (comments only for now) Co-authored-by: Mazdak Farrokhzad <twingoow@gmail.com> Signed-off-by: John Detter <4099508+jdetter@users.noreply.github.com>
Signed-off-by: Tyler Cloutier <cloutiertyler@users.noreply.github.com>
Signed-off-by: Tyler Cloutier <cloutiertyler@users.noreply.github.com>
Co-authored-by: Derek Brinkmann <dbrinkmann@citadelstudios.net>
cloutiertyler
approved these changes
Aug 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I've tested this with the changes and it no longer requires the $HOME env variable |
cloutiertyler
force-pushed
the
master
branch
3 times, most recently
from
August 1, 2023 21:10
1ec98b1
to
d3fd5ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
spacetime start
standalone
is now a default feature for thespacetimedb-cli
crate, if this feature is enabled then standalone will be compiled into the cli. If this feature isn't enabled thenspacetime start
will not work but will substantially speed up the compilation time of thespacetimedb-cli
crate.This command contains all of the options that were previously available in
spacetimedb start
, plus some options that I've added for convienence. The help section is explicit about its operation:You can start a new instance of spacetimedb with just:
Internally our developers may find it useful to create another database via:
spacetime start --allow-create "~/.spacetime/another_database"
API
If the API is breaking, please state below what will break